Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes swap transactions showing up as bridge #30656

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

ghgoodreau
Copy link
Contributor

@ghgoodreau ghgoodreau commented Feb 28, 2025

Description

This change removes the bug that causes solana swaps to display as bridges in the activity tab.

The solution is to check for the txType being 'swap' when mapping the snap transactions list with the bridge activity list.

This mapping will be removed in the future for a more robust bridge activity list.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-2030

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ghgoodreau ghgoodreau marked this pull request as ready for review February 28, 2025 21:09
@ghgoodreau ghgoodreau requested a review from a team as a code owner February 28, 2025 21:09
ejwessel
ejwessel previously approved these changes Feb 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [3e53161]
Page Load Metrics (1683 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15531930168511455
domContentLoaded15401901166210952
load15561906168310852
domInteractive2497392211
backgroundConnect116928189
firstReactRender1570392311
getState45113136
initialActions01000
loadScripts1097147112159043
setupStore75512105
uiStartup17152180189712259
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@ghgoodreau ghgoodreau added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit b6bb68d Mar 4, 2025
74 checks passed
@ghgoodreau ghgoodreau deleted the MMS-2030-fix-swap-txs-showing-as-bridge branch March 4, 2025 19:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-bridge team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants