[Bug]: dApp remains connected to the previous chain, swap Confirmation indicates wrong network

[sleepytanya]

Describe the bug

PancakeSwap connects only and stays connected to the BNB network, despite efforts to switch to a different network either through the Permissions settings or directly from the dApp's network selector.
Although the interface displays icons representing the globally selected network, and Confirmations indicate that swaps are set up on this chosen network, the actual transactions are submitted on the BNB network.

Expected behavior

Screenshots/Recordings

https://www.loom.com/share/d52cd107afff441c8b09bd3eb22cd90f?sid=409eedb1-a650-4dbe-a616-4c3d47ce8bb3

Steps to reproduce

1. Connect to any network other than BNB
2. Connect to PancakeSwap
3. Observe, that the dapp connects and stays on BNB
4. Start and submit swap

Error messages or log output

Detection stage

On a feature branch

Version

8.39.0 (1544)

Build type

None

Device

iPhone 15

Operating system

iOS

Additional context

No response

Severity

No response

[Unik0rnMaggie]

Reproduced on Android, QA4 build:

Similar behavior to Uniswap: Even though the network in MM does not switch, the swap is executed on the network of the dapp

Pancakeswap.QA4.build.mp4

[Unik0rnMaggie]

Android and iOS: error on Pancakeswap:

Android:

https://www.loom.com/share/f9764f0d00fb4396a4e347c27acf0f5a?sid=c4020471-fc78-47d7-b1b8-6898cf6087b7

iOS:

Pancakeswap.error.iOS.mp4

[Unik0rnMaggie]

It seems the error is present only when the wallet is on Ethereum Mainnet.

When the wallet is on other networks, the swap is possible (but the transaction is confirmed on the network of the dapp, not the network of the wallet):

https://www.loom.com/share/bb350fd0c7894f7ca4b854c85457568b?sid=41b0de6d-638e-41f8-91c5-ff90b8d9fd09

[EtherWizard33]

Reproduced on Android, QA4 build:

Similar behavior to Uniswap: Even though the network in MM does not switch, the swap is executed on the network of the dapp

Pancakeswap.QA4.build.mp4

I watched the recording and takeaways I see is

• the connection is made network is chosen from the dapp menu just before the connection is made, it's confirms that you are also seeing the same problem menionned by Tanya above, in her Loom, where we can see that in the confirmation screen, the network of the dapp (per-dapp-selected-network) is not showing as expected, but instead the network of the wallet is showing. Not ok, and I have messaged the confirmations team about it from the slack evm thread pointing to Tanya's loom.
• this recording also shows that you switched from the dapp to arbittrum from the dapp and show the wallet network is the stayed on base, and then switched the dapp to llinea, and the wallet's network stayed on base. That is expected since the goal of these tests is to have an overview if the work by A.Donesky made in September to introduce per-dapp-selected-network is working or broken. In this example it looks like its working since the dapp has its own network, and the wallet is on another, so that is OK.

Thanks for the testing so far @Unik0rnMaggie I'm adding Hester in CC to keep her in the loop since she will be doing the per-dapp-selected-network weekly meeting.

STATUS: bug in confirmation screen, confirmation team notificed
NEXT STEP: get a fix from confirmations team

cc. @hesterbruikman

[EtherWizard33]

About Tanya's loom in the description, I added comments directly in the loom's timeline, thanks for recording this, its good clarity :)

STATUS: bug in confirmation screen, confirmation team notificed
NEXT STEP: get a fix from confirmations team

cc. @hesterbruikman

[sleepytanya]

Uniswap network switch - the behavior is slightly different, I can't get to Confirmation here:

https://www.loom.com/share/de86ebcd5bd44596b44e21e8ff6f6281

[Unik0rnMaggie]

The error on Ethereum Mainnet only happens when STX is ON. Similar to this issue #12318

When STX is OFF, the swap is possible, but the confirmation screen indicates the wrong network

STX.off.pancake.ethereum.mainnet.mp4

[Unik0rnMaggie]

Same behavior for Uniswap as described above by @sleepytanya :

Confirmation is triggered only when switching network in the wallet (see ending of below video).

https://www.loom.com/share/a19d9d44916b4409963d8708f7296cb0?sid=c7777e9b-4f87-4bd2-8a0d-52f298c6b737