Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Fix call to package goal for ci.maven 3.1 release #408

Open
cherylking opened this issue Oct 4, 2019 · 0 comments
Open

Fix call to package goal for ci.maven 3.1 release #408

cherylking opened this issue Oct 4, 2019 · 0 comments

Comments

@cherylking
Copy link
Member

With the 3.1 release of ci.maven, you need to specify runnable in the include parameter once again. No need to specify packageType (defaults to jar when runnable is specified) or outputDirectory (defaults to ${project.build.directory}/liberty-alt-output-dir for package goal and install-feature goal). Change the following code in LibertyRuntime.java:

private void createUberJar() throws MojoExecutionException {
        executeMojo(getPlugin(), goal("package"),
                configuration(element(name("isInstall"), "false"), element(name("include"), "minify"),
                        element(name("outputDirectory"), "target/liberty-alt-output-dir"),
                        element(name("packageType"), "jar"), element(name("serverName"), serverName)),
                env);
    }

to

private void createUberJar() throws MojoExecutionException {
        executeMojo(getPlugin(), goal("package"),
                configuration(element(name("isInstall"), "false"), element(name("include"), "minify,runnable"), element(name("serverName"), serverName)),
                env);
    }
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant