Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change recursive functions to while loops #57

Open
bannanc opened this issue Nov 26, 2018 · 1 comment
Open

Change recursive functions to while loops #57

bannanc opened this issue Nov 26, 2018 · 1 comment
Labels
long term Caitlin did not have time to address question Needs to be explored further

Comments

@bannanc
Copy link
Member

bannanc commented Nov 26, 2018

Currently, adding "layers" or non-indexed atoms is done with a recursive method in the fragment_graphs and cluster_graphs. This is also true for making SMIRKS patterns for both new graphs here and ChemicalEnvironments. I tend to think that while loops are better (slightly less dangerous) than recursive methods. It would be nice to try to write these functions as loops instead of recursively.

@bannanc bannanc added enhancement New feature or request minor Small issue or not urgent and removed enhancement New feature or request labels Nov 26, 2018
@bannanc bannanc added question Needs to be explored further and removed minor Small issue or not urgent labels Apr 23, 2019
@bannanc
Copy link
Member Author

bannanc commented Jul 2, 2019

I have gotten mixed feedback from people about if while loops are actually preferable to recursive functions, but it is something for the person taking over this project to decide how they feel about it.

@bannanc bannanc added the long term Caitlin did not have time to address label Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long term Caitlin did not have time to address question Needs to be explored further
Projects
None yet
Development

No branches or pull requests

1 participant