Improve transition source and target exist error msg, make msg accessible

Author: schmalzing

src/main/java/de/monticore/scbasis/_cocos/TransitionSourceTargetExists.java

@@ -4,25 +4,34 @@
 import de.monticore.scbasis._ast.ASTSCTransition;
 import de.se_rwth.commons.logging.Log;
 
-public class TransitionSourceTargetExists implements SCBasisASTSCTransitionCoCo{
-  
-  public static final String SOURCE_ERROR_CODE = "0xCC103";
-  public static final String TARGET_ERROR_CODE = "0xCC104";
-  
+public class TransitionSourceTargetExists implements SCBasisASTSCTransitionCoCo {
+
+  public static final String CANT_FIND_SOURCE_ERROR_CODE = "0xCC103";
+  public static final String CANT_FIND_TARGET_ERROR_CODE = "0xCC104";
+
+  public static final String CANT_FIND_SOURCE_ERROR_MSG = "Cannot resolve source state '%s'.";
+  public static final String CANT_FIND_TARGET_ERROR_MSG = "Cannot resolve target state '%s'.";
+
+  @Deprecated
+  public static final String SOURCE_ERROR_CODE = CANT_FIND_SOURCE_ERROR_CODE;
+  @Deprecated
+  public static final String TARGET_ERROR_CODE = CANT_FIND_TARGET_ERROR_CODE;
+
   @Override
   public void check(ASTSCTransition node) {
-  
+
     if (!node.isPresentSourceNameSymbol()) {
-      Log.error(
-          SOURCE_ERROR_CODE + " Source state of the transition is missing.",
-          node.get_SourcePositionStart());
+      Log.error(CANT_FIND_SOURCE_ERROR_CODE + " " + String.format(CANT_FIND_SOURCE_ERROR_MSG, node.getSourceName()),
+        node.get_SourcePositionStart(),
+        node.get_SourcePositionStart()
+      );
     }
-  
+
     if (!node.isPresentTargetNameSymbol()) {
-      Log.error(
-          TARGET_ERROR_CODE + " Target state of the transition is missing.",
-          node.get_SourcePositionStart());
+      Log.error(CANT_FIND_TARGET_ERROR_CODE + " " + String.format(CANT_FIND_TARGET_ERROR_MSG, node.getSourceName()),
+        node.get_SourcePositionStart(),
+        node.get_SourcePositionEnd()
+      );
     }
   }
-  
 }

src/test/java/de/monticore/cocos/TransitionSourceTargetTest.java

@@ -28,8 +28,12 @@ public void testCoCOInvalid() throws IOException {
     assertTrue(ast.isPresent(), "InvalidSourceTarget.sc could not be parsed");
     check(ast.get());
     assertEquals(2, Log.getErrorCount());
-    assertTrue(Log.getFindings().stream().anyMatch(n -> n.getMsg().contains(TransitionSourceTargetExists.SOURCE_ERROR_CODE)));
-    assertTrue(Log.getFindings().stream().anyMatch(n -> n.getMsg().contains(TransitionSourceTargetExists.TARGET_ERROR_CODE)));
+    assertTrue(Log.getFindings().stream().anyMatch(n -> n.getMsg()
+      .contains(TransitionSourceTargetExists.CANT_FIND_SOURCE_ERROR_CODE))
+    );
+    assertTrue(Log.getFindings().stream().anyMatch(n -> n.getMsg()
+      .contains(TransitionSourceTargetExists.CANT_FIND_TARGET_ERROR_CODE))
+    );
 
   }