Transfer event not returned in getEvents

[dafky2000]

evm: v0.2.0
node: v11.14.0

There is a Transfer event defined on this contract but not return by the getEvents method of EVM
https://etherscan.io/address/0x5d00d312e171be5342067c09bae883f9bcb2003b#code
event Transfer(address indexed _from, address indexed _to, uint256 indexed _tokenId)

Reproduce:

const code = await web3.eth.getCode('0x5d00d312e171be5342067c09bae883f9bcb2003b');                                        
const evm = new EVM(code);                                
const events = evm.getEvents();
console.log(events);

Expected:

[ 'Transfer(address,address,uint256)', 'Approval(address,address,uint256)', 'ApprovalForAll(address,address,bool)' ]

Actual:

[ 'Approval(address,address,uint256)', 'ApprovalForAll(address,address,bool)' ]

[dafky2000]

Another contract with this issue is the Decentraland MANA contract at 0x0f5d2fb29fb7d3cfee444a200298f468908cc942. After some more research, this looks like a bug in solidity. Where the contract bytecode should end (JUMP-STOP, followed by the swarm hash), it actually followed by the Transfer event signature and then the swarm hash.

The last bytes are as follows, where ddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef after the JUMP-STOP is the Transfer(address,address,uint256) event signature.

50505600ddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3efa165627a7a72305820f462e7242c33877d5d2f087a81cc0a589147f1cf578ce7fc53451e7ce4fb376f0029
...
POP
POP
JUMP
STOP
'dd'(Unknown Opcode)
CALLCODE
MSTORE
'ad'(Unknown Opcode)
'1b'(Unknown Opcode)
'e2'(Unknown Opcode)
'c8'(Unknown Opcode)
SWAP12
PUSH10 0xc2b068fc378daa952ba7
CALL
PUSH4 0xc4a11628
CREATE2
GAS
'4d'(Unknown Opcode)
CREATE2
'23'(Unknown Opcode)
'b3'(Unknown Opcode)
'ef'(Unknown Opcode)

Of course, this is also not recognized by @j4ys0n's new getABI function contributed in #2

[dafky2000]

With regards to the issues with EVM.parse or EVM.getABI (from @j4ys0n's repo)

It seems that the culprit starts with the CODECOPY function

evm/src/opcodes/codecopy.ts

Lines 19 to 29 in 2f64a4c

	toString() {
	return (
	'this.code[' +
	stringify(this.startLocation) +
	':(' +
	stringify(this.startLocation) +
	'+' +
	stringify(this.copyLength) +
	')]'
	);
	}

where this.code[##:##] is not parsed in the LOG function

evm/src/opcodes/log.ts

Line 57 in 2f64a4c

const eventTopic = topics[0].toString(16);

I've added another "hack-fix" for this in my local dev...

        let eventTopic = topics[0].toString(16);

        // A hack?
        if(eventTopic && eventTopic.startsWith('this.code')) {
          const regex = /this\.code\[(?<start>[0-9a-f]+):\((?<offset>[0-9a-f]+)\+(?<size>[0-9a-f]+)\)\]/;

          let { start, offset, size } = eventTopic.match(regex).groups;
          start = parseInt(start, 16);
          offset = parseInt(offset, 16);
          size = parseInt(size, 16);

          eventTopic = state.code.slice(start, offset + size).toString('hex');
        }