Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Hyvä Checkout 1.1.29 #30

Open
hostep opened this issue Feb 25, 2025 · 2 comments
Open

Incompatible with Hyvä Checkout 1.1.29 #30

hostep opened this issue Feb 25, 2025 · 2 comments

Comments

@hostep
Copy link

hostep commented Feb 25, 2025

After upgrading Hyvä Checkout from 1.1.28 to 1.1.29, running bin/magento setup:di:compile now gives this error:

Interception cache generation... 6/9 [==================>---------]  66% 58 secs 286.0 MiBErrors during compilation:
	MultiSafepay\HyvaCheckout\Payment\MethodListExtended
		Missed required argument experimentalHyvaCheckoutConfig in parent::__construct call. File: vendor/multisafepay/magento2-hyva-checkout/Payment/MethodListExtended.php
Total Errors Count: 1

I don't have time at the moment to further investigate, sorry!

@vinodsowdagar
Copy link
Member

Hi @hostep ,

When extending the MethodList class to override the default selected payment method, we were not accounting for the new constructor arguments that are now there. We'll add the change and create a new release soon.

If you have any feedback in the meantime, feel free to add a comment.

@hostep
Copy link
Author

hostep commented Feb 27, 2025

It feels more like a bug in Hyvä Checkout then, that they broke backwards compatibility, but I'm not sure if they have some kind of policy for that?

Do you think it will be easy to fix to keep your module working on older and newer versions of Hyvä Checkout at the same time?

(I haven't looked into the technical details yet, I'm just making some assumptions here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants