Remove use of PHP language features not available in 5.6

Author: JakeQZ

src/Position/Position.php

@@ -26,40 +26,44 @@ trait Position
     /**
      * @return int<1, max>|null
      */
-    public function getLineNumber(): ?int
+    public function getLineNumber()
     {
         return $this->lineNumber;
     }
 
     /**
      * @return int<0, max>
      */
-    public function getLineNo(): int
+    public function getLineNo()
     {
-        return $this->getLineNumber() ?? 0;
+        $lineNumber = $this->getLineNumber();
+
+        return $lineNumber !== null ? $lineNumber : 0;
     }
 
     /**
      * @return int<0, max>|null
      */
-    public function getColumnNumber(): ?int
+    public function getColumnNumber()
     {
         return $this->columnNumber;
     }
 
     /**
      * @return int<0, max>
      */
-    public function getColNo(): int
+    public function getColNo()
     {
-        return $this->getColumnNumber() ?? 0;
+        $columnNumber = $this->getColumnNumber();
+
+        return $columnNumber !== null ? $columnNumber : 0;
     }
 
     /**
      * @param int<0, max>|null $lineNumber
      * @param int<0, max>|null $columnNumber
      */
-    public function setPosition(?int $lineNumber, ?int $columnNumber = null): void
+    public function setPosition($lineNumber, $columnNumber = null)
     {
         // The conditional is for backwards compatibility (backcompat); `0` will not be allowed in future.
         $this->lineNumber = $lineNumber !== 0 ? $lineNumber : null;

src/Position/Positionable.php

@@ -14,32 +14,32 @@ interface Positionable
     /**
      * @return int<1, max>|null
      */
-    public function getLineNumber(): ?int;
+    public function getLineNumber();
 
     /**
      * @deprecated in version 9.0.0, will be removed in v10.0. Use `getLineNumber()` instead.
      *
      * @return int<0, max>
      */
-    public function getLineNo(): int;
+    public function getLineNo();
 
     /**
      * @return int<0, max>|null
      */
-    public function getColumnNumber(): ?int;
+    public function getColumnNumber();
 
     /**
      * @deprecated in version 9.0.0, will be removed in v10.0. Use `getColumnNumber()` instead.
      *
      * @return int<0, max>
      */
-    public function getColNo(): int;
+    public function getColNo();
 
     /**
      * @param int<0, max>|null $lineNumber
      *        Providing zero for this parameter is deprecated in version 9.0.0, and will not be supported from v10.0.
      *        Use `null` instead when no line number is available.
      * @param int<0, max>|null $columnNumber
      */
-    public function setPosition(?int $lineNumber, ?int $columnNumber = null): void;
+    public function setPosition($lineNumber, $columnNumber = null);
 }

tests/Unit/Position/PositionTest.php

@@ -18,31 +18,38 @@ final class PositionTest extends TestCase
      */
     private $subject;
 
-    protected function setUp(): void
+    /**
+     * The method signature of `setUp()` is not compatible with all PHP and PHPUnit versions supported.
+     */
+    protected function doSetUp()
     {
         $this->subject = new ConcretePosition();
     }
 
     /**
      * @test
      */
-    public function getLineNumberInitiallyReturnsNull(): void
+    public function getLineNumberInitiallyReturnsNull()
     {
+        $this->doSetUp();
+
         self::assertNull($this->subject->getLineNumber());
     }
 
     /**
      * @test
      */
-    public function getColumnNumberInitiallyReturnsNull(): void
+    public function getColumnNumberInitiallyReturnsNull()
     {
+        $this->doSetUp();
+
         self::assertNull($this->subject->getColumnNumber());
     }
 
     /**
      * @return array<non-empty-string, array{0: int<1, max>}>
      */
-    public function provideLineNumber(): array
+    public function provideLineNumber()
     {
         return [
             'line 1' => [1],
@@ -57,8 +64,10 @@ public function provideLineNumber(): array
      *
      * @dataProvider provideLineNumber
      */
-    public function setPositionOnVirginSetsLineNumber(int $lineNumber): void
+    public function setPositionOnVirginSetsLineNumber(int $lineNumber)
     {
+        $this->doSetUp();
+
         $this->subject->setPosition($lineNumber);
 
         self::assertSame($lineNumber, $this->subject->getLineNumber());
@@ -71,8 +80,10 @@ public function setPositionOnVirginSetsLineNumber(int $lineNumber): void
      *
      * @dataProvider provideLineNumber
      */
-    public function setPositionSetsNewLineNumber(int $lineNumber): void
+    public function setPositionSetsNewLineNumber(int $lineNumber)
     {
+        $this->doSetUp();
+
         $this->subject->setPosition(99);
 
         $this->subject->setPosition($lineNumber);
@@ -83,8 +94,10 @@ public function setPositionSetsNewLineNumber(int $lineNumber): void
     /**
      * @test
      */
-    public function setPositionWithNullClearsLineNumber(): void
+    public function setPositionWithNullClearsLineNumber()
     {
+        $this->doSetUp();
+
         $this->subject->setPosition(99);
 
         $this->subject->setPosition(null);
@@ -111,8 +124,10 @@ public function provideColumnNumber(): array
      *
      * @dataProvider provideColumnNumber
      */
-    public function setPositionOnVirginSetsColumnNumber(int $columnNumber): void
+    public function setPositionOnVirginSetsColumnNumber(int $columnNumber)
     {
+        $this->doSetUp();
+
         $this->subject->setPosition(1, $columnNumber);
 
         self::assertSame($columnNumber, $this->subject->getColumnNumber());
@@ -123,8 +138,10 @@ public function setPositionOnVirginSetsColumnNumber(int $columnNumber): void
      *
      * @dataProvider provideColumnNumber
      */
-    public function setPositionSetsNewColumnNumber(int $columnNumber): void
+    public function setPositionSetsNewColumnNumber(int $columnNumber)
     {
+        $this->doSetUp();
+
         $this->subject->setPosition(1, 99);
 
         $this->subject->setPosition(2, $columnNumber);
@@ -135,8 +152,10 @@ public function setPositionSetsNewColumnNumber(int $columnNumber): void
     /**
      * @test
      */
-    public function setPositionWithoutColumnNumberClearsColumnNumber(): void
+    public function setPositionWithoutColumnNumberClearsColumnNumber()
     {
+        $this->doSetUp();
+
         $this->subject->setPosition(1, 99);
 
         $this->subject->setPosition(2);
@@ -147,8 +166,10 @@ public function setPositionWithoutColumnNumberClearsColumnNumber(): void
     /**
      * @test
      */
-    public function setPositionWithNullForColumnNumberClearsColumnNumber(): void
+    public function setPositionWithNullForColumnNumberClearsColumnNumber()
     {
+        $this->doSetUp();
+
         $this->subject->setPosition(1, 99);
 
         $this->subject->setPosition(2, null);
@@ -169,8 +190,10 @@ public function provideLineAndColumnNumber(): array
      *
      * @dataProvider provideLineAndColumnNumber
      */
-    public function setPositionOnVirginSetsLineAndColumnNumber(int $lineNumber, int $columnNumber): void
+    public function setPositionOnVirginSetsLineAndColumnNumber(int $lineNumber, int $columnNumber)
     {
+        $this->doSetUp();
+
         $this->subject->setPosition($lineNumber, $columnNumber);
 
         self::assertSame($lineNumber, $this->subject->getLineNumber());
@@ -182,8 +205,10 @@ public function setPositionOnVirginSetsLineAndColumnNumber(int $lineNumber, int
      *
      * @dataProvider provideLineAndColumnNumber
      */
-    public function setPositionSetsNewLineAndColumnNumber(int $lineNumber, int $columnNumber): void
+    public function setPositionSetsNewLineAndColumnNumber(int $lineNumber, int $columnNumber)
     {
+        $this->doSetUp();
+
         $this->subject->setPosition(98, 99);
 
         $this->subject->setPosition($lineNumber, $columnNumber);