Skip to content

Commit b3ebb68

Browse files
committed
remove code duplications
1 parent f2f2679 commit b3ebb68

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

tests/test_obj.py

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -218,21 +218,16 @@ def test_build_obj_with_colour():
218218
obj.add_vertex_colour(Vec3(0.0, 4.0, 0.0), Vec3(0.0, 1.0, 0.0))
219219
obj.add_vertex_colour(Vec3(-2.0, 0.0, 0.0), Vec3(0.0, 0.0, 1.0))
220220

221-
obj.add_uv(Vec3(1.0, 0.0, 0.0))
222-
obj.add_uv(Vec3(0.5, 1.0, 0.0))
223-
obj.add_uv(Vec3(0.004399, 0.008916, 0.0))
221+
uvs = [Vec3(1.0, 0.0, 0.0), Vec3(0.5, 1.0, 0.0), Vec3(0.004399, 0.008916, 0.0)]
222+
for uv in uvs:
223+
obj.add_uv(uv)
224224
obj.add_normal(Vec3(0.0, 0.0, 1.0))
225225
# f 1/1/1 2/2/1 3/3/1
226226
face = Face()
227-
face.vertex.append(0)
228-
face.vertex.append(1)
229-
face.vertex.append(2)
230-
face.uv.append(0)
231-
face.uv.append(1)
232-
face.uv.append(2)
233-
face.normal.append(0)
234-
face.normal.append(0)
235-
face.normal.append(0)
227+
for i in range(3):
228+
face.vertex.append(i)
229+
face.uv.append(i)
230+
face.normal.append(0)
236231
obj.add_face(face)
237232
obj.save("tests/tempColourObj.obj")
238233
# reload and check

0 commit comments

Comments
 (0)