adding more test coverage and excluding some pass statments

Author: jmacey

run_coverage_nogpu.py

@@ -67,7 +67,6 @@ def main():
         "tests/test_base_mesh.py",
         "tests/test_primitives.py",
         "tests/test_obj.py",
-        "tests/test_webgpu_widget.py",
     ]
 
     # Qt widget tests (require pytest-qt)
@@ -79,6 +78,7 @@ def main():
         "tests/test_rgba_colour_widget.py",
         "tests/test_lookat_widget.py",
         "tests/test_transform_widget.py",
+        "tests/test_webgpu_widget.py",
     ]
 
     print("PyNGL Coverage without GPU")

src/ncca/ngl/__init__.py

@@ -2,10 +2,9 @@
 from importlib.metadata import PackageNotFoundError, version
 
 try:
-    __version__ = version("ncca-ngl")
-except PackageNotFoundError:
+    __version__ = version("ncca-ngl")  # pragma: no cover
+except PackageNotFoundError:  # pragma: no cover
     __version__ = "0.0.0"
-
 __author__ = "Jon Macey jmacey@bournemouth.ac.uk"
 __license__ = "MIT"
 

src/ncca/ngl/vector_base.py

@@ -421,7 +421,7 @@ def cross(self, rhs: Self) -> Self | float:
         Returns:
             Union[VectorBase, float]: The cross product (scalar for 2D, vector for 3D/4D).
         """
-        pass
+        pass  # pragma: no cover
 
     @abstractmethod
     def reflect(self, n: Self) -> Self:
@@ -434,7 +434,7 @@ def reflect(self, n: Self) -> Self:
         Returns:
             VectorBase: A new vector that is the result of reflecting this vector about the normal.
         """
-        pass
+        pass  # pragma: no cover
 
     @abstractmethod
     def outer(self, rhs: Self) -> Any:
@@ -447,7 +447,7 @@ def outer(self, rhs: Self) -> Any:
         Returns:
             Any: A matrix that is the result of the outer product.
         """
-        pass
+        pass  # pragma: no cover
 
     @abstractmethod
     def __matmul__(self, rhs: Any) -> Self:
@@ -460,7 +460,7 @@ def __matmul__(self, rhs: Any) -> Self:
         Returns:
             VectorBase: A new vector that is the result of multiplying this vector by the matrix.
         """
-        pass
+        pass  # pragma: no cover
 
     @abstractmethod
     def set(self, *args: float) -> None:
@@ -473,17 +473,17 @@ def set(self, *args: float) -> None:
         Raises:
             ValueError: If wrong number of arguments is provided or they are not floats.
         """
-        pass
+        pass  # pragma: no cover
 
     @abstractmethod
     def __repr__(self) -> str:
         """Object representation for debugging."""
-        pass
+        pass  # pragma: no cover
 
     @abstractmethod
     def __str__(self) -> str:
         """String representation of the vector."""
-        pass
+        pass  # pragma: no cover
 
     def __getattr__(self, name: str):
         """

src/ncca/ngl/webgpu/__init__.py

@@ -1,9 +1,9 @@
 from importlib.metadata import PackageNotFoundError, version
 
 try:
-    __version__ = version("ncca-ngl")
+    __version__ = version("ncca-ngl")  # pragma: no cover
 except PackageNotFoundError:
-    __version__ = "0.0.0"
+    __version__ = "0.0.0"  # pragma: no cover
 
 __author__ = "Jon Macey jmacey@bournemouth.ac.uk"
 __license__ = "MIT"

src/ncca/ngl/widgets/__init__.py

@@ -1,8 +1,8 @@
 from importlib.metadata import PackageNotFoundError, version
 
 try:
-    __version__ = version("ncca-ngl")
-except PackageNotFoundError:
+    __version__ = version("ncca-ngl")  # pragma: no cover
+except PackageNotFoundError:  # pragma: no cover
     __version__ = "0.0.0"
 
 __author__ = "Jon Macey jmacey@bournemouth.ac.uk"

tests/test_rgba_colour_widget.py

@@ -21,9 +21,7 @@ def test_rgb_widget_initial_value(qtbot):
 
 def test_rgba_widget_constructor_initial_value_and_name(qtbot):
     start_val = Vec4(0.5, 0.6, 0.7, 1.0)
-    w = RGBAColourWidget(
-        name="InitName", r=start_val.x, g=start_val.y, b=start_val.z, a=start_val.w
-    )
+    w = RGBAColourWidget(name="InitName", r=start_val.x, g=start_val.y, b=start_val.z, a=start_val.w)
     qtbot.addWidget(w)
 
     assert w.colour() == start_val
@@ -66,6 +64,10 @@ def test_value_signals_for_each_component(qtbot):
         w.b_spinbox.setValue(0.75)
     assert sig_b.args == [pytest.approx(0.75)]
 
+    with qtbot.waitSignal(w.aValueChanged, timeout=1000) as sig_a:
+        w.a_spinbox.setValue(0.75)
+    assert sig_a.args == [pytest.approx(0.75)]
+
 
 def test_set_colour_blocks_channel_signals_but_emits_colour_changed(qtbot):
     w = RGBAColourWidget()

tests/test_vec3.py

@@ -1,10 +1,11 @@
 import copy
 import ctypes
+from typing import cast
 
 import numpy as np
 import pytest
 
-from ncca.ngl import Mat3, Vec3
+from ncca.ngl import Mat3, Vec3, Vec2, Vec4
 
 
 def test_properties():
@@ -345,3 +346,44 @@ def test_to_metods():
     a = Vec3(1, 2, 3)
     assert a.to_list() == [1, 2, 3]
     assert np.array_equal(a.to_numpy(), np.array([1, 2, 3]))
+    assert a.to_tuple() == (1, 2, 3)
+
+
+def test_unknown_component_kwarg():
+    with pytest.raises(ValueError, match="Unknown component name"):
+        Vec3(invalid_component=1.0)
+
+
+def test_add_incompatible_type():
+    a = Vec3(1, 2, 3)
+    b = cast(Vec3, Vec2(1, 2))
+    with pytest.raises(ValueError, match="Can only add Vec3 to Vec3"):
+        _ = a + b
+
+
+def test_iadd_incompatible_type():
+    a = Vec3(1, 2, 3)
+    b = cast(Vec3, Vec2(1, 2))
+    with pytest.raises(ValueError, match="Can only add Vec3 to Vec3"):
+        a += b
+
+
+def test_sub_incompatible_type():
+    a = Vec3(1, 2, 3)
+    b = cast(Vec3, Vec2(1, 2))
+    with pytest.raises(ValueError, match="Can only subtract Vec3 from Vec3"):
+        _ = a - b
+
+
+def test_isub_incompatible_type():
+    a = Vec3(1, 2, 3)
+    b = cast(Vec3, Vec2(1, 2))
+    with pytest.raises(ValueError, match="Can only subtract Vec3 from Vec3"):
+        a -= b
+
+
+def test_dot_incompatible_type():
+    a = Vec3(1, 2, 3)
+    b = cast(Vec3, Vec2(1, 2))
+    with pytest.raises(ValueError, match="Can only compute dot product with Vec3"):
+        _ = a.dot(b)