Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-factor ObjectStore module to better use reflection #12

Open
jeanetteclark opened this issue Jul 5, 2024 · 0 comments
Open

re-factor ObjectStore module to better use reflection #12

jeanetteclark opened this issue Jul 5, 2024 · 0 comments

Comments

@jeanetteclark
Copy link
Contributor

Currently, if we were to add another object store to the ObjectStore interface we would have to change code in the StoreManager class. This isn't ideal, but it is okay for now while we only have one implementation of the abstract ObjectStore. In the future, we might want to rewrite the StoreManager __init__ to include something like the below:

import importlib
module = importlib.import_module(module_name)
class_ = getattr(module, class_name)
instance = class_()

Where the module_name and class_name are passed via configuration. This would allow us to add new implementations more easily.

@jeanetteclark jeanetteclark moved this to Ready in Metadig Oct 2, 2024
@jeanetteclark jeanetteclark moved this from Ready to Backlog in Metadig Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant