Cleanup code formatting and lint (#6)

* partial cleanup changes

* Cleanup lint

* Fix build error

* Cleanup warnings

* Remove unused code

* Improve code style rules

* Remove deleted file reference

* Cleanup class

Author: JoeBiellik

.editorconfig

@@ -8,7 +8,54 @@ end_of_line = crlf
 insert_final_newline = true
 trim_trailing_whitespace = true
 
-[*.{csproj,config,nuspec,md,yml}]
+csharp_new_line_before_members_in_anonymous_types = false
+csharp_new_line_before_members_in_object_initializers = false
+csharp_preferred_modifier_order = public, private, protected, internal, new, abstract, virtual, sealed, override, static, readonly, extern, unsafe, volatile, async:suggestion
+csharp_space_after_cast = false
+csharp_style_var_elsewhere = true:hint
+csharp_style_var_for_built_in_types = true:hint
+csharp_style_var_when_type_is_apparent = true:hint
+
+dotnet_style_predefined_type_for_locals_parameters_members = true:hint
+dotnet_style_predefined_type_for_member_access = true:hint
+dotnet_style_qualification_for_event = true:hint
+dotnet_style_qualification_for_field = true:hint
+dotnet_style_qualification_for_method = false:hint
+dotnet_style_qualification_for_property = true:hint
+dotnet_style_require_accessibility_modifiers = for_non_interface_members:hint
+
+resharper_blank_line_after_pi = false
+resharper_blank_lines_after_multiline_statements = 1
+resharper_braces_for_ifelse = required_for_multiline_statement
+resharper_braces_for_while = required_for_multiline
+resharper_csharp_empty_block_style = together_same_line
+resharper_csharp_insert_final_newline = true
+resharper_csharp_wrap_lines = false
+resharper_html_normalize_tag_names = true
+resharper_keep_existing_declaration_parens_arrangement = false
+resharper_keep_existing_embedded_arrangement = false
+resharper_keep_existing_expr_member_arrangement = false
+resharper_keep_existing_initializer_arrangement = false
+resharper_keep_existing_linebreaks = false
+resharper_keep_existing_switch_expression_arrangement = false
+resharper_local_function_body = expression_body
+resharper_max_enum_members_on_line = 1
+resharper_method_or_operator_body = expression_body
+resharper_no_indent_inside_elements =
+resharper_normalize_tag_names = true
+resharper_place_accessorholder_attribute_on_same_line = false
+resharper_place_expr_accessor_on_single_line = true
+resharper_place_expr_method_on_single_line = true
+resharper_place_expr_property_on_single_line = true
+resharper_place_field_attribute_on_same_line = false
+resharper_place_simple_embedded_statement_on_same_line = true
+resharper_space_after_cast = false
+resharper_space_within_single_line_array_initializer_braces = true
+resharper_wrap_array_initializer_style = chop_always
+resharper_wrap_object_and_collection_initializer_style = chop_always
+resharper_xmldoc_indent_text = zero_indent
+
+[*.{csproj,config,nuspec,md,yml,lock}]
 indent_style = space
 indent_size = 2
 

Commands/ICommandManager.cs

@@ -1,6 +1,6 @@
-using JetBrains.Annotations;
 using System;
 using System.Collections.Generic;
+using JetBrains.Annotations;
 
 namespace NFive.SDK.Client.Commands
 {

Communications/ICommunicationManager.cs

@@ -1,5 +1,8 @@
+using JetBrains.Annotations;
+
 namespace NFive.SDK.Client.Communications
 {
+	[PublicAPI]
 	public interface ICommunicationManager
 	{
 		ICommunicationTarget Event(string @event);

Events/ICommunicationMessage.cs Communications/ICommunicationMessage.cs

@@ -1,5 +1,8 @@
-namespace NFive.SDK.Client.Events
+using JetBrains.Annotations;
+
+namespace NFive.SDK.Client.Communications
 {
+	[PublicAPI]
 	public interface ICommunicationMessage
 	{
 		/// <summary>

Communications/ICommunicationReceive.cs

@@ -1,34 +1,111 @@
 using System;
 using JetBrains.Annotations;
-using NFive.SDK.Client.Events;
 
 namespace NFive.SDK.Client.Communications
 {
 	[PublicAPI]
 	public interface ICommunicationReceive
 	{
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <param name="callback">The callback.</param>
 		void On(Action<ICommunicationMessage> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T">The type of the first callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void On<T>(Action<ICommunicationMessage, T> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T1">The type of the first callback parameter.</typeparam>
+		/// <typeparam name="T2">The type of the second callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void On<T1, T2>(Action<ICommunicationMessage, T1, T2> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T1">The type of the first callback parameter.</typeparam>
+		/// <typeparam name="T2">The type of the second callback parameter.</typeparam>
+		/// <typeparam name="T3">The type of the third callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void On<T1, T2, T3>(Action<ICommunicationMessage, T1, T2, T3> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T1">The type of the first callback parameter.</typeparam>
+		/// <typeparam name="T2">The type of the second callback parameter.</typeparam>
+		/// <typeparam name="T3">The type of the third callback parameter.</typeparam>
+		/// <typeparam name="T4">The type of the fourth callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void On<T1, T2, T3, T4>(Action<ICommunicationMessage, T1, T2, T3, T4> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T1">The type of the first callback parameter.</typeparam>
+		/// <typeparam name="T2">The type of the second callback parameter.</typeparam>
+		/// <typeparam name="T3">The type of the third callback parameter.</typeparam>
+		/// <typeparam name="T4">The type of the fourth callback parameter.</typeparam>
+		/// <typeparam name="T5">The type of the fifth callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void On<T1, T2, T3, T4, T5>(Action<ICommunicationMessage, T1, T2, T3, T4, T5> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <param name="callback">The callback.</param>
 		void OnRequest(Action<ICommunicationMessage> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T">The type of the first callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void OnRequest<T>(Action<ICommunicationMessage, T> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T1">The type of the first callback parameter.</typeparam>
+		/// <typeparam name="T2">The type of the second callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void OnRequest<T1, T2>(Action<ICommunicationMessage, T1, T2> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T1">The type of the first callback parameter.</typeparam>
+		/// <typeparam name="T2">The type of the second callback parameter.</typeparam>
+		/// <typeparam name="T3">The type of the third callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void OnRequest<T1, T2, T3>(Action<ICommunicationMessage, T1, T2, T3> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T1">The type of the first callback parameter.</typeparam>
+		/// <typeparam name="T2">The type of the second callback parameter.</typeparam>
+		/// <typeparam name="T3">The type of the third callback parameter.</typeparam>
+		/// <typeparam name="T4">The type of the fourth callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void OnRequest<T1, T2, T3, T4>(Action<ICommunicationMessage, T1, T2, T3, T4> callback);
 
+		/// <summary>
+		/// Registers the specified callback.
+		/// </summary>
+		/// <typeparam name="T1">The type of the first callback parameter.</typeparam>
+		/// <typeparam name="T2">The type of the second callback parameter.</typeparam>
+		/// <typeparam name="T3">The type of the third callback parameter.</typeparam>
+		/// <typeparam name="T4">The type of the fourth callback parameter.</typeparam>
+		/// <typeparam name="T5">The type of the fifth callback parameter.</typeparam>
+		/// <param name="callback">The callback.</param>
 		void OnRequest<T1, T2, T3, T4, T5>(Action<ICommunicationMessage, T1, T2, T3, T4, T5> callback);
 	}
 }

Communications/ICommunicationReceiveClient.cs

@@ -1,7 +1,4 @@
 namespace NFive.SDK.Client.Communications
 {
-	public interface ICommunicationReceiveClient : ICommunicationReceive
-	{
-		
-	}
+	public interface ICommunicationReceiveClient : ICommunicationReceive { }
 }

Communications/ICommunicationReceiveServer.cs

@@ -1,7 +1,4 @@
 namespace NFive.SDK.Client.Communications
 {
-	public interface ICommunicationReceiveServer : ICommunicationReceive
-	{
-		
-	}
+	public interface ICommunicationReceiveServer : ICommunicationReceive { }
 }

Communications/ICommunicationTarget.cs

@@ -1,14 +1,32 @@
-using NFive.SDK.Client.Events;
+using JetBrains.Annotations;
 
 namespace NFive.SDK.Client.Communications
 {
+	[PublicAPI]
 	public interface ICommunicationTarget
 	{
-		IEventManager EventManager { get; }
-		string Event { get; }
+		/// <summary>
+		/// Returns a communication adapter for transmitting, targeting the local client.
+		/// </summary>
+		/// <returns>A local client targeted communication adapter for transmitting.</returns>
 		ICommunicationTransmitClient ToClient();
+
+		/// <summary>
+		/// Returns a communication adapter for receiving, targeting the local client.
+		/// </summary>
+		/// <returns>A local client targeted communication adapter for receiving.</returns>
 		ICommunicationReceiveClient FromClient();
+
+		/// <summary>
+		/// Returns a communication adapter adapter for transmitting to the server.
+		/// </summary>
+		/// <returns>A server targeted communication adapter for transmitting.</returns>
 		ICommunicationTransmitServer ToServer();
+
+		/// <summary>
+		/// Returns a communication adapter for receiving from the server.
+		/// </summary>
+		/// <returns>A server targeted communication adapter for receiving.</returns>
 		ICommunicationReceiveServer FromServer();
 	}
 }

Communications/ICommunicationTransmit.cs

@@ -7,17 +7,60 @@ namespace NFive.SDK.Client.Communications
 	[PublicAPI]
 	public interface ICommunicationTransmit
 	{
+		/// <summary>
+		/// Emits the specified payloads.
+		/// </summary>
+		/// <param name="payloads">The payloads.</param>
 		void Emit(params object[] payloads);
 
-		Task<T1> Request<T1>(params object[] payloads);
+		/// <summary>
+		/// Requests the specified type with the specified parameters.
+		/// </summary>
+		/// <typeparam name="TReturn">The type of the return.</typeparam>
+		/// <param name="payloads">The payloads.</param>
+		/// <returns></returns>
+		Task<TReturn> Request<TReturn>(params object[] payloads);
 
-		Task<Tuple<T1, T2>> Request<T1, T2>(params object[] payloads);
+		/// <summary>
+		/// Requests the specified types with the specified parameters.
+		/// </summary>
+		/// <typeparam name="TReturn1">The type of the return1.</typeparam>
+		/// <typeparam name="TReturn2">The type of the return2.</typeparam>
+		/// <param name="payloads">The payloads.</param>
+		/// <returns>The requested types.</returns>
+		Task<Tuple<TReturn1, TReturn2>> Request<TReturn1, TReturn2>(params object[] payloads);
 
-		Task<Tuple<T1, T2, T3>> Request<T1, T2, T3>(params object[] payloads);
+		/// <summary>
+		/// Requests the specified types with the specified parameters.
+		/// </summary>
+		/// <typeparam name="TReturn1">The type of the 1.</typeparam>
+		/// <typeparam name="TReturn2">The type of the 2.</typeparam>
+		/// <typeparam name="TReturn3">The type of the 3.</typeparam>
+		/// <param name="payloads">The payloads.</param>
+		/// <returns>The requested types.</returns>
+		Task<Tuple<TReturn1, TReturn2, TReturn3>> Request<TReturn1, TReturn2, TReturn3>(params object[] payloads);
 
-		Task<Tuple<T1, T2, T3, T4>> Request<T1, T2, T3, T4>(params object[] payloads);
-
-		Task<Tuple<T1, T2, T3, T4, T5>> Request<T1, T2, T3, T4, T5>(params object[] payloads);
+		/// <summary>
+		/// Requests the specified types with the specified parameters.
+		/// </summary>
+		/// <typeparam name="TReturn1">The type of the 1.</typeparam>
+		/// <typeparam name="TReturn2">The type of the 2.</typeparam>
+		/// <typeparam name="TReturn3">The type of the 3.</typeparam>
+		/// <typeparam name="TReturn4">The type of the 4.</typeparam>
+		/// <param name="payloads">The payloads.</param>
+		/// <returns>The requested types.</returns>
+		Task<Tuple<TReturn1, TReturn2, TReturn3, TReturn4>> Request<TReturn1, TReturn2, TReturn3, TReturn4>(params object[] payloads);
 
+		/// <summary>
+		/// Requests the specified types with the specified parameters.
+		/// </summary>
+		/// <typeparam name="TReturn1">The type of the 1.</typeparam>
+		/// <typeparam name="TReturn2">The type of the 2.</typeparam>
+		/// <typeparam name="TReturn3">The type of the 3.</typeparam>
+		/// <typeparam name="TReturn4">The type of the 4.</typeparam>
+		/// <typeparam name="TReturn5">The type of the 5.</typeparam>
+		/// <param name="payloads">The payloads.</param>
+		/// <returns>The requested types.</returns>
+		Task<Tuple<TReturn1, TReturn2, TReturn3, TReturn4, TReturn5>> Request<TReturn1, TReturn2, TReturn3, TReturn4, TReturn5>(params object[] payloads);
 	}
 }

Communications/ICommunicationTransmitClient.cs

@@ -1,7 +1,4 @@
 namespace NFive.SDK.Client.Communications
 {
-	public interface ICommunicationTransmitClient : ICommunicationTransmit
-	{
-		
-	}
+	public interface ICommunicationTransmitClient : ICommunicationTransmit { }
 }

Communications/ICommunicationTransmitServer.cs

@@ -1,7 +1,4 @@
 namespace NFive.SDK.Client.Communications
 {
-	public interface ICommunicationTransmitServer : ICommunicationTransmit
-	{
-		
-	}
+	public interface ICommunicationTransmitServer : ICommunicationTransmit { }
 }

Events/IEventManager.cs

@@ -1,6 +1,6 @@
-using JetBrains.Annotations;
 using System;
 using System.Threading.Tasks;
+using JetBrains.Annotations;
 
 namespace NFive.SDK.Client.Events
 {