Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include krill-sync in krill (as an option) #1093

Open
timbru opened this issue Jul 7, 2023 · 0 comments
Open

Include krill-sync in krill (as an option) #1093

timbru opened this issue Jul 7, 2023 · 0 comments

Comments

@timbru
Copy link
Contributor

timbru commented Jul 7, 2023

It would be good to use krill-sync as a library in Krill's publication server. There is currently some code duplication going on, and krill-sync has a much better implementation of best practices regarding RRDP and (more so) rsync file handling. See: https://datatracker.ietf.org/doc/draft-timbru-sidrops-publication-server-bcp/

Furthermore, it would allow for better end-to-end tests in Krill that leverage krill-sync validation. E.g. we can then make a test that sets up ROAs, does a key rollover, or whatever, and verify that the expected ROA VRPs are reported as valid.

It may be an idea then that Krill itself no longer serves the /rrdp path. The Krill publication server could just keep its current state in memory (it already does) and push this to krill-sync as a lib, rather than krill-sync fetching where Krill published. This could make the code quite a bit cleaner in terms of seperation of concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

1 participant