Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login ajax request taking forever / timeout #1177

Open
straussmarkus opened this issue Dec 18, 2023 · 7 comments
Open

Login ajax request taking forever / timeout #1177

straussmarkus opened this issue Dec 18, 2023 · 7 comments

Comments

@straussmarkus
Copy link

Hi,

after upgrading to 0.14.4 on Debian 12, i have a weird issue, where logging in (config auth) takes forever (load indicator at top of page spinning)

In dev tools i can see that it waits for an ajax request to:
https://myurl.com/api/v1/cas/MY-CA/routes/analysis/full

Which never retourns and then eventually my reverse proxy times out for this request.

Is there anything i can do about that?

@timbru
Copy link
Contributor

timbru commented Dec 18, 2023

Is this still blocking?

It looks like it might have been stuck waiting for the BGP Ris files to be downloaded. @ximon18 I think the write lock in this code should be moved until after the download happens:

let mut seen = self.seen.write().await;

@straussmarkus
Copy link
Author

I still have that problem. Restarting the krill instance may solve it sometimes. But on next login it happens again

@timbru
Copy link
Contributor

timbru commented Dec 20, 2023

Do you have a large amount of ROAs configured, or do you have many announcements for the space on your certificate? I am wondering why you see this issue and others do not.

If it's the downloading BGP RIS dumps that is causing this, then you could try disabling the BGP preview functionality in your config file by setting bgp_risdumps_enabled = false. You would no longer have ROA suggestions. I.e. you only see your actual configurations and no information about announcements.

If this improves things for you then we are one step closer to knowing the cause.

@straussmarkus
Copy link
Author

straussmarkus commented Dec 20, 2023 via email

@timbru
Copy link
Contributor

timbru commented Dec 21, 2023

Please let us know if the issue re-occurs.

The behaviour you saw is consistent with the locking issue I mentioned earlier. I will leave a PR with a fix for this, but releasing this will have to wait until after the holiday season at least.

@straussmarkus
Copy link
Author

It did not re-occur till now :)

@ximon18
Copy link
Member

ximon18 commented Jan 3, 2024

Thanks @straussmarkus.

I'll leave this open until the PR created by @timbru has been reviewed and incorporated into a new release of Krill.

partim pushed a commit that referenced this issue Jun 12, 2024
This PR does not lock the 'seen' announcements while downloading new RIR dump
files. This prevented read access to the announcement during download. This
change postpones getting the write lock until after the download is
completed, so it only keeps it for the shortest possible time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants