Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be easy (or not) to test for an issue like #131 #169

Open
cpaelzer opened this issue Apr 7, 2022 · 1 comment
Open

Would it be easy (or not) to test for an issue like #131 #169

cpaelzer opened this issue Apr 7, 2022 · 1 comment

Comments

@cpaelzer
Copy link

cpaelzer commented Apr 7, 2022

Hi,
in Ubuntu I spotted an issue when testing dns-root-data which ended up being an issue in ldns that wasn't spotted for quite some time. I found that you knew about it #131 and had fixed it in 4d2057f already.
My analysis and driving the fix into Ubuntu is on bug 1966237.

So fixed upstream fixed in Ubuntu - all good right?
But a coworker rightfully asked if there could be a test for this kind of behavior to prevent similar issues in the future.
And I think this would be best in the upstream build time tests as that way everyone would benefit.

One could run the test as I used it in the ubuntu bug with the different hash styles and check this against expected results.

I had not much time or I'd have provided a PR right away, but maybe it is already obvious for you like:

  • we never add this kind of tests do not try
  • this is easy, already done here
  • any other response

So while I didn't have the time to write the test I wanted to bring it up for your consideration by filing this issue.

Thanks in advance!

@wtoorop
Copy link
Member

wtoorop commented Apr 12, 2022

Thank you @cpaelzer . I have noticed and have been following (but not too closely) the Ubuntu bug report. We do some basic unit testing which are run with github actions on each commit (thanks again @FGasper ), see: https://github.com/NLnetLabs/ldns/blob/develop/.github/workflows/testsuite.yml

Some of those tests are online tests though. Maybe it would be worthwhile to identify which tests can be run offline and have a special Makefile target for them. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants