You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
in Ubuntu I spotted an issue when testing dns-root-data which ended up being an issue in ldns that wasn't spotted for quite some time. I found that you knew about it #131 and had fixed it in 4d2057f already.
My analysis and driving the fix into Ubuntu is on bug 1966237.
So fixed upstream fixed in Ubuntu - all good right?
But a coworker rightfully asked if there could be a test for this kind of behavior to prevent similar issues in the future.
And I think this would be best in the upstream build time tests as that way everyone would benefit.
One could run the test as I used it in the ubuntu bug with the different hash styles and check this against expected results.
I had not much time or I'd have provided a PR right away, but maybe it is already obvious for you like:
we never add this kind of tests do not try
this is easy, already done here
any other response
So while I didn't have the time to write the test I wanted to bring it up for your consideration by filing this issue.
Thanks in advance!
The text was updated successfully, but these errors were encountered:
Some of those tests are online tests though. Maybe it would be worthwhile to identify which tests can be run offline and have a special Makefile target for them. WDYT?
Hi,
in Ubuntu I spotted an issue when testing dns-root-data which ended up being an issue in ldns that wasn't spotted for quite some time. I found that you knew about it #131 and had fixed it in 4d2057f already.
My analysis and driving the fix into Ubuntu is on bug 1966237.
So fixed upstream fixed in Ubuntu - all good right?
But a coworker rightfully asked if there could be a test for this kind of behavior to prevent similar issues in the future.
And I think this would be best in the upstream build time tests as that way everyone would benefit.
One could run the test as I used it in the ubuntu bug with the different hash styles and check this against expected results.
I had not much time or I'd have provided a PR right away, but maybe it is already obvious for you like:
So while I didn't have the time to write the test I wanted to bring it up for your consideration by filing this issue.
Thanks in advance!
The text was updated successfully, but these errors were encountered: