[1pt] Incorrect hardcoded file path in post-processing

[mluck]

There is a hardcoded path in fim_post_processing.sh to a file that has been renamed. The incorrect line is

inundation-mapping/fim_post_processing.sh

Line 183 in ae35c8c

-wbd $inputsDir/wbd/WBD_National_EPSG_5070_WBDHU8_clip_dem_domain.gpkg \

This should be updated to use the environment variable input_WBD_gdb

inundation-mapping/src/bash_variables.env

Line 25 in ae35c8c

export input_WBD_gdb=${inputsDir}/wbd/WBD_National_HUC8_EPSG_5070_HAND_domain.gpkg

Search for the phrase "wbd_national" and there are a few handful of places that have the value hardcoded and need to also be changed.

[CarsonPruitt-NOAA]

Does this mean that the bathymetry adjustment has been broken?

[mluck]

No, the bathymetry adjustment should be okay because both the old file and the new file are on EFS, assuming these are the same file (they are the same size).

[mluck]

This is the error that occurs if the old dataset doesn't exist:

Performing Bathymetry Adjustment routine
Writing progress to log file here: /outputs/v4.8.6.2/logs/bathymetric_adjustment.log
This may take a few minutes...
Traceback (most recent call last):
  File "fiona/ogrext.pyx", line 130, in fiona.ogrext.gdal_open_vector
  File "fiona/ogrext.pyx", line 134, in fiona.ogrext.gdal_open_vector
  File "fiona/_err.pyx", line 375, in fiona._err.StackChecker.exc_wrap_pointer
fiona._err.CPLE_OpenFailedError: /data/inputs/wbd/WBD_National_EPSG_5070_WBDHU8_clip_dem_domain.gpkg: No such file or directory

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/foss_fim/src/bathymetric_adjustment.py", line 681, in <module>
    process_bathy_adjustment(
  File "/foss_fim/src/bathymetric_adjustment.py", line 516, in process_bathy_adjustment
    wbd = gpd.read_file(
  File "/usr/local/lib/python3.10/dist-packages/geopandas/io/file.py", line 306, in _read_file
    return _read_file_fiona(
  File "/usr/local/lib/python3.10/dist-packages/geopandas/io/file.py", line 358, in _read_file_fiona
    with reader(path_or_bytes, **kwargs) as features:
  File "/usr/local/lib/python3.10/dist-packages/fiona/env.py", line 457, in wrapper
    return f(*args, **kwds)
  File "/usr/local/lib/python3.10/dist-packages/fiona/__init__.py", line 342, in open
    colxn = Collection(
  File "/usr/local/lib/python3.10/dist-packages/fiona/collection.py", line 226, in __init__
    self.session.start(self, **kwargs)
  File "fiona/ogrext.pyx", line 876, in fiona.ogrext.Session.start
  File "fiona/ogrext.pyx", line 136, in fiona.ogrext.gdal_open_vector
fiona.errors.DriverError: Failed to open dataset (flags=68): /data/inputs/wbd/WBD_National_EPSG_5070_WBDHU8_clip_dem_domain.gpkg

[RobHanna-NOAA]

Strange. That was fixed a while back I thought

[mluck]

I fixed it in #1480 but it hasn't been merged yet. Once it does get merged to dev, maybe the duplicate old file (wbd/WBD_National_EPSG_5070_WBDHU8_clip_dem_domain.gpkg) should be removed from the enviros?

[RobHanna-NOAA]

Ya. I usually leave the old inputs around for a little while in case we go back and want to do a re-test against an old git branch. But, yes, I do eventually clean them up.  For that particular file, I wanted to do a scan through our FIM code to make sure there are no remaining references to it. I know when I added it, there was some code still pointing to it and need to get that finished.

[RobHanna-NOAA]

This has been solved somewhere along the way.