Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowMaterial:Shade eio output write-out CSV format typo #10286

Open
1 of 3 tasks
jcyuan2020 opened this issue Oct 30, 2023 · 3 comments · May be fixed by #10750
Open
1 of 3 tasks

WindowMaterial:Shade eio output write-out CSV format typo #10286

jcyuan2020 opened this issue Oct 30, 2023 · 3 comments · May be fixed by #10750
Assignees
@jcyuan2020
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@jcyuan2020
Copy link
Contributor

jcyuan2020 commented Oct 30, 2023 •
edited
Loading

Issue overview

It was reported by a user that in the EIO report there is a column shift occurred between the header and the actual information:
image

After examining the source code, this was found to be caused by a formatting typo in the source code:

EnergyPlus/src/EnergyPlus/WindowManager.cc

Lines 7405 to 7409 in d07d7ad

static constexpr std::string_view Format_703(" WindowMaterial:Shade,,{},{:.3R},{:.3R},{:.3R},{:.3R},{:.3R},{:.3R}\n");
print(state.files.eio,
Format_703,
thisMaterial->Name,
thisMaterial->Thickness,

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version): All
  • Version of EnergyPlus (if using an intermediate build, include SHA): at least since v9.4, till v23.2
  • Helpdesk Ticket Number: 16512

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@jcyuan2020 jcyuan2020 added the Defect Includes code to repair a defect in EnergyPlus label Oct 30, 2023
@jcyuan2020 jcyuan2020 self-assigned this Oct 30, 2023
jcyuan2020 added a commit to jcyuan2020/EnergyPlus that referenced this issue Oct 30, 2023
@jcyuan2020
Fix Issue NREL#10286 window material shade eio write-out typo.
29cddf6
@shorowit
Copy link
Contributor

@jcyuan2020 Looks like this issue should be closed?

@jcyuan2020
Copy link
Contributor Author

@jcyuan2020 Looks like this issue should be closed?

Actually, I quickly checked and it seems the problematic code typo is still there. I will just post a one-liner fix for this.

@shorowit
Copy link
Contributor

Actually, I quickly checked and it seems the problematic code typo is still there. I will just post a one-liner fix for this.

Oh, sorry. I saw the commit referenced above and assumed it was merged in. Thanks for double-checking.

jcyuan2020 added a commit to jcyuan2020/EnergyPlus that referenced this issue Sep 17, 2024
@jcyuan2020
Fix Issue NREL#10286 window material shade eio write-out typo.
11ebf36
jcyuan2020 added a commit to jcyuan2020/EnergyPlus that referenced this issue Sep 19, 2024
@jcyuan2020
Fix Issue NREL#10286 window material shade eio write-out typo.
bb5747a
@jcyuan2020 jcyuan2020 linked a pull request Sep 19, 2024 that will close this issue
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcyuan2020 jcyuan2020

Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Issue #10286 window material shade mis-alignment for Output:Constructions jcyuan2020/EnergyPlus
2 participants
@shorowit @jcyuan2020