Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff as an automatic linter #50

Open
johnjasa opened this issue Nov 15, 2024 · 1 comment
Open

Add ruff as an automatic linter #50

johnjasa opened this issue Nov 15, 2024 · 1 comment
Assignees
Labels
code cleanup enhancement New feature or request

Comments

@johnjasa
Copy link
Collaborator

Add ruff as an automatic linter

We should add a pre-commit hook for linting GreenHEART to streamline and simplify code coming from disparate sources.

Proposed solution

Ruff is fast, easy-to-setup, and well-accepted.
I'll defer to @RHammond2 about best settings though it should be pretty straightforward.

@johnjasa johnjasa added enhancement New feature or request code cleanup labels Nov 15, 2024
@RHammond2 RHammond2 self-assigned this Nov 18, 2024
@bayc
Copy link
Collaborator

bayc commented Nov 19, 2024

Agreed! We setup pre-commit hooks in the electrolyzer repo (inspired by FLORIS) that we could pull from as well: https://github.com/NREL/electrolyzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants