Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: correctly set battery O&M costs #387

Open
kbrunik opened this issue Oct 25, 2024 · 0 comments
Open

Bug report: correctly set battery O&M costs #387

kbrunik opened this issue Oct 25, 2024 · 0 comments

Comments

@kbrunik
Copy link
Collaborator

kbrunik commented Oct 25, 2024

Correctly setting O&M costs in the Custom Financial Model

O&M costs for the battery are not being set correctly for the custom financial model. @elenya-grant commented out battery specific ways of setting O&M in PR #346. The issue is that doing so cause the SingleOwner module to not work correct. I think we need to make updates to the CustomFinancialModel to make sure it's updating properly rather than deleting these if statements. test_hybrid.py::test_hybrid_om_costs is failing and that means that if we pull in this change that you won't be able to use SingleOwner.

How to reproduce

Relevant output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant