You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the update_hpxmls task, we only apply the HPXML modifications to the final HPXML path. This means that when one HPXML file references another as a parent, the parent's modifications are not applied and we have to explicitly specify that we want to apply the modifications again. This results in code like so:
Even though base-zones-spaces.xml references base-enclosure-garage.xml as the parent, we have to include both of them in the code.
Instead, we can use the parent_hpxml_filenames array to recursively apply the modifications from all the parent HPXMLs too. This would simplify our code and be more expected/intuitive for a developer.
The text was updated successfully, but these errors were encountered:
In the
update_hpxmls
task, we only apply the HPXML modifications to the final HPXML path. This means that when one HPXML file references another as a parent, the parent's modifications are not applied and we have to explicitly specify that we want to apply the modifications again. This results in code like so:OpenStudio-HPXML/tasks.rb
Lines 1451 to 1454 in 9332bad
Even though
base-zones-spaces.xml
referencesbase-enclosure-garage.xml
as the parent, we have to include both of them in the code.Instead, we can use the
parent_hpxml_filenames
array to recursively apply the modifications from all the parent HPXMLs too. This would simplify our code and be more expected/intuitive for a developer.The text was updated successfully, but these errors were encountered: