Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isaac ROS Dev Scripts documentation not matching observed behavior #171

Open
pwmarshall opened this issue Jan 21, 2025 · 1 comment
Open

Comments

@pwmarshall
Copy link

Some of the documentation from this webpage https://nvidia-isaac-ros.github.io/repositories_and_packages/isaac_ros_common/index.html#isaac-ros-dev-scripts does not match what happens on release 3.2.

According to the documentation when calling build_image_layers.sh the image key passed with -i should have the platform key prepended to it however on release 3.2 this is not the observed behavior.

pwmarshall@pwmarshallUbuntu22:~/Lunabotics$ ./src/isaac_ros/isaac_ros_common/scripts/build_image_layers.sh -i ros2_humble

Target image name not specified, using ros2_humble-image
Building layered image for key ros2_humble as ros2_humble-image

I think build_image_layers not prepending platform key is the expected behavior as running run_dev.sh will prepend the platform key before calling build_image_layers.sh. This means that the documentation just need a slight update.

pwmarshall@pwmarshallUbuntu22:~/Lunabotics$ ./src/isaac_ros/isaac_ros_common/scripts/run_dev.sh -i ros2_humble
Launching Isaac ROS Dev container with image key x86_64.ros2_humble: /home/pwmarshall/Lunabotics
Building x86_64.ros2_humble base as image: isaac_ros_dev-x86_64

However run_dev.sh does not append user to the image key like stated in the documentation. This could be do to the fact that release 3.2 just refactored the docker images and removed the user image.

@abhishekvchaudhari
Copy link

Please setup config_image_keys by running following commands

cd ${ISAAC_ROS_WS}/src/isaac_ros_common/scripts &&
touch .isaac_ros_common-config &&
echo CONFIG_IMAGE_KEY=ros2_humble.realsense > .isaac_ros_common-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants