Remove dev build defs for /Zc:preprocessor and /Zc:__cplusplus.

These are no longer needed since the public libcudacxx target now adds them.

Author: alliepiper

cmake/CCCLBuildCompilerTargets.cmake

@@ -153,8 +153,6 @@ function(cccl_build_compiler_targets)
     # See https://github.com/microsoft/STL/issues/696
     append_option_if_available("/wd4494" cxx_compile_options)
 
-    # Require the conforming preprocessor
-    append_option_if_available("/Zc:preprocessor" cxx_compile_options)
     if (MSVC_TOOLSET_VERSION LESS 143)
       # winbase.h(9572): warning C5105: macro expansion producing 'defined' has undefined behavior
       append_option_if_available("/wd5105" cxx_compile_options)

cudax/cmake/cudaxBuildCompilerTargets.cmake

@@ -42,10 +42,6 @@ if ("MSVC" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
   # C4848: support for attribute 'msvc::no_unique_address' in C++17 and earlier is a vendor extension
   append_option_if_available("/wd4848" cxx_compile_options)
 
-  # cudax requires dim3 to be usable from a constexpr context, and the CUDART headers require
-  # __cplusplus to be defined for this to work:
-  append_option_if_available("/Zc:__cplusplus" cxx_compile_options)
-
   # XXX Temporary hack for STF !
   # C4267: conversion from 'meow' to 'purr', possible loss of data
   append_option_if_available("/wd4267" cxx_compile_options)

examples/cudax/CMakeLists.txt

@@ -59,16 +59,6 @@ if ("MSVC" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
   # mdspan on windows only works in C++20 mode
   target_compile_features(cudax_samples_interface INTERFACE cxx_std_20)
 
-  # Require the conforming preprocessor
-  target_compile_options(
-    cudax_samples_interface
-    INTERFACE
-      $<$<COMPILE_LANGUAGE:CXX>:/Zc:__cplusplus>
-      $<$<COMPILE_LANGUAGE:CXX>:/Zc:preprocessor>
-      $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:-Xcompiler=/Zc:__cplusplus>
-      $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:-Xcompiler=/Zc:preprocessor>
-  )
-
   if (MSVC_TOOLSET_VERSION LESS 143)
     # winbase.h(9572): warning C5105: macro expansion producing 'defined' has undefined behavior
     target_compile_options(

libcudacxx/cmake/LibcudacxxBuildCompilerTargets.cmake

@@ -11,12 +11,6 @@ function(libcudacxx_build_compiler_targets)
   set(cxx_compile_options)
   set(cxx_compile_definitions)
 
-  if ("MSVC" STREQUAL "${CMAKE_CXX_COMPILER_ID}")
-    # libcudacxx requires dim3 to be usable from a constexpr context, and the CUDART headers require
-    # __cplusplus to be defined for this to work:
-    append_option_if_available("/Zc:__cplusplus" cxx_compile_options)
-  endif()
-
   #  if (CCCL_USE_LIBCXX)
   #    list(APPEND cxx_compile_options "-stdlib=libc++")
   #    list(APPEND cxx_compile_definitions "_ALLOW_UNSUPPORTED_LIBCPP=1")