Improve CMake package handling, add MSVC compat flags to libcudacxx's public interface. #6791
+351
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
alliepiper
requested review from
gevtushenko,
gonidelis,
pciolkosz and
robertmaynard
When `/Zc:preprocessor` is not set, the build will error out before `#pragma message` directives are handled. Changing to an error ensures that this will be caught.
These are no longer needed since the public libcudacxx target now adds them.
This comment has been minimized.
This comment has been minimized.
alliepiper
force-pushed
the
msvc-preprocessor
branch
from
4a337ff to
67bf397
Compare
Contributor
Author
|
pre-commit.ci autofix |
Contributor
alliepiper
force-pushed
the
msvc-preprocessor
branch
2 times, most recently
from
1f34aa6 to
7906387
Compare
alliepiper
force-pushed
the
msvc-preprocessor
branch
from
7906387 to
75e1996
Compare
alliepiper
changed the title
This comment has been minimized.
This comment has been minimized.
alliepiper
force-pushed
the
msvc-preprocessor
branch
from
307a3e6 to
9e5f6a4
Compare
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
alliepiper
force-pushed
the
msvc-preprocessor
branch
from
656e57c to
1dd2f17
Compare
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
This ensures that it behaves the same as find_package, and that later calls to find_package will locate the same configs.
alliepiper
force-pushed
the
msvc-preprocessor
branch
from
1dd2f17 to
6f8e4fb
Compare
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
alliepiper
changed the title
Contributor
😬 CI Workflow Results🟥 Finished in 47m 33s: Pass: 0%/1 | Total: 47m 33s | Max: 47m 33sSee results here. |
alliepiper
force-pushed
the
msvc-preprocessor
branch
2 times, most recently
from
858aa29 to
7390248
Compare
Contributor
Author
|
/ok to test |
alliepiper
force-pushed
the
msvc-preprocessor
branch
from
7390248 to
d995614
Compare
Contributor
Author
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some edge cases in the internal dependency graphs that were broken by the libcudacxx/thrust/cub interdependency.
Adds
/Zc:preprocessorand/Zc:__cplusplustolibcudacxx::libcudacxx's public interface. Re-check enabled languages / compilers for repeatedfind_packagecalls to CCCL projects, sinceCUDA/CUDA_HOSTcompilers may be unknown during the first pass through the find module.Changes the
/Zc:preprocessorcheck into an#errorrather than a#pragma message. MSVC will encounter preprocessor issues and exit with non-obvious errors before handling the#pragma message, so users were not seeing the message when it was needed.Misc:
cccl_get_<project>helpers forcccl,thrust,cub,libcudacxx,cudaxandCUDAToolkitto reduce noise and keep find_package logic consistent.<Project>_DIRin the CMake cache when including CCCL withadd_subdirectory/CPM. Ensures that future calls tofind_package(CCCL)will resolve to the same config files, but won't override user settings.enable_language(CUDA)usages.ci/test_packaging.shto:HEADcommit of the local repository when run locally.