Enhance crash recipe with configurable stats directory#1466
Enhance crash recipe with configurable stats directory#1466dran-dev wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
cec7407 to
7f6061f
Compare
Greptile SummaryThis PR successfully adds a configurable Key improvements:
Implementation approach: The solution is clean and minimal, with good backward compatibility. Important Files Changed
Last reviewed commit: 7f6061f |
examples/structural_mechanics/crash/conf/datapipe/point_cloud.yaml
Outdated
Show resolved
Hide resolved
|
/blossom-ci |
461515b to
b548ef7
Compare
|
@mnabian @ktangsali PTAL |
|
/blossom-ci |
|
Hi @dran-dev, thanks for the PR. would it make sense to get rid of the hardcoded |
b548ef7 to
f55e194
Compare
Makes sense. Fixed. |
|
/blossom-ci |
mnabian
left a comment
There was a problem hiding this comment.
LGTM. Left a small comment.
f55e194 to
bdd8384
Compare
|
/blossom-ci |
Added support for a configurable stats directory in train.py, inference.py for crash recipe. Signed-off-by: Dileep Ranganathan <8152399+dran-dev@users.noreply.github.com>
Head branch was pushed to by a user without write access
bdd8384 to
c7377a3
Compare
PhysicsNeMo Pull Request
Description
Make the stats directory (
node_stats.json,feature_stats.json,edge_stats.json) configurable via Hydra in the crash simulation recipe.Previously, training wrote normalization statistics to a relative
./stats/path under the Hydra run output directory. During inference, a different Hydra
output directory is used, so the stats files were not found — resulting in:
This PR adds a
datapipe.stats_dirconfiguration option (defaulting tonull, which preserves the existing./stats/behavior) so users canpoint inference to the training run's stats directory:
Changes
stats_dirparameter toCrashBaseDataset.__init__withbackward-compatible default (
Nonefalls back to relativestats/).stats_dir: nulltopoint_cloud.yamlandgraph.yamldatapipe configs.
datapipe.py,train.py, andinference.py.datapipe.stats_diroption.Checklist
Dependencies
None.