diff --git a/idd/Energy+.idd.in b/idd/Energy+.idd.in index ed80e986352..8f9912ae00a 100644 --- a/idd/Energy+.idd.in +++ b/idd/Energy+.idd.in @@ -85606,10 +85606,10 @@ PlantEquipmentOperationSchemes, \memo Only plant equipment should be listed on a Control Scheme for this item. \min-fields 4 A1 , \field Name - \required-field + \required-field \reference PlantOperationSchemes A2 , \field Control Scheme 1 Object Type - \required-field + \required-field \type choice \key PlantEquipmentOperation:CoolingLoad \key PlantEquipmentOperation:HeatingLoad @@ -92227,6 +92227,7 @@ PhotovoltaicPerformance:Simple, \memo which surfaces convert incident solar radiation to electricity and need not specify \memo arrays of specific modules. A1 , \field Name + \required-field \reference PVModules N1 , \field Fraction of Surface Area with Active Solar Cells \required-field @@ -92252,6 +92253,7 @@ PhotovoltaicPerformance:EquivalentOne-Diode, \memo using an equivalent one-diode circuit. This model is also known as \memo the 4- or 5-parameter TRNSYS model for photovoltaics. A1 , \field Name + \required-field \reference PVModules A2 , \field Cell type \type choice @@ -92362,6 +92364,7 @@ PhotovoltaicPerformance:Sandia, \memo Describes performance input data needed for specific makes and models of production \memo PV panels using the empirical coefficients assembled by Sandia National Laboratory. A1 , \field Name + \required-field \reference PVModules N1 , \field Active Area \note (m2, single module) diff --git a/src/EnergyPlus/ExternalInterface.cc b/src/EnergyPlus/ExternalInterface.cc index 32d8864aa96..924faac7a91 100644 --- a/src/EnergyPlus/ExternalInterface.cc +++ b/src/EnergyPlus/ExternalInterface.cc @@ -1230,18 +1230,6 @@ void InitExternalInterfaceFMUImport(EnergyPlusData &state) cCurrentModuleObject, fmuInst.Name, state.dataExternalInterface->ErrorsFound); - // Util::VerifyName( state.dataExternalInterface->FMU( i ).Instance( j - // ).fmuInputVariable( - // k - //).Name, state.dataExternalInterface->FMU( - // i - //).Instance( - // j - //).checkfmuInputVariable, NumFMUInputVariables, IsNotOK, IsBlank, "The FMU input variable \"" + - // state.dataExternalInterface->FMU( i ).Instance( j - //).fmuInputVariable( k ).Name + "\" of instance \"" + state.dataExternalInterface->FMU( i ).Instance( j ).Name + "\" of FMU - //\"" + state.dataExternalInterface->FMU( i ).Name + "\" - // has duplicates. Please check the input file again and delete duplicated entries." ); if (state.dataExternalInterface->ErrorsFound) { StopExternalInterfaceIfError(state); } else { diff --git a/src/EnergyPlus/GeneralRoutines.cc b/src/EnergyPlus/GeneralRoutines.cc index ec9de935948..96b76878676 100644 --- a/src/EnergyPlus/GeneralRoutines.cc +++ b/src/EnergyPlus/GeneralRoutines.cc @@ -196,7 +196,7 @@ void ControlCompOutput(EnergyPlusData &state, if (ControlCompTypeNum != 0) { SimCompNum = ControlCompTypeNum; } else { - SimCompNum = Util::FindItemInSortedList(CompType, ListOfComponents, NumComponents); + SimCompNum = Util::FindItem(CompType, ListOfComponents, NumComponents); ControlCompTypeNum = SimCompNum; } diff --git a/src/EnergyPlus/HVACSingleDuctInduc.cc b/src/EnergyPlus/HVACSingleDuctInduc.cc index 0a1781f4957..cb13266106f 100644 --- a/src/EnergyPlus/HVACSingleDuctInduc.cc +++ b/src/EnergyPlus/HVACSingleDuctInduc.cc @@ -249,7 +249,6 @@ namespace HVACSingleDuctInduc { ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)}; int IUNum = IUIndex; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); state.dataHVACSingleDuctInduc->IndUnit(IUNum).Name = Alphas(1); state.dataHVACSingleDuctInduc->IndUnit(IUNum).UnitType = CurrentModuleObject; diff --git a/src/EnergyPlus/HVACVariableRefrigerantFlow.cc b/src/EnergyPlus/HVACVariableRefrigerantFlow.cc index 1f3b858279e..15b62cd1fb2 100644 --- a/src/EnergyPlus/HVACVariableRefrigerantFlow.cc +++ b/src/EnergyPlus/HVACVariableRefrigerantFlow.cc @@ -1572,7 +1572,6 @@ void GetVRFInputData(EnergyPlusData &state, bool &ErrorsFound) lAlphaFieldBlanks, cAlphaFieldNames, cNumericFieldNames); - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); auto &thisTUList = state.dataHVACVarRefFlow->TerminalUnitList(TUListNum); thisTUList.Name = cAlphaArgs(1); @@ -3347,7 +3346,6 @@ void GetVRFInputData(EnergyPlusData &state, bool &ErrorsFound) state.dataHVACVarRefFlow->VRFTUNumericFields(VRFTUNum).FieldNames.allocate(NumNums); state.dataHVACVarRefFlow->VRFTUNumericFields(VRFTUNum).FieldNames = cNumericFieldNames; - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); auto &thisVrfTU = state.dataHVACVarRefFlow->VRFTU(VRFTUNum); thisVrfTU.Name = cAlphaArgs(1); diff --git a/src/EnergyPlus/HeatBalanceManager.cc b/src/EnergyPlus/HeatBalanceManager.cc index e8660724171..8e96c440d48 100644 --- a/src/EnergyPlus/HeatBalanceManager.cc +++ b/src/EnergyPlus/HeatBalanceManager.cc @@ -1883,10 +1883,6 @@ namespace HeatBalanceManager { TMP = index(state.dataIPShortCut->cAlphaArgs(1), char(2)); } - if (Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataHeatBalMgr->CurrentModuleObject, ErrorsFound)) { - continue; - } - ++ZoneLoop; ProcessZoneData(state, cCurrentModuleObject, diff --git a/src/EnergyPlus/HybridUnitaryAirConditioners.cc b/src/EnergyPlus/HybridUnitaryAirConditioners.cc index f036fd81874..8dc7a706b78 100644 --- a/src/EnergyPlus/HybridUnitaryAirConditioners.cc +++ b/src/EnergyPlus/HybridUnitaryAirConditioners.cc @@ -497,16 +497,6 @@ void GetInputZoneHybridUnitaryAirConditioners(EnergyPlusData &state, bool &Error cAlphaFields, cNumericFields); - bool IsNotOK = false; - bool IsBlank = false; - Util::VerifyName(state, - Alphas(1), - state.dataHybridUnitaryAC->ZoneHybridUnitaryAirConditioner, - UnitLoop - 1, - IsNotOK, - IsBlank, - cCurrentModuleObject + " Name"); - ErrorObjectHeader eoh{routineName, cCurrentModuleObject, Alphas(1)}; auto &hybridUnitaryAC = state.dataHybridUnitaryAC->ZoneHybridUnitaryAirConditioner(UnitLoop); diff --git a/src/EnergyPlus/IceThermalStorage.cc b/src/EnergyPlus/IceThermalStorage.cc index f53427fa8a8..050f92725f0 100644 --- a/src/EnergyPlus/IceThermalStorage.cc +++ b/src/EnergyPlus/IceThermalStorage.cc @@ -738,7 +738,6 @@ namespace IceThermalStorage { _, _, state.dataIPShortCut->cNumericFieldNames); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); state.dataIceThermalStorage->ThermalStorageSizing(sizingNum).name = state.dataIPShortCut->cAlphaArgs(1); state.dataIceThermalStorage->ThermalStorageSizing(sizingNum).onPeakStart = state.dataIPShortCut->rNumericArgs(1); @@ -779,7 +778,6 @@ namespace IceThermalStorage { state.dataIPShortCut->lAlphaFieldBlanks, state.dataIPShortCut->cAlphaFieldNames, state.dataIPShortCut->cNumericFieldNames); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); ++state.dataIceThermalStorage->TotalNumIceStorage; state.dataIceThermalStorage->SimpleIceStorage(iceNum).MapNum = state.dataIceThermalStorage->TotalNumIceStorage; @@ -905,8 +903,6 @@ namespace IceThermalStorage { ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); - ++state.dataIceThermalStorage->TotalNumIceStorage; state.dataIceThermalStorage->DetailedIceStorage(iceNum).MapNum = state.dataIceThermalStorage->TotalNumIceStorage; diff --git a/src/EnergyPlus/IndoorGreen.cc b/src/EnergyPlus/IndoorGreen.cc index e929bbe14f6..97469c6667e 100644 --- a/src/EnergyPlus/IndoorGreen.cc +++ b/src/EnergyPlus/IndoorGreen.cc @@ -137,7 +137,6 @@ namespace IndoorGreen { s_ipsc->cAlphaFieldNames, s_ipsc->cNumericFieldNames); ErrorObjectHeader eoh{RoutineName, cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); ig.Name = s_ipsc->cAlphaArgs(1); ig.SurfName = s_ipsc->cAlphaArgs(2); ig.SurfPtr = Util::FindItemInList(s_ipsc->cAlphaArgs(2), state.dataSurface->Surface); diff --git a/src/EnergyPlus/InternalHeatGains.cc b/src/EnergyPlus/InternalHeatGains.cc index cd3f7f27739..78958d38fe2 100644 --- a/src/EnergyPlus/InternalHeatGains.cc +++ b/src/EnergyPlus/InternalHeatGains.cc @@ -2565,7 +2565,6 @@ namespace InternalHeatGains { IHGNumericFieldNames); ErrorObjectHeader eoh{routineName, contamSSModuleObject, IHGAlphas(1)}; - Util::IsNameEmpty(state, IHGAlphas(1), contamSSModuleObject, ErrorsFound); state.dataHeatBal->ZoneCO2Gen(Loop).Name = IHGAlphas(1); diff --git a/src/EnergyPlus/MatrixDataManager.cc b/src/EnergyPlus/MatrixDataManager.cc index fd35ea6fa0d..7d0cb2c7736 100644 --- a/src/EnergyPlus/MatrixDataManager.cc +++ b/src/EnergyPlus/MatrixDataManager.cc @@ -148,7 +148,6 @@ namespace MatrixDataManager { state.dataIPShortCut->cAlphaFieldNames, state.dataIPShortCut->cNumericFieldNames); ++MatNum; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); state.dataMatrixDataManager->MatData(MatNum).Name = state.dataIPShortCut->cAlphaArgs(1); int NumRows = std::floor(state.dataIPShortCut->rNumericArgs(1)); diff --git a/src/EnergyPlus/MicroturbineElectricGenerator.cc b/src/EnergyPlus/MicroturbineElectricGenerator.cc index f29bf69c847..b80e8afaf1c 100644 --- a/src/EnergyPlus/MicroturbineElectricGenerator.cc +++ b/src/EnergyPlus/MicroturbineElectricGenerator.cc @@ -159,7 +159,7 @@ void GetMTGeneratorInput(EnergyPlusData &state) state.dataIPShortCut->lAlphaFieldBlanks, state.dataIPShortCut->cAlphaFieldNames, state.dataIPShortCut->cNumericFieldNames); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); + state.dataMircoturbElectGen->MTGenerator(GeneratorNum).Name = AlphArray(1); state.dataMircoturbElectGen->MTGenerator(GeneratorNum).RefElecPowerOutput = NumArray(1); diff --git a/src/EnergyPlus/MixerComponent.cc b/src/EnergyPlus/MixerComponent.cc index 8153c8342aa..759a1fe21a0 100644 --- a/src/EnergyPlus/MixerComponent.cc +++ b/src/EnergyPlus/MixerComponent.cc @@ -216,7 +216,6 @@ void GetMixerInput(EnergyPlusData &state) lAlphaBlanks, cAlphaFields, cNumericFields); - Util::IsNameEmpty(state, AlphArray(1), CurrentModuleObject, ErrorsFound); state.dataMixerComponent->MixerCond(MixerNum).MixerName = AlphArray(1); diff --git a/src/EnergyPlus/NodeInputManager.cc b/src/EnergyPlus/NodeInputManager.cc index 63f6cc3bf4a..c4a672d8a10 100644 --- a/src/EnergyPlus/NodeInputManager.cc +++ b/src/EnergyPlus/NodeInputManager.cc @@ -559,9 +559,6 @@ void GetNodeListsInput(EnergyPlusData &state, bool &ErrorsFound) // Set to true for (int Loop = 1; Loop <= state.dataNodeInputMgr->NumOfNodeLists; ++Loop) { state.dataInputProcessing->inputProcessor->getObjectItem( state, CurrentModuleObject, Loop, cAlphas, NumAlphas, rNumbers, NumNumbers, IOStatus); - if (Util::IsNameEmpty(state, cAlphas(1), CurrentModuleObject, localErrorsFound)) { - continue; - } ++NCount; state.dataNodeInputMgr->NodeLists(NCount).Name = cAlphas(1); diff --git a/src/EnergyPlus/OutdoorAirUnit.cc b/src/EnergyPlus/OutdoorAirUnit.cc index 54d05764193..8caf6b00e5a 100644 --- a/src/EnergyPlus/OutdoorAirUnit.cc +++ b/src/EnergyPlus/OutdoorAirUnit.cc @@ -306,7 +306,6 @@ namespace OutdoorAirUnit { cNumericFields); ErrorObjectHeader eoh{routineName, CurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), CurrentModuleObject, ErrorsFound); // A1 thisOutAirUnit.Name = state.dataIPShortCut->cAlphaArgs(1); diff --git a/src/EnergyPlus/OutputReportTabular.cc b/src/EnergyPlus/OutputReportTabular.cc index 37400c4810d..83b13a34a16 100644 --- a/src/EnergyPlus/OutputReportTabular.cc +++ b/src/EnergyPlus/OutputReportTabular.cc @@ -371,7 +371,6 @@ void GetInputTabularMonthly(EnergyPlusData &state) Array1D_string AlphArray; // character string data Array1D NumArray; // numeric data int IOStat = -1; // IO Status when calling get input subroutine - bool ErrorsFound = false; state.dataInputProcessing->inputProcessor->getObjectDefMaxArgs(state, CurrentModuleObject, NumParams, NumAlphas, NumNums); AlphArray.allocate(NumAlphas); @@ -379,12 +378,10 @@ void GetInputTabularMonthly(EnergyPlusData &state) for (int TabNum = 1, TabNum_end = ort->MonthlyInputCount; TabNum <= TabNum_end; ++TabNum) { // MonthlyInputCount is modified in the loop state.dataInputProcessing->inputProcessor->getObjectItem(state, CurrentModuleObject, TabNum, AlphArray, NumAlphas, NumArray, NumNums, IOStat); - if (TabNum - 1 > 0) { - Util::IsNameEmpty(state, AlphArray(1), CurrentModuleObject, ErrorsFound); - } if (NumAlphas < 2) { ShowSevereError(state, EnergyPlus::format("{}: No fields specified.", CurrentModuleObject)); } + // add to the data structure int const curTable = AddMonthlyReport(state, AlphArray(1), int(NumArray(1))); for (int jField = 2; jField <= NumAlphas; jField += 2) { diff --git a/src/EnergyPlus/PCMThermalStorage.cc b/src/EnergyPlus/PCMThermalStorage.cc index a0724f649ea..dd88523ae66 100644 --- a/src/EnergyPlus/PCMThermalStorage.cc +++ b/src/EnergyPlus/PCMThermalStorage.cc @@ -509,8 +509,6 @@ namespace PCMStorage { state.dataIPShortCut->cAlphaFieldNames, state.dataIPShortCut->cNumericFieldNames); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); - PCM.Name = state.dataIPShortCut->cAlphaArgs(1); PCM.AvailabilityScheduleName = state.dataIPShortCut->cAlphaArgs(2); diff --git a/src/EnergyPlus/PackagedThermalStorageCoil.cc b/src/EnergyPlus/PackagedThermalStorageCoil.cc index 1efaa0cedef..ab6d4baa501 100644 --- a/src/EnergyPlus/PackagedThermalStorageCoil.cc +++ b/src/EnergyPlus/PackagedThermalStorageCoil.cc @@ -240,8 +240,6 @@ void GetTESCoilInput(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); - // ErrorsFound will be set to True if problem was found, left untouched otherwise VerifyUniqueCoilName(state, cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1), ErrorsFound, cCurrentModuleObject + " Name"); diff --git a/src/EnergyPlus/Photovoltaics.cc b/src/EnergyPlus/Photovoltaics.cc index 9f996e57dbb..6c9b0339f12 100644 --- a/src/EnergyPlus/Photovoltaics.cc +++ b/src/EnergyPlus/Photovoltaics.cc @@ -333,7 +333,6 @@ namespace Photovoltaics { ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); state.dataPhotovoltaic->PVarray(PVnum).Name = s_ipsc->cAlphaArgs(1); state.dataPhotovoltaic->PVarray(PVnum).SurfaceName = s_ipsc->cAlphaArgs(2); @@ -477,9 +476,6 @@ namespace Photovoltaics { ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - if (Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound)) { - continue; - } tmpSimpleModuleParams(ModNum).Name = s_ipsc->cAlphaArgs(1); tmpSimpleModuleParams(ModNum).ActiveFraction = s_ipsc->rNumericArgs(1); @@ -523,9 +519,7 @@ namespace Photovoltaics { s_ipsc->cNumericFieldNames); ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - if (Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound)) { - continue; - } + tmpTRNSYSModuleParams(ModNum).Name = s_ipsc->cAlphaArgs(1); if (s_ipsc->lAlphaFieldBlanks(2)) { @@ -575,9 +569,6 @@ namespace Photovoltaics { s_ipsc->lAlphaFieldBlanks, s_ipsc->cAlphaFieldNames, s_ipsc->cNumericFieldNames); - if (Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound)) { - continue; - } tmpSNLModuleParams(ModNum).name = s_ipsc->cAlphaArgs(1); tmpSNLModuleParams(ModNum).Acoll = s_ipsc->rNumericArgs(1); diff --git a/src/EnergyPlus/Plant/PlantManager.cc b/src/EnergyPlus/Plant/PlantManager.cc index 08b5d10edae..1c07600793f 100644 --- a/src/EnergyPlus/Plant/PlantManager.cc +++ b/src/EnergyPlus/Plant/PlantManager.cc @@ -389,7 +389,6 @@ void GetPlantLoopData(EnergyPlusData &state) eoh.objectName = Alpha(1); } - Util::IsNameEmpty(state, Alpha(1), CurrentModuleObject, ErrorsFound); this_loop.Name = Alpha(1); // Load the Plant Loop Name if (Util::SameString(Alpha(2), "STEAM")) { diff --git a/src/EnergyPlus/PlantCentralGSHP.cc b/src/EnergyPlus/PlantCentralGSHP.cc index b04e969e54f..373ba974314 100644 --- a/src/EnergyPlus/PlantCentralGSHP.cc +++ b/src/EnergyPlus/PlantCentralGSHP.cc @@ -593,11 +593,6 @@ void GetWrapperInput(EnergyPlusData &state) state.dataPlantCentralGSHP->Wrapper(WrapperNum).Name = state.dataIPShortCut->cAlphaArgs(1); - // initialize nth chiller heater index (including identical units) for current wrapper - if (Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound)) { - continue; - } - if (state.dataIPShortCut->cAlphaArgs(2) == "SMARTMIXING") { state.dataPlantCentralGSHP->Wrapper(WrapperNum).ControlMode = CondenserType::SmartMixing; } @@ -1214,7 +1209,6 @@ void GetChillerHeaterInput(EnergyPlusData &state) state.dataIPShortCut->cNumericFieldNames); state.dataPlantCentralGSHP->ChillerHeater(ChillerHeaterNum).Name = state.dataIPShortCut->cAlphaArgs(1); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, CHErrorsFound); if (Util::SameString(state.dataIPShortCut->cAlphaArgs(4), "LEAVINGCONDENSER")) { state.dataPlantCentralGSHP->ChillerHeater(ChillerHeaterNum).CondModeCooling = CondenserModeTemperature::LeavingCondenser; diff --git a/src/EnergyPlus/PlantChillers.cc b/src/EnergyPlus/PlantChillers.cc index d5db753bf7a..2daf58ab1e2 100644 --- a/src/EnergyPlus/PlantChillers.cc +++ b/src/EnergyPlus/PlantChillers.cc @@ -210,8 +210,6 @@ namespace PlantChillers { ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); - // ErrorsFound will be set to True if problem was found, left untouched otherwise GlobalNames::VerifyUniqueChillerName(state, state.dataIPShortCut->cCurrentModuleObject, @@ -2255,8 +2253,6 @@ namespace PlantChillers { ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); - // ErrorsFound will be set to True if problem was found, left untouched otherwise GlobalNames::VerifyUniqueChillerName(state, state.dataIPShortCut->cCurrentModuleObject, @@ -4324,8 +4320,6 @@ namespace PlantChillers { ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); - // ErrorsFound will be set to True if problem was found, left untouched otherwise GlobalNames::VerifyUniqueChillerName(state, state.dataIPShortCut->cCurrentModuleObject, @@ -6294,7 +6288,6 @@ namespace PlantChillers { state.dataIPShortCut->cNumericFieldNames); ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); // ErrorsFound will be set to True if problem was found, left untouched otherwise GlobalNames::VerifyUniqueChillerName(state, diff --git a/src/EnergyPlus/PlantComponentTemperatureSources.cc b/src/EnergyPlus/PlantComponentTemperatureSources.cc index be1ab7d3d9c..9801ad836f2 100644 --- a/src/EnergyPlus/PlantComponentTemperatureSources.cc +++ b/src/EnergyPlus/PlantComponentTemperatureSources.cc @@ -491,8 +491,6 @@ namespace PlantComponentTemperatureSources { ErrorObjectHeader eoh{routineName, cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); - state.dataPlantCompTempSrc->WaterSource(SourceNum).Name = state.dataIPShortCut->cAlphaArgs(1); state.dataPlantCompTempSrc->WaterSource(SourceNum).InletNodeNum = diff --git a/src/EnergyPlus/PlantCondLoopOperation.cc b/src/EnergyPlus/PlantCondLoopOperation.cc index 2e7e2367d39..f44bb006345 100644 --- a/src/EnergyPlus/PlantCondLoopOperation.cc +++ b/src/EnergyPlus/PlantCondLoopOperation.cc @@ -367,9 +367,6 @@ void GetPlantOperationInput(EnergyPlusData &state, bool &GetInputOK) for (OpNum = 1; OpNum <= NumPlantOpSchemes; ++OpNum) { state.dataInputProcessing->inputProcessor->getObjectItem( state, CurrentModuleObject, OpNum, state.dataIPShortCut->cAlphaArgs, NumAlphas, state.dataIPShortCut->rNumericArgs, NumNums, IOStat); - if (Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), CurrentModuleObject, ErrorsFound)) { - continue; - } } CurrentModuleObject = "CondenserEquipmentOperationSchemes"; @@ -377,9 +374,6 @@ void GetPlantOperationInput(EnergyPlusData &state, bool &GetInputOK) for (OpNum = 1; OpNum <= NumCondOpSchemes; ++OpNum) { state.dataInputProcessing->inputProcessor->getObjectItem( state, CurrentModuleObject, OpNum, state.dataIPShortCut->cAlphaArgs, NumAlphas, state.dataIPShortCut->rNumericArgs, NumNums, IOStat); - if (Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), CurrentModuleObject, ErrorsFound)) { - continue; - } } // Load the Plant data structure diff --git a/src/EnergyPlus/PlantHeatExchangerFluidToFluid.cc b/src/EnergyPlus/PlantHeatExchangerFluidToFluid.cc index a7983a8f1cb..6a68c592a44 100644 --- a/src/EnergyPlus/PlantHeatExchangerFluidToFluid.cc +++ b/src/EnergyPlus/PlantHeatExchangerFluidToFluid.cc @@ -272,8 +272,6 @@ void GetFluidHeatExchangerInput(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, cCurrentModuleObject, cAlphaArgs(1)}; - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); - state.dataPlantHXFluidToFluid->FluidHX(CompLoop).Name = cAlphaArgs(1); if (lAlphaFieldBlanks(2)) { diff --git a/src/EnergyPlus/PlantLoadProfile.cc b/src/EnergyPlus/PlantLoadProfile.cc index 4d53364739b..1233731e495 100644 --- a/src/EnergyPlus/PlantLoadProfile.cc +++ b/src/EnergyPlus/PlantLoadProfile.cc @@ -429,8 +429,6 @@ void GetPlantProfileInput(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); - state.dataPlantLoadProfile->PlantProfile(ProfileNum).Name = state.dataIPShortCut->cAlphaArgs(1); state.dataPlantLoadProfile->PlantProfile(ProfileNum).Type = DataPlant::PlantEquipmentType::PlantLoadProfile; // parameter assigned in DataPlant diff --git a/src/EnergyPlus/PlantPipingSystemsManager.cc b/src/EnergyPlus/PlantPipingSystemsManager.cc index b025bdbe24c..8639bd35824 100644 --- a/src/EnergyPlus/PlantPipingSystemsManager.cc +++ b/src/EnergyPlus/PlantPipingSystemsManager.cc @@ -545,7 +545,7 @@ namespace PlantPipingSystemsManager { // Get the name, validate thisDomain.Name = state.dataIPShortCut->cAlphaArgs(1); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); + // Mesh extents, validated by IP thisDomain.Extents.xMax = state.dataIPShortCut->rNumericArgs(1); thisDomain.Extents.yMax = state.dataIPShortCut->rNumericArgs(2); @@ -1530,7 +1530,6 @@ namespace PlantPipingSystemsManager { // Get the name, validate thisCircuit.Name = s_ipsc->cAlphaArgs(1); - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); // Read pipe thermal properties, validated by IP thisCircuit.PipeProperties.Conductivity = s_ipsc->rNumericArgs(1); @@ -1807,7 +1806,7 @@ namespace PlantPipingSystemsManager { // Get the name, validate thisSegment.Name = s_ipsc->cAlphaArgs(1); - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); + // Read in the pipe location, validated as positive by IP // -- note that these values will be altered by the main GetInput routine in two ways: // 1) shift for basement wall if selected @@ -1890,7 +1889,6 @@ namespace PlantPipingSystemsManager { // Get the name, validate std::string thisTrenchName = s_ipsc->cAlphaArgs(1); - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); int const NumPipeSegments = static_cast(s_ipsc->rNumericArgs(3)); Real64 const thisInterPipeSpacing = s_ipsc->rNumericArgs(4); diff --git a/src/EnergyPlus/PurchasedAirManager.cc b/src/EnergyPlus/PurchasedAirManager.cc index c22bba488aa..1df1f049df4 100644 --- a/src/EnergyPlus/PurchasedAirManager.cc +++ b/src/EnergyPlus/PurchasedAirManager.cc @@ -282,7 +282,6 @@ void GetPurchasedAir(EnergyPlusData &state) state.dataPurchasedAirMgr->PurchAirNumericFields(purchAirNum).FieldNames.allocate(NumNums); state.dataPurchasedAirMgr->PurchAirNumericFields(purchAirNum).FieldNames = ""; state.dataPurchasedAirMgr->PurchAirNumericFields(purchAirNum).FieldNames = s_ipsc->cNumericFieldNames; - Util::IsNameEmpty(state, thisObjectName, s_ipsc->cCurrentModuleObject, ErrorsFound); PurchAir.Name = Util::makeUPPER(thisObjectName); std::string cAlphaFieldName = "Availability Schedule Name"; // get optional availability schedule diff --git a/src/EnergyPlus/RefrigeratedCase.cc b/src/EnergyPlus/RefrigeratedCase.cc index 766154cdf17..97b5e3881c6 100644 --- a/src/EnergyPlus/RefrigeratedCase.cc +++ b/src/EnergyPlus/RefrigeratedCase.cc @@ -714,7 +714,7 @@ void GetRefrigerationInput(EnergyPlusData &state) ++NumDisplayCases; AlphaNum = 1; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); + RefrigCase(CaseNum).Name = Alphas(AlphaNum); AlphaNum = 2; @@ -1843,8 +1843,6 @@ void GetRefrigerationInput(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)}; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); - WarehouseCoil(CoilID).Name = Alphas(AlphaNum); // A2 @@ -2482,7 +2480,6 @@ void GetRefrigerationInput(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)}; AlphaNum = 1; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); AirChillerSet(SetID).Name = Alphas(AlphaNum); @@ -2606,7 +2603,7 @@ void GetRefrigerationInput(EnergyPlusData &state) lAlphaBlanks, cAlphaFieldNames, cNumericFieldNames); - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); + CaseAndWalkInList(ListNum).Name = Alphas(1); // CaseAndWalkInList alphas include CaseAndWalkInList name and one name for each Case or WalkIn in list @@ -2707,7 +2704,6 @@ void GetRefrigerationInput(EnergyPlusData &state) cNumericFieldNames); ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)}; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); RefrigRack(RackNum).Name = Alphas(1); RefrigRack(RackNum).MyIdx = RackNum; @@ -4195,7 +4191,6 @@ void GetRefrigerationInput(EnergyPlusData &state) cNumericFieldNames); ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)}; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); Secondary(SecondaryNum).Name = Alphas(1); @@ -5150,7 +5145,6 @@ void GetRefrigerationInput(EnergyPlusData &state) lAlphaBlanks, cAlphaFieldNames, cNumericFieldNames); - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); TransferLoadList(ListNum).Name = Alphas(1); @@ -5234,7 +5228,6 @@ void GetRefrigerationInput(EnergyPlusData &state) cAlphaFieldNames, cNumericFieldNames); CompressorLists(ListNum).NumCompressors = NumAlphas - 1; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); CompressorLists(ListNum).Name = Alphas(1); if (!allocated(CompressorLists(ListNum).CompItemNum)) { @@ -5279,7 +5272,6 @@ void GetRefrigerationInput(EnergyPlusData &state) cNumericFieldNames); ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)}; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); System(RefrigSysNum).Name = Alphas(1); @@ -6322,8 +6314,6 @@ void GetRefrigerationInput(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)}; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); - TransSystem(TransRefrigSysNum).Name = Alphas(1); // Read refrigerant for this system diff --git a/src/EnergyPlus/ReturnAirPathManager.cc b/src/EnergyPlus/ReturnAirPathManager.cc index 26f51cf8e54..fa22f58ecb7 100644 --- a/src/EnergyPlus/ReturnAirPathManager.cc +++ b/src/EnergyPlus/ReturnAirPathManager.cc @@ -142,7 +142,6 @@ namespace ReturnAirPathManager { state.dataIPShortCut->rNumericArgs, NumNums, IOStat); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); state.dataZoneEquip->ReturnAirPath(PathNum).Name = state.dataIPShortCut->cAlphaArgs(1); state.dataZoneEquip->ReturnAirPath(PathNum).NumOfComponents = nint((NumAlphas - 2.0) / 2.0); diff --git a/src/EnergyPlus/RuntimeLanguageProcessor.cc b/src/EnergyPlus/RuntimeLanguageProcessor.cc index 39bc8838db6..8e53b2cb391 100644 --- a/src/EnergyPlus/RuntimeLanguageProcessor.cc +++ b/src/EnergyPlus/RuntimeLanguageProcessor.cc @@ -3204,7 +3204,6 @@ void GetRuntimeLanguageUserInput(EnergyPlusData &state) lAlphaFieldBlanks, cAlphaFieldNames, cNumericFieldNames); - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); ValidateEMSVariableName(state, cCurrentModuleObject, cAlphaArgs(1), cAlphaFieldNames(1), errFlag, ErrorsFound); if (!errFlag) { diff --git a/src/EnergyPlus/SimAirServingZones.cc b/src/EnergyPlus/SimAirServingZones.cc index eebbb9ca161..bc97ee54cd2 100644 --- a/src/EnergyPlus/SimAirServingZones.cc +++ b/src/EnergyPlus/SimAirServingZones.cc @@ -445,7 +445,7 @@ void GetAirPathData(EnergyPlusData &state) // Assign the air system data to the simulation variables. // Data needed to simulate the system goes into PrimaryAirSystem. // Data connecting the air system to the zone equipment goes into AirToZoneNodeInfo (in DataLoopNode). - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); + primaryAirSystems.Name = Alphas(1); airLoopZoneInfo.AirLoopName = Alphas(1); if (NumAlphas < 9) { diff --git a/src/EnergyPlus/SingleDuct.cc b/src/EnergyPlus/SingleDuct.cc index b5e2ac097d2..28985988201 100644 --- a/src/EnergyPlus/SingleDuct.cc +++ b/src/EnergyPlus/SingleDuct.cc @@ -5184,7 +5184,7 @@ void GetATMixers(EnergyPlusData &state) state.dataIPShortCut->cNumericFieldNames); auto &atMixer = state.dataSingleDuct->SysATMixer(ATMixerNum); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); + state.dataSingleDuct->SysATMixer(ATMixerNum).Name = state.dataIPShortCut->cAlphaArgs(1); atMixer.type = static_cast(getEnumValue(HVAC::mixerTypeLocNamesUC, ipsc->cAlphaArgs(7))); diff --git a/src/EnergyPlus/SizingManager.cc b/src/EnergyPlus/SizingManager.cc index ea2020e8a57..265d53ab9ce 100644 --- a/src/EnergyPlus/SizingManager.cc +++ b/src/EnergyPlus/SizingManager.cc @@ -2246,7 +2246,6 @@ void GetOARequirements(EnergyPlusData &state) lAlphaBlanks, cAlphaFields, cNumericFields); - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); state.dataSize->OARequirements(OAIndex).Name = Alphas(1); @@ -2499,7 +2498,6 @@ void GetZoneAirDistribution(EnergyPlusData &state) cNumericFields); ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)}; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); state.dataSize->ZoneAirDistribution(ZADIndex).Name = Alphas(1); @@ -2744,7 +2742,6 @@ void GetZoneSizingInput(EnergyPlusData &state) state.dataIPShortCut->lAlphaFieldBlanks, state.dataIPShortCut->cAlphaFieldNames, state.dataIPShortCut->cNumericFieldNames); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); SizingZoneObjects(Item).Name = state.dataIPShortCut->cAlphaArgs(1); @@ -2829,10 +2826,6 @@ void GetZoneSizingInput(EnergyPlusData &state) state.dataSize->ZoneSizingInput(ZoneSizIndex).ZoneName = "Invalid Zone Name"; } } - bool const nameEmpty = Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); - if (nameEmpty && !SizingZoneObjects(Item).ZoneListActive) { - ShowContinueError(state, "Zone may have been entered in a ZoneList assignment."); - } // A2, \field Zone Cooling Design Supply Air Temperature Input Method // \required-field @@ -4078,7 +4071,6 @@ void GetPlantSizingInput(EnergyPlusData &state) state.dataIPShortCut->lAlphaFieldBlanks, state.dataIPShortCut->cAlphaFieldNames, state.dataIPShortCut->cNumericFieldNames); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); state.dataSize->PlantSizData(PltSizIndex).PlantLoopName = state.dataIPShortCut->cAlphaArgs(1); state.dataSize->PlantSizData(PltSizIndex).ExitTemp = state.dataIPShortCut->rNumericArgs(1); @@ -4654,7 +4646,6 @@ void GetZoneHVACSizing(EnergyPlusData &state) lAlphaBlanks, cAlphaFields, cNumericFields); - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); state.dataSize->ZoneHVACSizing(zSIndex).Name = Alphas(1); @@ -5179,8 +5170,6 @@ void GetAirTerminalSizing(EnergyPlusData &state) state.dataIPShortCut->cAlphaFieldNames, state.dataIPShortCut->cNumericFieldNames); - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); - auto &thisATSizing = state.dataSize->AirTerminalSizingSpec(zSIndex); thisATSizing.Name = state.dataIPShortCut->cAlphaArgs(1); thisATSizing.DesSensCoolingFrac = state.dataIPShortCut->rNumericArgs(1); diff --git a/src/EnergyPlus/SplitterComponent.cc b/src/EnergyPlus/SplitterComponent.cc index f499dc2e592..980512b58ae 100644 --- a/src/EnergyPlus/SplitterComponent.cc +++ b/src/EnergyPlus/SplitterComponent.cc @@ -221,7 +221,6 @@ namespace SplitterComponent { lAlphaBlanks, cAlphaFields, cNumericFields); - Util::IsNameEmpty(state, AlphArray(1), CurrentModuleObject, ErrorsFound); state.dataSplitterComponent->SplitterCond(SplitterNum).SplitterName = AlphArray(1); state.dataSplitterComponent->SplitterCond(SplitterNum).InletNode = diff --git a/src/EnergyPlus/SteamBaseboardRadiator.cc b/src/EnergyPlus/SteamBaseboardRadiator.cc index 25b55f49eb5..6916ebc2464 100644 --- a/src/EnergyPlus/SteamBaseboardRadiator.cc +++ b/src/EnergyPlus/SteamBaseboardRadiator.cc @@ -332,8 +332,6 @@ namespace SteamBaseboardRadiator { state.dataIPShortCut->cAlphaFieldNames, state.dataIPShortCut->cNumericFieldNames); - Util::IsNameEmpty( - state, state.dataIPShortCut->cAlphaArgs(1), state.dataSteamBaseboardRadiator->cCMO_BBRadiator_Steam_Design, ErrorsFound); state.dataSteamBaseboardRadiator->SteamBaseboardDesignNumericFields(BaseboardDesignNum).FieldNames.allocate(NumNumbers); state.dataSteamBaseboardRadiator->SteamBaseboardDesignNumericFields(BaseboardDesignNum).FieldNames = ""; state.dataSteamBaseboardRadiator->SteamBaseboardDesignNumericFields(BaseboardDesignNum).FieldNames = @@ -520,7 +518,6 @@ namespace SteamBaseboardRadiator { ErrorObjectHeader eoh{routineName, state.dataSteamBaseboardRadiator->cCMO_BBRadiator_Steam, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataSteamBaseboardRadiator->cCMO_BBRadiator_Steam, ErrorsFound); state.dataSteamBaseboardRadiator->SteamBaseboardNumericFields(BaseboardNum).FieldNames.allocate(NumNumbers); state.dataSteamBaseboardRadiator->SteamBaseboardNumericFields(BaseboardNum).FieldNames = ""; state.dataSteamBaseboardRadiator->SteamBaseboardNumericFields(BaseboardNum).FieldNames = state.dataIPShortCut->cNumericFieldNames; diff --git a/src/EnergyPlus/SteamCoils.cc b/src/EnergyPlus/SteamCoils.cc index 2e5b865847c..a65659cafa4 100644 --- a/src/EnergyPlus/SteamCoils.cc +++ b/src/EnergyPlus/SteamCoils.cc @@ -273,7 +273,6 @@ namespace SteamCoils { cNumericFields); ErrorObjectHeader eoh{routineName, CurrentModuleObject, AlphArray(1)}; - Util::IsNameEmpty(state, AlphArray(1), CurrentModuleObject, ErrorsFound); // ErrorsFound will be set to True if problem was found, left untouched otherwise VerifyUniqueCoilName(state, CurrentModuleObject, AlphArray(1), ErrorsFound, CurrentModuleObject + " Name"); diff --git a/src/EnergyPlus/SurfaceGeometry.cc b/src/EnergyPlus/SurfaceGeometry.cc index 32203af4f15..3944dd11e7e 100644 --- a/src/EnergyPlus/SurfaceGeometry.cc +++ b/src/EnergyPlus/SurfaceGeometry.cc @@ -3845,7 +3845,7 @@ namespace SurfaceGeometry { auto &s_ipsc = state.dataIPShortCut; GetOSCData(state, ErrorsFound); - GetOSCMData(state, ErrorsFound); + GetOSCMData(state); GetFoundationData(state, ErrorsFound); NeedToAddSurfaces = 0; @@ -7483,22 +7483,7 @@ namespace SurfaceGeometry { s_ipsc->lAlphaFieldBlanks, s_ipsc->cAlphaFieldNames, s_ipsc->cNumericFieldNames); - // first handle cAlphaArgs - bool ErrorInName = false; - bool IsBlank = false; - - Util::VerifyName(state, - s_ipsc->cAlphaArgs(1), - state.dataHeatBal->ExtVentedCavity, - Item - 1, - ErrorInName, - IsBlank, - s_ipsc->cCurrentModuleObject + " Name"); - if (ErrorInName) { - ShowContinueError(state, "...cannot not duplicate other names"); - ErrorsFound = true; - continue; - } + state.dataHeatBal->ExtVentedCavity(Item).Name = s_ipsc->cAlphaArgs(1); state.dataHeatBal->ExtVentedCavity(Item).OSCMName = s_ipsc->cAlphaArgs(2); @@ -8016,8 +8001,6 @@ namespace SurfaceGeometry { ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); - SurfLocalEnv.Name = s_ipsc->cAlphaArgs(1); // Assign surface number @@ -8196,8 +8179,6 @@ namespace SurfaceGeometry { ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); - // A1: Name SrdSurfsProp.Name = s_ipsc->cAlphaArgs(1); @@ -9749,21 +9730,6 @@ namespace SurfaceGeometry { ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - bool ErrorInName = false; - bool IsBlank = false; - - Util::VerifyName(state, - s_ipsc->cAlphaArgs(1), - state.dataSurface->WindowShadingControl, - ControlNum, - ErrorInName, - IsBlank, - s_ipsc->cCurrentModuleObject + " Name"); - if (ErrorInName) { - ErrorsFound = true; - continue; - } - ++ControlNum; auto &windowShadingControl = state.dataSurface->WindowShadingControl(ControlNum); @@ -11034,7 +11000,7 @@ namespace SurfaceGeometry { fndInput.name = s_ipsc->cAlphaArgs(alpF); alpF++; - Util::IsNameEmpty(state, fndInput.name, s_ipsc->cCurrentModuleObject, ErrorInName); + if (ErrorInName) { ErrorsFound = true; continue; @@ -11591,14 +11557,6 @@ namespace SurfaceGeometry { s_ipsc->cNumericFieldNames); ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - bool ErrorInName = false; - bool IsBlank = false; - Util::VerifyName( - state, s_ipsc->cAlphaArgs(1), state.dataSurface->OSC, OSCNum, ErrorInName, IsBlank, s_ipsc->cCurrentModuleObject + " Name"); - if (ErrorInName) { - ErrorsFound = true; - continue; - } ++OSCNum; state.dataSurface->OSC(OSCNum).Name = s_ipsc->cAlphaArgs(1); @@ -11703,7 +11661,7 @@ namespace SurfaceGeometry { } } - void GetOSCMData(EnergyPlusData &state, bool &ErrorsFound) + void GetOSCMData(EnergyPlusData &state) { // SUBROUTINE INFORMATION: @@ -11743,14 +11701,6 @@ namespace SurfaceGeometry { for (int Loop = 1; Loop <= state.dataSurface->TotOSCM; ++Loop) { state.dataInputProcessing->inputProcessor->getObjectItem( state, s_ipsc->cCurrentModuleObject, Loop, s_ipsc->cAlphaArgs, NumAlphas, s_ipsc->rNumericArgs, NumProps, IOStat); - bool ErrorInName = false; - bool IsBlank = false; - Util::VerifyName( - state, s_ipsc->cAlphaArgs(1), state.dataSurface->OSCM, OSCMNum, ErrorInName, IsBlank, s_ipsc->cCurrentModuleObject + " Name"); - if (ErrorInName) { - ErrorsFound = true; - continue; - } ++OSCMNum; state.dataSurface->OSCM(OSCMNum).Name = s_ipsc->cAlphaArgs(1); diff --git a/src/EnergyPlus/SurfaceGeometry.hh b/src/EnergyPlus/SurfaceGeometry.hh index 34c1e17f591..4020580d578 100644 --- a/src/EnergyPlus/SurfaceGeometry.hh +++ b/src/EnergyPlus/SurfaceGeometry.hh @@ -306,7 +306,7 @@ namespace SurfaceGeometry { void GetOSCData(EnergyPlusData &state, bool &ErrorsFound); - void GetOSCMData(EnergyPlusData &state, bool &ErrorsFound); + void GetOSCMData(EnergyPlusData &state); void GetFoundationData(EnergyPlusData &state, bool &ErrorsFound); diff --git a/src/EnergyPlus/SwimmingPool.cc b/src/EnergyPlus/SwimmingPool.cc index a90c4c2c2e0..11077616157 100644 --- a/src/EnergyPlus/SwimmingPool.cc +++ b/src/EnergyPlus/SwimmingPool.cc @@ -230,7 +230,6 @@ void GetSwimmingPool(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, Alphas(1)}; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); state.dataSwimmingPools->Pool(Item).Name = Alphas(1); state.dataSwimmingPools->Pool(Item).SurfaceName = Alphas(2); diff --git a/src/EnergyPlus/ThermalChimney.cc b/src/EnergyPlus/ThermalChimney.cc index 96a7862ac12..73ef10c5da1 100644 --- a/src/EnergyPlus/ThermalChimney.cc +++ b/src/EnergyPlus/ThermalChimney.cc @@ -184,10 +184,6 @@ namespace ThermalChimney { ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - if (Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound)) { - continue; - } - // First Alpha is Thermal Chimney Name state.dataThermalChimneys->ThermalChimneySys(Loop).Name = state.dataIPShortCut->cAlphaArgs(1); diff --git a/src/EnergyPlus/UnitHeater.cc b/src/EnergyPlus/UnitHeater.cc index 76dd999f73b..bcb89a26034 100644 --- a/src/EnergyPlus/UnitHeater.cc +++ b/src/EnergyPlus/UnitHeater.cc @@ -261,7 +261,6 @@ namespace UnitHeater { state.dataUnitHeaters->UnitHeatNumericFields(UnitHeatNum).FieldNames.allocate(NumNumbers); state.dataUnitHeaters->UnitHeatNumericFields(UnitHeatNum).FieldNames = ""; state.dataUnitHeaters->UnitHeatNumericFields(UnitHeatNum).FieldNames = cNumericFields; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); state.dataUnitHeaters->UnitHeat(UnitHeatNum).Name = Alphas(1); diff --git a/src/EnergyPlus/UnitVentilator.cc b/src/EnergyPlus/UnitVentilator.cc index bd91d967880..1c93291056d 100644 --- a/src/EnergyPlus/UnitVentilator.cc +++ b/src/EnergyPlus/UnitVentilator.cc @@ -274,7 +274,6 @@ namespace UnitVentilator { state.dataUnitVentilators->UnitVentNumericFields(UnitVentNum).FieldNames.allocate(NumNumbers); state.dataUnitVentilators->UnitVentNumericFields(UnitVentNum).FieldNames = ""; state.dataUnitVentilators->UnitVentNumericFields(UnitVentNum).FieldNames = cNumericFields; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); unitVent.Name = Alphas(1); if (lAlphaBlanks(2)) { diff --git a/src/EnergyPlus/UserDefinedComponents.cc b/src/EnergyPlus/UserDefinedComponents.cc index 54f125e2e02..15fbf6157b4 100644 --- a/src/EnergyPlus/UserDefinedComponents.cc +++ b/src/EnergyPlus/UserDefinedComponents.cc @@ -609,7 +609,6 @@ namespace UserDefinedComponents { lAlphaFieldBlanks, cAlphaFieldNames, _); - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); state.dataUserDefinedComponents->UserPlantComp(CompLoop).Name = cAlphaArgs(1); @@ -1087,7 +1086,6 @@ namespace UserDefinedComponents { lAlphaFieldBlanks, cAlphaFieldNames, _); - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); // ErrorsFound will be set to True if problem was found, left untouched otherwise GlobalNames::VerifyUniqueCoilName(state, cCurrentModuleObject, cAlphaArgs(1), ErrorsFound, cCurrentModuleObject + " Name"); @@ -1493,7 +1491,7 @@ namespace UserDefinedComponents { lAlphaFieldBlanks, cAlphaFieldNames, _); - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); + state.dataUserDefinedComponents->UserZoneAirHVAC(CompLoop).Name = cAlphaArgs(1); // now get program manager for model simulations @@ -1975,7 +1973,7 @@ namespace UserDefinedComponents { lAlphaFieldBlanks, cAlphaFieldNames, _); - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); + state.dataUserDefinedComponents->UserAirTerminal(CompLoop).Name = cAlphaArgs(1); // now get program manager for model simulations diff --git a/src/EnergyPlus/UtilityRoutines.cc b/src/EnergyPlus/UtilityRoutines.cc index 3517d5b02e1..2a7d833628c 100644 --- a/src/EnergyPlus/UtilityRoutines.cc +++ b/src/EnergyPlus/UtilityRoutines.cc @@ -216,40 +216,6 @@ namespace Util { return 0; // Not found } - int FindItemInSortedList(std::string_view const String, Array1S_string const ListOfItems, int const NumItems) - { - - // FUNCTION INFORMATION: - // AUTHOR Linda K. Lawrie - // DATE WRITTEN September 1997 - - // PURPOSE OF THIS FUNCTION: - // This function looks up a string in a similar list of - // items and returns the index of the item in the list, if - // found. This routine is case insensitive. - - // SUBROUTINE LOCAL VARIABLE DECLARATIONS: - int Probe = 0; - int LBnd = 0; - int UBnd = NumItems + 1; - while (true) { - Probe = (UBnd - LBnd) / 2; - if (Probe == 0) { - break; - } - Probe += LBnd; - if (equali(String, ListOfItems(Probe))) { - break; - } - if (lessthani(String, ListOfItems(Probe))) { - UBnd = Probe; - } else { - LBnd = Probe; - } - } - return Probe; - } - int FindItem(std::string_view const String, Array1D_string const &ListOfItems, int const NumItems) { @@ -302,89 +268,6 @@ namespace Util { return 0; // Not found } - void VerifyName(EnergyPlusData &state, - std::string const &NameToVerify, - Array1D_string const &NamesList, - int const NumOfNames, - bool &ErrorFound, - bool &IsBlank, - std::string const &StringToDisplay) - { - - // SUBROUTINE INFORMATION: - // AUTHOR Linda Lawrie - // DATE WRITTEN February 2000 - - // PURPOSE OF THIS SUBROUTINE: - // This subroutine verifies that a new name can be added to the - // list of names for this item (i.e., that there isn't one of that - // name already and that this name is not blank). - - ErrorFound = false; - if (NumOfNames > 0) { - int Found = FindItem(NameToVerify, NamesList, NumOfNames); - if (Found != 0) { - ShowSevereError(state, EnergyPlus::format("{}, duplicate name={}", StringToDisplay, NameToVerify)); - ErrorFound = true; - } - } - - if (NameToVerify.empty()) { - ShowSevereError(state, EnergyPlus::format("{}, cannot be blank", StringToDisplay)); - ErrorFound = true; - IsBlank = true; - } else { - IsBlank = false; - } - } - - void VerifyName(EnergyPlusData &state, - std::string const &NameToVerify, - Array1S_string const NamesList, - int const NumOfNames, - bool &ErrorFound, - bool &IsBlank, - std::string const &StringToDisplay) - { - - // SUBROUTINE INFORMATION: - // AUTHOR Linda Lawrie - // DATE WRITTEN February 2000 - - // PURPOSE OF THIS SUBROUTINE: - // This subroutine verifies that a new name can be added to the - // list of names for this item (i.e., that there isn't one of that - // name already and that this name is not blank). - - ErrorFound = false; - if (NumOfNames > 0) { - int Found = FindItem(NameToVerify, NamesList, NumOfNames); - if (Found != 0) { - ShowSevereError(state, EnergyPlus::format("{}, duplicate name={}", StringToDisplay, NameToVerify)); - ErrorFound = true; - } - } - - if (NameToVerify.empty()) { - ShowSevereError(state, EnergyPlus::format("{}, cannot be blank", StringToDisplay)); - ErrorFound = true; - IsBlank = true; - } else { - IsBlank = false; - } - } - - bool IsNameEmpty(EnergyPlusData &state, std::string &NameToVerify, std::string_view StringToDisplay, bool &ErrorFound) - { - if (NameToVerify.empty()) { - ShowSevereError(state, EnergyPlus::format("{} Name, cannot be blank", StringToDisplay)); - ErrorFound = true; - NameToVerify = "xxxxx"; - return true; - } - return false; - } - void setDesignObjectNameAndPointer(EnergyPlusData &state, std::string &nameToBeSet, int &ptrToBeSet, diff --git a/src/EnergyPlus/UtilityRoutines.hh b/src/EnergyPlus/UtilityRoutines.hh index dee8fb91945..234573fcdaa 100644 --- a/src/EnergyPlus/UtilityRoutines.hh +++ b/src/EnergyPlus/UtilityRoutines.hh @@ -475,44 +475,6 @@ namespace Util { return Util::FindItemInList(String, ListOfItems, name_p, ListOfItems.isize()); } - int FindItemInSortedList(std::string_view const string, Array1S_string const ListOfItems, int NumItems); - - inline int FindItemInSortedList(std::string_view const String, Array1S_string const ListOfItems) - { - return FindItemInSortedList(String, ListOfItems, ListOfItems.isize()); - } - - template - inline int FindItemInSortedList(std::string_view const String, MArray1 const &ListOfItems, int const NumItems) - { - int Probe(0); - int LBnd(0); - int UBnd(NumItems + 1); - bool Found(false); - while ((!Found) || (Probe != 0)) { - Probe = (UBnd - LBnd) / 2; - if (Probe == 0) { - break; - } - Probe += LBnd; - if (equali(String, ListOfItems(Probe))) { - Found = true; - break; - } - if (lessthani(String, ListOfItems(Probe))) { - UBnd = Probe; - } else { - LBnd = Probe; - } - } - return Probe; - } - - template inline int FindItemInSortedList(std::string_view const String, MArray1 const &ListOfItems) - { - return FindItemInSortedList(String, ListOfItems, ListOfItems.isize()); - } - template inline int FindItem(InputIterator first, InputIterator last, std::string_view const str, std::false_type) { using valueType = typename std::iterator_traits::value_type; @@ -671,134 +633,6 @@ namespace Util { return equali(s, t); } - template - inline void VerifyName(EnergyPlusData &state, - InputIterator first, - InputIterator last, - std::string const &NameToVerify, - bool &ErrorFound, - bool &IsBlank, - std::string const &StringToDisplay) - { - IsBlank = false; - ErrorFound = false; - if (NameToVerify.empty()) { - ShowSevereError(state, StringToDisplay + ", cannot be blank"); - ErrorFound = true; - IsBlank = true; - return; - } - int Found = FindItem(first, last, NameToVerify); - if (Found != 0) { - ShowSevereError(state, StringToDisplay + ", duplicate name=" + NameToVerify); - ErrorFound = true; - } - } - - void VerifyName(EnergyPlusData &state, - std::string const &NameToVerify, - Array1D_string const &NamesList, - int const NumOfNames, - bool &ErrorFound, - bool &IsBlank, - std::string const &StringToDisplay); - - void VerifyName(EnergyPlusData &state, - std::string const &NameToVerify, - Array1S_string const NamesList, - int const NumOfNames, - bool &ErrorFound, - bool &IsBlank, - std::string const &StringToDisplay); - - template - inline void VerifyName(EnergyPlusData &state, - std::string const &NameToVerify, - MArray1 const &NamesList, - int const NumOfNames, - bool &ErrorFound, - bool &IsBlank, - std::string const &StringToDisplay) - { // Overload for member arrays: Implemented here to avoid copy to Array_string to forward to other VerifyName - ErrorFound = false; - if (NumOfNames > 0) { - int const Found = FindItem(NameToVerify, NamesList, - NumOfNames); // Calls FindItem overload that accepts member arrays - if (Found != 0) { - ShowSevereError(state, StringToDisplay + ", duplicate name=" + NameToVerify); - ErrorFound = true; - } - } - - if (NameToVerify.empty()) { - ShowSevereError(state, StringToDisplay + ", cannot be blank"); - ErrorFound = true; - IsBlank = true; - } else { - IsBlank = false; - } - } - - template ::value>::type> - // Container needs size() and operator[i] and elements need Name - inline void VerifyName(EnergyPlusData &state, - std::string const &NameToVerify, - Container const &NamesList, - int const NumOfNames, - bool &ErrorFound, - bool &IsBlank, - std::string const &StringToDisplay) - { - ErrorFound = false; - if (NumOfNames > 0) { - int const Found = FindItem(NameToVerify, NamesList, - NumOfNames); // Calls FindItem overload that accepts member arrays - if (Found != 0) { - ShowSevereError(state, StringToDisplay + ", duplicate name=" + NameToVerify); - ErrorFound = true; - } - } - - if (NameToVerify.empty()) { - ShowSevereError(state, StringToDisplay + ", cannot be blank"); - ErrorFound = true; - IsBlank = true; - } else { - IsBlank = false; - } - } - - template ::value>::type> - // Container needs size() and operator[i] and value_type - inline void VerifyName(EnergyPlusData &state, - std::string const &NameToVerify, - Container const &NamesList, - std::string Container::value_type::*name_p, - int const NumOfNames, - bool &ErrorFound, - bool &IsBlank, - std::string const &StringToDisplay) - { - ErrorFound = false; - if (NumOfNames > 0) { - int const Found = FindItem(NameToVerify, NamesList, name_p, NumOfNames); - if (Found != 0) { - ShowSevereError(state, StringToDisplay + ", duplicate name=" + NameToVerify); - ErrorFound = true; - } - } - - if (NameToVerify.empty()) { - ShowSevereError(state, StringToDisplay + ", cannot be blank"); - ErrorFound = true; - IsBlank = true; - } else { - IsBlank = false; - } - } - - bool IsNameEmpty(EnergyPlusData &state, std::string &NameToVerify, std::string_view StringToDisplay, bool &ErrorFound); - void setDesignObjectNameAndPointer(EnergyPlusData &state, std::string &nameToBeSet, // field that is being set once a match is found int &ptrToBeSet, // pointer that is being set once a match is found diff --git a/src/EnergyPlus/VentilatedSlab.cc b/src/EnergyPlus/VentilatedSlab.cc index c7112a32dc4..6f27649be1a 100644 --- a/src/EnergyPlus/VentilatedSlab.cc +++ b/src/EnergyPlus/VentilatedSlab.cc @@ -302,7 +302,6 @@ namespace VentilatedSlab { state.dataVentilatedSlab->VentSlabNumericFields(Item).FieldNames.allocate(NumNumbers); state.dataVentilatedSlab->VentSlabNumericFields(Item).FieldNames = cNumericFields; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), CurrentModuleObject, ErrorsFound); auto &ventSlab = state.dataVentilatedSlab->VentSlab(Item); ventSlab.Name = state.dataIPShortCut->cAlphaArgs(1); diff --git a/src/EnergyPlus/WaterCoils.cc b/src/EnergyPlus/WaterCoils.cc index 261ca7c455a..26ec1b1a829 100644 --- a/src/EnergyPlus/WaterCoils.cc +++ b/src/EnergyPlus/WaterCoils.cc @@ -307,7 +307,6 @@ void GetWaterCoilInput(EnergyPlusData &state) NumArray.dimension(MaxNums, 0.0); lAlphaBlanks.dimension(MaxAlphas, true); lNumericBlanks.dimension(MaxNums, true); - auto &cCurrentModuleObject = state.dataIPShortCut->cCurrentModuleObject; CurrentModuleObject = "Coil:Heating:Water"; // Get the data for simple heating coils for (SimpHeatNum = 1; SimpHeatNum <= NumSimpHeat; ++SimpHeatNum) { @@ -332,7 +331,6 @@ void GetWaterCoilInput(EnergyPlusData &state) state.dataWaterCoils->WaterCoilNumericFields(CoilNum).FieldNames.allocate(MaxNums); state.dataWaterCoils->WaterCoilNumericFields(CoilNum).FieldNames = ""; state.dataWaterCoils->WaterCoilNumericFields(CoilNum).FieldNames = cNumericFields; - Util::IsNameEmpty(state, AlphArray(1), cCurrentModuleObject, ErrorsFound); // ErrorsFound will be set to True if problem was found, left untouched otherwise GlobalNames::VerifyUniqueCoilName(state, CurrentModuleObject, AlphArray(1), ErrorsFound, CurrentModuleObject + " Name"); @@ -502,7 +500,6 @@ void GetWaterCoilInput(EnergyPlusData &state) state.dataWaterCoils->WaterCoilNumericFields(CoilNum).FieldNames.allocate(MaxNums); state.dataWaterCoils->WaterCoilNumericFields(CoilNum).FieldNames = ""; state.dataWaterCoils->WaterCoilNumericFields(CoilNum).FieldNames = cNumericFields; - Util::IsNameEmpty(state, AlphArray(1), cCurrentModuleObject, ErrorsFound); // ErrorsFound will be set to True if problem was found, left untouched otherwise GlobalNames::VerifyUniqueCoilName(state, CurrentModuleObject, AlphArray(1), ErrorsFound, CurrentModuleObject + " Name"); @@ -729,7 +726,6 @@ void GetWaterCoilInput(EnergyPlusData &state) state.dataWaterCoils->WaterCoilNumericFields(CoilNum).FieldNames.allocate(MaxNums); state.dataWaterCoils->WaterCoilNumericFields(CoilNum).FieldNames = ""; state.dataWaterCoils->WaterCoilNumericFields(CoilNum).FieldNames = cNumericFields; - Util::IsNameEmpty(state, AlphArray(1), cCurrentModuleObject, ErrorsFound); // ErrorsFound will be set to True if problem was found, left untouched otherwise GlobalNames::VerifyUniqueCoilName(state, CurrentModuleObject, AlphArray(1), ErrorsFound, CurrentModuleObject + " Name"); diff --git a/src/EnergyPlus/WaterManager.cc b/src/EnergyPlus/WaterManager.cc index 52464654dca..3ced33e4a1b 100644 --- a/src/EnergyPlus/WaterManager.cc +++ b/src/EnergyPlus/WaterManager.cc @@ -270,7 +270,6 @@ namespace WaterManager { state.dataWaterData->AnyWaterSystemsInModel = true; state.dataWaterData->WaterStorage(Item).Name = cAlphaArgs(1); - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); state.dataWaterData->WaterStorage(Item).QualitySubCategoryName = cAlphaArgs(2); @@ -420,7 +419,6 @@ namespace WaterManager { ErrorObjectHeader eoh{routineName, cCurrentModuleObject, cAlphaArgs(1)}; state.dataWaterData->RainCollector(Item).Name = cAlphaArgs(1); - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); state.dataWaterData->RainCollector(Item).StorageTankName = cAlphaArgs(2); state.dataWaterData->RainCollector(Item).StorageTankID = Util::FindItemInList(cAlphaArgs(2), state.dataWaterData->WaterStorage); @@ -535,7 +533,7 @@ namespace WaterManager { ErrorObjectHeader eoh{routineName, cCurrentModuleObject, cAlphaArgs(1)}; state.dataWaterData->GroundwaterWell(Item).Name = cAlphaArgs(1); - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); + state.dataWaterData->GroundwaterWell(Item).StorageTankName = cAlphaArgs(2); InternalSetupTankSupplyComponent(state, diff --git a/src/EnergyPlus/WaterThermalTanks.cc b/src/EnergyPlus/WaterThermalTanks.cc index 6697509abb0..2656647b5a2 100644 --- a/src/EnergyPlus/WaterThermalTanks.cc +++ b/src/EnergyPlus/WaterThermalTanks.cc @@ -709,8 +709,6 @@ bool getDesuperHtrInput(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, cCurrentModuleObject, cAlphaArgs(1)}; - Util::IsNameEmpty(state, cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); - // ErrorsFound will be set to True if problem was found, left untouched otherwise GlobalNames::VerifyUniqueCoilName(state, cCurrentModuleObject, cAlphaArgs(1), ErrorsFound, cCurrentModuleObject + " Name"); @@ -1238,7 +1236,6 @@ bool getHPWaterHeaterInput(EnergyPlusData &state) for (int i = NumAlphas + 1; i <= nNumPossibleAlphaArgs; ++i) { hpwhAlphaBlank[i] = true; } - Util::IsNameEmpty(state, hpwhAlpha[1], state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); // Name and type HPWH.Name = hpwhAlpha[1]; diff --git a/src/EnergyPlus/WaterUse.cc b/src/EnergyPlus/WaterUse.cc index c892b935ea9..27b230a202c 100644 --- a/src/EnergyPlus/WaterUse.cc +++ b/src/EnergyPlus/WaterUse.cc @@ -322,7 +322,7 @@ namespace WaterUse { state.dataIPShortCut->cNumericFieldNames); ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); + thisWEq.Name = state.dataIPShortCut->cAlphaArgs(1); thisWEq.EndUseSubcatName = state.dataIPShortCut->cAlphaArgs(2); @@ -401,7 +401,6 @@ namespace WaterUse { ErrorObjectHeader eoh{routineName, state.dataIPShortCut->cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), state.dataIPShortCut->cCurrentModuleObject, ErrorsFound); auto &waterConnection = state.dataWaterUse->WaterConnections(WaterConnNum); waterConnection.Name = state.dataIPShortCut->cAlphaArgs(1); diff --git a/src/EnergyPlus/WindTurbine.cc b/src/EnergyPlus/WindTurbine.cc index 3d064365664..710789a0255 100644 --- a/src/EnergyPlus/WindTurbine.cc +++ b/src/EnergyPlus/WindTurbine.cc @@ -255,8 +255,6 @@ namespace WindTurbine { ErrorObjectHeader eoh{routineName, CurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), CurrentModuleObject, ErrorsFound); - auto &windTurbine = state.dataWindTurbine->WindTurbineSys(WindTurbineNum); windTurbine.Name = state.dataIPShortCut->cAlphaArgs(1); // Name of wind turbine diff --git a/src/EnergyPlus/WindowAC.cc b/src/EnergyPlus/WindowAC.cc index b4e84289670..baa404b7417 100644 --- a/src/EnergyPlus/WindowAC.cc +++ b/src/EnergyPlus/WindowAC.cc @@ -294,7 +294,6 @@ namespace WindowAC { state.dataWindowAC->WindACNumericFields(WindACNum).FieldNames.allocate(NumNumbers); state.dataWindowAC->WindACNumericFields(WindACNum).FieldNames = ""; state.dataWindowAC->WindACNumericFields(WindACNum).FieldNames = cNumericFields; - Util::IsNameEmpty(state, Alphas(1), CurrentModuleObject, ErrorsFound); state.dataWindowAC->WindAC(WindACNum).Name = Alphas(1); state.dataWindowAC->WindAC(WindACNum).UnitType = state.dataWindowAC->WindowAC_UnitType; // 'ZoneHVAC:WindowAirConditioner' diff --git a/src/EnergyPlus/ZoneAirLoopEquipmentManager.cc b/src/EnergyPlus/ZoneAirLoopEquipmentManager.cc index bfafa28e575..126dba64c2e 100644 --- a/src/EnergyPlus/ZoneAirLoopEquipmentManager.cc +++ b/src/EnergyPlus/ZoneAirLoopEquipmentManager.cc @@ -251,7 +251,6 @@ namespace ZoneAirLoopEquipmentManager { lAlphaBlanks, cAlphaFields, cNumericFields); // data for one zone - Util::IsNameEmpty(state, AlphArray(1), CurrentModuleObject, ErrorsFound); airDistUnit.Name = AlphArray(1); // Input Outlet Node Num diff --git a/src/EnergyPlus/ZoneContaminantPredictorCorrector.cc b/src/EnergyPlus/ZoneContaminantPredictorCorrector.cc index f2a9a614802..b90d5fcfe34 100644 --- a/src/EnergyPlus/ZoneContaminantPredictorCorrector.cc +++ b/src/EnergyPlus/ZoneContaminantPredictorCorrector.cc @@ -240,8 +240,6 @@ void GetZoneContaminanInputs(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, AlphaName(1)}; - Util::IsNameEmpty(state, AlphaName(1), CurrentModuleObject, ErrorsFound); - auto &contam = state.dataContaminantBalance->ZoneContamGenericConstant(Loop); contam.Name = AlphaName(1); contam.ZoneName = AlphaName(2); @@ -342,8 +340,6 @@ void GetZoneContaminanInputs(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, AlphaName(1)}; - Util::IsNameEmpty(state, AlphaName(1), CurrentModuleObject, ErrorsFound); - auto &contam = state.dataContaminantBalance->ZoneContamGenericPDriven(Loop); contam.Name = AlphaName(1); @@ -477,8 +473,6 @@ void GetZoneContaminanInputs(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, AlphaName(1)}; - Util::IsNameEmpty(state, AlphaName(1), CurrentModuleObject, ErrorsFound); - auto &contam = state.dataContaminantBalance->ZoneContamGenericCutoff(Loop); contam.Name = AlphaName(1); @@ -588,7 +582,6 @@ void GetZoneContaminanInputs(EnergyPlusData &state) auto &contam = state.dataContaminantBalance->ZoneContamGenericDecay(Loop); - Util::IsNameEmpty(state, AlphaName(1), CurrentModuleObject, ErrorsFound); contam.Name = AlphaName(1); contam.ZoneName = AlphaName(2); @@ -702,8 +695,6 @@ void GetZoneContaminanInputs(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, AlphaName(1)}; - Util::IsNameEmpty(state, AlphaName(1), CurrentModuleObject, ErrorsFound); - auto &contam = state.dataContaminantBalance->ZoneContamGenericBLDiff(Loop); contam.Name = AlphaName(1); contam.SurfName = AlphaName(2); @@ -818,7 +809,6 @@ void GetZoneContaminanInputs(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, AlphaName(1)}; - Util::IsNameEmpty(state, AlphaName(1), CurrentModuleObject, ErrorsFound); auto &contam = state.dataContaminantBalance->ZoneContamGenericDVS(Loop); contam.Name = AlphaName(1); @@ -914,8 +904,6 @@ void GetZoneContaminanInputs(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, CurrentModuleObject, AlphaName(1)}; - Util::IsNameEmpty(state, AlphaName(1), CurrentModuleObject, ErrorsFound); - auto &contam = state.dataContaminantBalance->ZoneContamGenericDRS(Loop); contam.Name = AlphaName(1); @@ -1068,8 +1056,6 @@ void GetZoneContaminanSetPoints(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, cCurrentModuleObject, state.dataIPShortCut->cAlphaArgs(1)}; - Util::IsNameEmpty(state, state.dataIPShortCut->cAlphaArgs(1), cCurrentModuleObject, ErrorsFound); - auto &controlledZone = state.dataContaminantBalance->ContaminantControlledZone(ContControlledZoneNum); controlledZone.Name = state.dataIPShortCut->cAlphaArgs(1); controlledZone.ZoneName = state.dataIPShortCut->cAlphaArgs(2); diff --git a/src/EnergyPlus/ZonePlenum.cc b/src/EnergyPlus/ZonePlenum.cc index 43f1b9532a3..7569f1fc4ed 100644 --- a/src/EnergyPlus/ZonePlenum.cc +++ b/src/EnergyPlus/ZonePlenum.cc @@ -295,7 +295,6 @@ void GetZonePlenumInput(EnergyPlusData &state) lAlphaBlanks, cAlphaFields, cNumericFields); - Util::IsNameEmpty(state, AlphArray(1), CurrentModuleObject, ErrorsFound); auto &thisRetPlenum = state.dataZonePlenum->ZoneRetPlenCond(ZonePlenumNum); thisRetPlenum.ZonePlenumName = AlphArray(1); @@ -482,7 +481,6 @@ void GetZonePlenumInput(EnergyPlusData &state) lAlphaBlanks, cAlphaFields, cNumericFields); - Util::IsNameEmpty(state, AlphArray(1), CurrentModuleObject, ErrorsFound); auto &thisSupPlenum = state.dataZonePlenum->ZoneSupPlenCond(ZonePlenumNum); thisSupPlenum.ZonePlenumName = AlphArray(1); diff --git a/src/EnergyPlus/ZoneTempPredictorCorrector.cc b/src/EnergyPlus/ZoneTempPredictorCorrector.cc index 1546cbe981e..ca3e024b17e 100644 --- a/src/EnergyPlus/ZoneTempPredictorCorrector.cc +++ b/src/EnergyPlus/ZoneTempPredictorCorrector.cc @@ -343,7 +343,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) s_ipsc->cNumericFieldNames); ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); TStatObjects(Item).Name = s_ipsc->cAlphaArgs(1); Item1 = Util::FindItemInList(s_ipsc->cAlphaArgs(2), Zone); @@ -542,7 +541,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); auto &setpt = s_ztpc->tempSetptScheds[(int)HVAC::SetptType::SingleHeat](idx); setpt.Name = s_ipsc->cAlphaArgs(1); @@ -579,7 +577,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); auto &setpt = s_ztpc->tempSetptScheds[(int)HVAC::SetptType::SingleCool](idx); setpt.Name = s_ipsc->cAlphaArgs(1); @@ -651,7 +648,7 @@ void GetZoneAirSetPoints(EnergyPlusData &state) s_ipsc->cNumericFieldNames); ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); + auto &setpt = s_ztpc->tempSetptScheds[(int)HVAC::SetptType::DualHeatCool](idx); setpt.Name = s_ipsc->cAlphaArgs(1); @@ -834,8 +831,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); - auto &humidControlledZone = state.dataZoneCtrls->HumidityControlZone(HumidControlledZoneNum); humidControlledZone.ControlName = s_ipsc->cAlphaArgs(1); GlobalNames::IntraObjUniquenessCheck(state, @@ -897,7 +892,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) s_ipsc->lAlphaFieldBlanks, s_ipsc->cAlphaFieldNames, s_ipsc->cNumericFieldNames); - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); Item1 = Util::FindItemInList(s_ipsc->cAlphaArgs(2), Zone); ZLItem = 0; @@ -1192,7 +1186,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); auto &setpt = s_ztpc->comfortSetptScheds[(int)HVAC::SetptType::SingleHeat](idx); setpt.Name = s_ipsc->cAlphaArgs(1); @@ -1231,7 +1224,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); auto &setpt = s_ztpc->comfortSetptScheds[(int)HVAC::SetptType::SingleCool](idx); setpt.Name = s_ipsc->cAlphaArgs(1); @@ -1271,7 +1263,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); auto &setpt = s_ztpc->comfortSetptScheds[(int)HVAC::SetptType::SingleHeatCool](idx); setpt.Name = s_ipsc->cAlphaArgs(1); @@ -1311,7 +1302,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) ErrorObjectHeader eoh{routineName, s_ipsc->cCurrentModuleObject, s_ipsc->cAlphaArgs(1)}; - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); auto &setpt = s_ztpc->comfortSetptScheds[(int)HVAC::SetptType::DualHeatCool](idx); setpt.Name = s_ipsc->cAlphaArgs(1); @@ -1948,7 +1938,6 @@ void GetZoneAirSetPoints(EnergyPlusData &state) s_ipsc->lAlphaFieldBlanks, s_ipsc->cAlphaFieldNames, s_ipsc->cNumericFieldNames); - Util::IsNameEmpty(state, s_ipsc->cAlphaArgs(1), s_ipsc->cCurrentModuleObject, ErrorsFound); state.dataZoneCtrls->StagedTStatObjects(Item).Name = s_ipsc->cAlphaArgs(1); Item1 = Util::FindItemInList(s_ipsc->cAlphaArgs(2), Zone); diff --git a/tst/EnergyPlus/unit/BranchInputManager.unit.cc b/tst/EnergyPlus/unit/BranchInputManager.unit.cc index d9b1b21b5b7..753bbfa4916 100644 --- a/tst/EnergyPlus/unit/BranchInputManager.unit.cc +++ b/tst/EnergyPlus/unit/BranchInputManager.unit.cc @@ -91,8 +91,6 @@ TEST_F(EnergyPlusFixture, GetBranchInput_One_SingleComponentBranch) int NumParams; int NumAlphas; // Used to retrieve names from IDF int NumNumbers; // Used to retrieve numbers from IDF - bool IsNotOK; // Flag to verify name - bool IsBlank; // Flag for blank name Array1D_string Alphas; // Used to retrieve names from IDF Array1D_int NodeNums; // Possible Array of Node Numbers (only 1 allowed) Array1D Numbers; // Used to retrieve numbers from IDF @@ -131,15 +129,6 @@ TEST_F(EnergyPlusFixture, GetBranchInput_One_SingleComponentBranch) lAlphaBlanks, cAlphaFields, cNumericFields); - IsNotOK = false; - IsBlank = false; - Util::VerifyName(*state, Alphas(1), state->dataBranchInputManager->Branch, BCount, IsNotOK, IsBlank, CurrentModuleObject + " Name"); - if (IsNotOK) { - if (IsBlank) { - continue; - } - Alphas(1) = Alphas(1) + "--dup"; - } ++BCount; GetSingleBranchInput(*state, RoutineName, BCount, Alphas, cAlphaFields, NumAlphas, NodeNums, lAlphaBlanks); @@ -256,8 +245,6 @@ TEST_F(EnergyPlusFixture, GetBranchInput_One_FourComponentBranch) int NumParams; int NumAlphas; // Used to retrieve names from IDF int NumNumbers; // Used to retrieve numbers from IDF - bool IsNotOK; // Flag to verify name - bool IsBlank; // Flag for blank name Array1D_string Alphas; // Used to retrieve names from IDF Array1D_int NodeNums; // Possible Array of Node Numbers (only 1 allowed) Array1D Numbers; // Used to retrieve numbers from IDF @@ -296,15 +283,7 @@ TEST_F(EnergyPlusFixture, GetBranchInput_One_FourComponentBranch) lAlphaBlanks, cAlphaFields, cNumericFields); - IsNotOK = false; - IsBlank = false; - Util::VerifyName(*state, Alphas(1), state->dataBranchInputManager->Branch, BCount, IsNotOK, IsBlank, CurrentModuleObject + " Name"); - if (IsNotOK) { - if (IsBlank) { - continue; - } - Alphas(1) = Alphas(1) + "--dup"; - } + ++BCount; GetSingleBranchInput(*state, RoutineName, BCount, Alphas, cAlphaFields, NumAlphas, NodeNums, lAlphaBlanks); diff --git a/tst/EnergyPlus/unit/PlantPipingSystemsManager.unit.cc b/tst/EnergyPlus/unit/PlantPipingSystemsManager.unit.cc index df287851223..52cd664f4ab 100644 --- a/tst/EnergyPlus/unit/PlantPipingSystemsManager.unit.cc +++ b/tst/EnergyPlus/unit/PlantPipingSystemsManager.unit.cc @@ -133,7 +133,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_CorrectInputs) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -203,7 +203,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadOSCMName) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -273,7 +273,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadSlabLocation) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -343,7 +343,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadSlabMaterialName) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -413,7 +413,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadHorizInsSelection) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -483,7 +483,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadHorizInsMaterialNa bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -553,7 +553,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadHorizInsExtentsSel bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -623,7 +623,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_PerimeterInsulationWi bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -693,7 +693,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadVertInsSelection) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -763,7 +763,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadVertInsMaterialNam bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -833,7 +833,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadVertInsDepth) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -904,7 +904,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_CheckInputs_BadTimeStepSelection) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -975,7 +975,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_CorrectInputs) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1045,7 +1045,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_BadOSCMName) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1115,7 +1115,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_BadHorizInsSelect bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1185,7 +1185,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_BadHorizInsMateri bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1255,7 +1255,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_BadHorizInsExtent bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1325,7 +1325,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_BadBasementDepth) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1395,7 +1395,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_BadFloorOSCMName) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1465,7 +1465,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_BadVertInsSelecti bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1535,7 +1535,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_BadVertInsName) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1606,7 +1606,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainBasement_CheckInputs_BadTimestepSelect bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -1762,7 +1762,7 @@ TEST_F(EnergyPlusFixture, PipingSystemFullSimulation) // Other necessary inputs bool errorsFound = false; - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); // first call the factory, it will call GetInput @@ -2052,7 +2052,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_Fix_HorizInsDepth) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -2180,7 +2180,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_Fix_HorizInsDepth_Test2) bool errorsFound = false; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); @@ -2317,7 +2317,7 @@ TEST_F(EnergyPlusFixture, SiteGroundDomainSlab_FiniteDifference) state->dataSurface->Surface(1).Area = 100; // Other necessary inputs - GetOSCMData(*state, errorsFound); + GetOSCMData(*state); GetMaterialData(*state, errorsFound); state->dataPlantPipingSysMgr->domains.resize(1); diff --git a/tst/EnergyPlus/unit/WeatherManager.unit.cc b/tst/EnergyPlus/unit/WeatherManager.unit.cc index d62fed06c12..df1f1b7b093 100644 --- a/tst/EnergyPlus/unit/WeatherManager.unit.cc +++ b/tst/EnergyPlus/unit/WeatherManager.unit.cc @@ -338,7 +338,7 @@ TEST_F(EnergyPlusFixture, UnderwaterBoundaryConditionFullyPopulated) // need to populate the OSCM array by calling the get input for it bool errorsFound = false; - SurfaceGeometry::GetOSCMData(*state, errorsFound); + SurfaceGeometry::GetOSCMData(*state); EXPECT_FALSE(errorsFound); EXPECT_EQ(state->dataSurface->TotOSCM, 1); @@ -363,7 +363,7 @@ TEST_F(EnergyPlusFixture, UnderwaterBoundaryConditionMissingVelocityOK) // need to populate the OSCM array by calling the get input for it bool errorsFound = false; - SurfaceGeometry::GetOSCMData(*state, errorsFound); + SurfaceGeometry::GetOSCMData(*state); EXPECT_FALSE(errorsFound); EXPECT_EQ(state->dataSurface->TotOSCM, 1);