From c6471c79c596fa9e1648e99d32152e5cc6234c1c Mon Sep 17 00:00:00 2001 From: LipingWang Date: Thu, 5 Mar 2026 19:20:39 -0700 Subject: [PATCH 1/7] Remove the constraint of leaf area index (LAI) for indoorlivingwall module including both IndoorGreen.cc code and EnergyPlus references. --- .../indoor-living-wall.tex | 16 +++++++++------- .../group-internal-gains-people-lights-other.tex | 2 +- src/EnergyPlus/IndoorGreen.cc | 7 +------ 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex b/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex index 8b377c82403..6db0ee5a2ec 100644 --- a/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex +++ b/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex @@ -171,14 +171,16 @@ \subsection{Evapotranspiration from indoor living wall}\label{evaporation-from-i \subsection{References}\label{references-indoorlivingwall} -Wang, L. and M.J. Witte (2022). Integrating building energy simulation with a machine learning algorithm for evaluating indoor living walls’ impacts on cooling energy use in commercial buildings. Energy and Buildings 272, p. 112322. - - Monteith, J.L. (1965). Evaporation and environment. in Symposia of the society for experimental biology. Cambridge University Press (CUP) Cambridge. - + Ball, J.T., I.E. Woodrow, and J.A. Berry (1987). A model predicting stomatal conductance and its contribution to the control of photosynthesis under different environmental conditions, Photosynthesis Research, Springer. p. 221-224. + Graamans, L., et al. (2017) Plant factories; crop transpiration and energy balance. Agricultural Systems. 153, p. 138-147. - Wang, L., E. Iddio, and B. Ewers (2021). Introductory overview: Evapotranspiration (ET) models for controlled environment agriculture (CEA). Computers and Electronics in Agriculture 190, p. 106447. - Jarvis, P. (1976). The interpretation of the variations in leaf water potential and stomatal conductance found in canopies in the field.Philosophical Transactions of the Royal Society of London. Series B, 273(927), p. 593-610. - Ball, J.T., I.E. Woodrow, and J.A. Berry (1987). A model predicting stomatal conductance and its contribution to the control of photosynthesis under different environmental conditions, in Progress in photosynthesis research, Springer. p. 221-224. + Monteith, J.L. (1965). Evaporation and environment. in Symposia of the society for experimental biology. Cambridge University Press (CUP) Cambridge. + + Wang, L., L. Norford, M. J. Witte (2025). Modeling Thermal Impacts of Indoor Living Plants in the Built Environment. Energy and Building. 2025. Volume 346, 116113. + + Wang, L. and M.J. Witte (2022). Integrating building energy simulation with a machine learning algorithm for evaluating indoor living walls’ impacts on cooling energy use in commercial buildings. Energy and Buildings 272, p. 112322. + + Wang, L., E. Iddio, and B. Ewers (2021). Introductory overview: Evapotranspiration (ET) models for controlled environment agriculture (CEA). Computers and Electronics in Agriculture 190, p. 106447. \ No newline at end of file diff --git a/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex b/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex index cdafed330c8..18d8958578b 100644 --- a/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex +++ b/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex @@ -2381,7 +2381,7 @@ \subsubsection{Inputs}\label{inputs-indoorlivingwall} \paragraph{Field: Total Leaf Area}\label{field-total-leaf-area-indoorlivingwall} -This field is the estimated one-sided leaf area {[}\si{\area}{]} of an indoor living wall. Based on the users’ input, leaf area index (LAI) is calculated as the ratio of the total leaf area and the partition wall area. Typical LAIs are 1.0 for grass and 3.0 for bushes and shrubs. The maximum LAI is 2.0 for the IndoorLivingWall module in EnergyPlus. If the calculated LAI is greater than 2.0, the maximum value of 2.0 is used for LAI in the simulation. +This field is the estimated one-sided leaf area {[}\si{\area}{]} of an indoor living wall. Based on the users’ input, leaf area index (LAI) is calculated as the ratio of the total leaf area and the partition wall area. Typical LAIs are 1.0 for grass and 3.0 for bushes and shrubs. \paragraph{Field: LED Nominal Intensity}\label{field-led-nominal-intensity-indoorlivingwall} diff --git a/src/EnergyPlus/IndoorGreen.cc b/src/EnergyPlus/IndoorGreen.cc index e929bbe14f6..10d591bbfc2 100644 --- a/src/EnergyPlus/IndoorGreen.cc +++ b/src/EnergyPlus/IndoorGreen.cc @@ -426,7 +426,7 @@ namespace IndoorGreen { Real64 HCons; // enthalpy (J/kg) Real64 HMid; // enthalpy 3rd point (J/kg) Real64 ZoneAirVol; // zone air volume (m3) - Real64 LAI; // leaf area index, the ratio of one-side leaf area per unit plant growing area, maximum LAI =2 if LAI_cal>2.0 + Real64 LAI; // leaf area index, the ratio of one-side leaf area per unit plant growing area Real64 LAI_Cal; // calculated leaf area index based on users's input on total leaf area Real64 OutPb; // outdoor pressure (kPa) Real64 vp; // actual vapor pressure of the air (kpa) @@ -444,11 +444,6 @@ namespace IndoorGreen { ig.ZVPD = (vpSat - vp) * 1000; // Pa LAI_Cal = ig.LeafArea / state.dataSurface->Surface(ig.SurfPtr).Area; LAI = LAI_Cal; - if (LAI_Cal > 2.0) { - LAI = 2.0; // maximum LAI=2.0 in the surface heat balance - ShowSevereError(state, - EnergyPlus::format("Maximum indoor living wall leaf area index (LAI) =2.0 is used,calculated LAI is {}", LAI_Cal)); - } switch (ig.lightingMethod) { case LightingMethod::LED: { ig.ZPPFD = ig.ledSched->getCurrentVal() * ig.LEDNominalPPFD; // PPFD From ab09e049aa8b4ff5656c8770718690ef56e92ff5 Mon Sep 17 00:00:00 2001 From: LipingWang Date: Fri, 6 Mar 2026 17:42:45 -0700 Subject: [PATCH 2/7] format update for references --- .../indoor-living-wall.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex b/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex index 6db0ee5a2ec..cef25544d9f 100644 --- a/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex +++ b/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex @@ -171,7 +171,7 @@ \subsection{Evapotranspiration from indoor living wall}\label{evaporation-from-i \subsection{References}\label{references-indoorlivingwall} - Ball, J.T., I.E. Woodrow, and J.A. Berry (1987). A model predicting stomatal conductance and its contribution to the control of photosynthesis under different environmental conditions, Photosynthesis Research, Springer. p. 221-224. + Ball, J.T., I.E. Woodrow, and J.A. Berry (1987). A model predicting stomatal conductance and its contribution to the control of photosynthesis under different environmental conditions, Photosynthesis Research, Springer. p. 221-224. Graamans, L., et al. (2017) Plant factories; crop transpiration and energy balance. Agricultural Systems. 153, p. 138-147. From 5f8ecf4142491ff26cd83bff65939797cfc16ab6 Mon Sep 17 00:00:00 2001 From: LipingWang Date: Fri, 6 Mar 2026 17:55:53 -0700 Subject: [PATCH 3/7] update format for references --- .../indoor-living-wall.tex | 8 ++++---- .../overview/group-internal-gains-people-lights-other.tex | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex b/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex index cef25544d9f..b48258ef653 100644 --- a/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex +++ b/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex @@ -172,15 +172,15 @@ \subsection{Evapotranspiration from indoor living wall}\label{evaporation-from-i \subsection{References}\label{references-indoorlivingwall} Ball, J.T., I.E. Woodrow, and J.A. Berry (1987). A model predicting stomatal conductance and its contribution to the control of photosynthesis under different environmental conditions, Photosynthesis Research, Springer. p. 221-224. - + Graamans, L., et al. (2017) Plant factories; crop transpiration and energy balance. Agricultural Systems. 153, p. 138-147. Jarvis, P. (1976). The interpretation of the variations in leaf water potential and stomatal conductance found in canopies in the field.Philosophical Transactions of the Royal Society of London. Series B, 273(927), p. 593-610. Monteith, J.L. (1965). Evaporation and environment. in Symposia of the society for experimental biology. Cambridge University Press (CUP) Cambridge. - - Wang, L., L. Norford, M. J. Witte (2025). Modeling Thermal Impacts of Indoor Living Plants in the Built Environment. Energy and Building. 2025. Volume 346, 116113. - + + Wang, L., L. Norford, M. J. Witte (2025). Modeling Thermal Impacts of Indoor Living Plants in the Built Environment. Energy and Building. 2025. Volume 346, 116113. + Wang, L. and M.J. Witte (2022). Integrating building energy simulation with a machine learning algorithm for evaluating indoor living walls’ impacts on cooling energy use in commercial buildings. Energy and Buildings 272, p. 112322. Wang, L., E. Iddio, and B. Ewers (2021). Introductory overview: Evapotranspiration (ET) models for controlled environment agriculture (CEA). Computers and Electronics in Agriculture 190, p. 106447. \ No newline at end of file diff --git a/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex b/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex index 18d8958578b..e533041d994 100644 --- a/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex +++ b/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex @@ -2381,7 +2381,7 @@ \subsubsection{Inputs}\label{inputs-indoorlivingwall} \paragraph{Field: Total Leaf Area}\label{field-total-leaf-area-indoorlivingwall} -This field is the estimated one-sided leaf area {[}\si{\area}{]} of an indoor living wall. Based on the users’ input, leaf area index (LAI) is calculated as the ratio of the total leaf area and the partition wall area. Typical LAIs are 1.0 for grass and 3.0 for bushes and shrubs. +This field is the estimated one-sided leaf area {[}\si{\area}{]} of an indoor living wall. Based on the users’ input, leaf area index (LAI) is calculated as the ratio of the total leaf area and the partition wall area. Typical LAIs are 1.0 for grass and 3.0 for bushes and shrubs. \paragraph{Field: LED Nominal Intensity}\label{field-led-nominal-intensity-indoorlivingwall} From 4a1de65a796d12d7e7bdc6fd305d3c6f7f18bef6 Mon Sep 17 00:00:00 2001 From: LipingWang Date: Fri, 6 Mar 2026 18:18:17 -0700 Subject: [PATCH 4/7] update format for references insert final newline --- .../indoor-living-wall.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex b/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex index b48258ef653..6e15d60461c 100644 --- a/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex +++ b/doc/engineering-reference/src/simulation-models-encyclopedic-reference-003/indoor-living-wall.tex @@ -183,4 +183,4 @@ \subsection{References}\label{references-indoorlivingwall} Wang, L. and M.J. Witte (2022). Integrating building energy simulation with a machine learning algorithm for evaluating indoor living walls’ impacts on cooling energy use in commercial buildings. Energy and Buildings 272, p. 112322. - Wang, L., E. Iddio, and B. Ewers (2021). Introductory overview: Evapotranspiration (ET) models for controlled environment agriculture (CEA). Computers and Electronics in Agriculture 190, p. 106447. \ No newline at end of file + Wang, L., E. Iddio, and B. Ewers (2021). Introductory overview: Evapotranspiration (ET) models for controlled environment agriculture (CEA). Computers and Electronics in Agriculture 190, p. 106447. From 3bc0a8a79e757cf05c5f1cad2b276385c1c3a9c1 Mon Sep 17 00:00:00 2001 From: LipingWang Date: Fri, 6 Mar 2026 18:35:22 -0700 Subject: [PATCH 5/7] Clang-format --- src/EnergyPlus/IndoorGreen.cc | 42 +++++++++++++++++------------------ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/EnergyPlus/IndoorGreen.cc b/src/EnergyPlus/IndoorGreen.cc index 10d591bbfc2..26e8ee234a3 100644 --- a/src/EnergyPlus/IndoorGreen.cc +++ b/src/EnergyPlus/IndoorGreen.cc @@ -410,27 +410,27 @@ namespace IndoorGreen { // SUBROUTINE PARAMETER DEFINITIONS: static constexpr std::string_view RoutineName("ETModel: "); auto &lw = state.dataIndoorGreen; - Real64 ZonePreTemp; // Indoor air temperature (C) - Real64 ZonePreHum; // Indoor humidity ratio (kg moisture / kg dry air) - Real64 ZoneNewTemp; // Indoor air temperature (C) after ET - Real64 ZoneNewHum; // Indoor humidity ratio (kg moisture / kg dry air) after ET - Real64 ZoneSatHum; // Saturated humidity ratio - Real64 ZoneCO2; // Indoor zone co2 concentration (ppm) - Real64 ZonePPFD; // Indoor net radiation (PPFD) - Real64 ZoneVPD; // vapor pressure deficit (kpa); local variable - Real64 Timestep; // s - Real64 ETTotal; // kg - Real64 rhoair; // kg/m3 - Real64 Tdp; // dew point temperature - Real64 Twb; // wet bulb temperature - Real64 HCons; // enthalpy (J/kg) - Real64 HMid; // enthalpy 3rd point (J/kg) - Real64 ZoneAirVol; // zone air volume (m3) - Real64 LAI; // leaf area index, the ratio of one-side leaf area per unit plant growing area - Real64 LAI_Cal; // calculated leaf area index based on users's input on total leaf area - Real64 OutPb; // outdoor pressure (kPa) - Real64 vp; // actual vapor pressure of the air (kpa) - Real64 vpSat; // saturated vapor pressure at air temperature (kpa) + Real64 ZonePreTemp; // Indoor air temperature (C) + Real64 ZonePreHum; // Indoor humidity ratio (kg moisture / kg dry air) + Real64 ZoneNewTemp; // Indoor air temperature (C) after ET + Real64 ZoneNewHum; // Indoor humidity ratio (kg moisture / kg dry air) after ET + Real64 ZoneSatHum; // Saturated humidity ratio + Real64 ZoneCO2; // Indoor zone co2 concentration (ppm) + Real64 ZonePPFD; // Indoor net radiation (PPFD) + Real64 ZoneVPD; // vapor pressure deficit (kpa); local variable + Real64 Timestep; // s + Real64 ETTotal; // kg + Real64 rhoair; // kg/m3 + Real64 Tdp; // dew point temperature + Real64 Twb; // wet bulb temperature + Real64 HCons; // enthalpy (J/kg) + Real64 HMid; // enthalpy 3rd point (J/kg) + Real64 ZoneAirVol; // zone air volume (m3) + Real64 LAI; // leaf area index, the ratio of one-side leaf area per unit plant growing area + Real64 LAI_Cal; // calculated leaf area index based on users's input on total leaf area + Real64 OutPb; // outdoor pressure (kPa) + Real64 vp; // actual vapor pressure of the air (kpa) + Real64 vpSat; // saturated vapor pressure at air temperature (kpa) Timestep = state.dataHVACGlobal->TimeStepSysSec; // unit s for (int IndoorGreenNum = 1; IndoorGreenNum <= lw->NumIndoorGreen; ++IndoorGreenNum) { auto &ig = lw->indoorGreens(IndoorGreenNum); From e71d6aa36f52d8189ea6a2fc72117dda1465d618 Mon Sep 17 00:00:00 2001 From: LipingWang Date: Wed, 11 Mar 2026 14:47:49 -0600 Subject: [PATCH 6/7] Update the limit for leaf area index --- src/EnergyPlus/IndoorGreen.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/EnergyPlus/IndoorGreen.cc b/src/EnergyPlus/IndoorGreen.cc index 26e8ee234a3..eebe5e536e3 100644 --- a/src/EnergyPlus/IndoorGreen.cc +++ b/src/EnergyPlus/IndoorGreen.cc @@ -444,6 +444,11 @@ namespace IndoorGreen { ig.ZVPD = (vpSat - vp) * 1000; // Pa LAI_Cal = ig.LeafArea / state.dataSurface->Surface(ig.SurfPtr).Area; LAI = LAI_Cal; + if (LAI_Cal > 10.0) { + LAI = 10.0; + ShowSevereError(state, + EnergyPlus::format("Maximum indoor living wall leaf area index (LAI) =10.0 is used,calculated LAI is {}", LAI_Cal)); + } switch (ig.lightingMethod) { case LightingMethod::LED: { ig.ZPPFD = ig.ledSched->getCurrentVal() * ig.LEDNominalPPFD; // PPFD From 00374d6861f7f584ddfb2a73862763873bb9bea2 Mon Sep 17 00:00:00 2001 From: LipingWang Date: Thu, 12 Mar 2026 17:27:52 -0600 Subject: [PATCH 7/7] I/O reference update --- .../src/overview/group-internal-gains-people-lights-other.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex b/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex index e533041d994..4b5ce0a24ed 100644 --- a/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex +++ b/doc/input-output-reference/src/overview/group-internal-gains-people-lights-other.tex @@ -2381,7 +2381,7 @@ \subsubsection{Inputs}\label{inputs-indoorlivingwall} \paragraph{Field: Total Leaf Area}\label{field-total-leaf-area-indoorlivingwall} -This field is the estimated one-sided leaf area {[}\si{\area}{]} of an indoor living wall. Based on the users’ input, leaf area index (LAI) is calculated as the ratio of the total leaf area and the partition wall area. Typical LAIs are 1.0 for grass and 3.0 for bushes and shrubs. +This field is the estimated one-sided leaf area {[}\si{\area}{]} of an indoor living wall. Based on the users’ input, leaf area index (LAI) is calculated as the ratio of the total leaf area and the partition wall area. Typical LAIs are 1.0 for grass and 3.0 for bushes and shrubs. Only LAI values up to 10.0 are allowed in EnergyPlus. \paragraph{Field: LED Nominal Intensity}\label{field-led-nominal-intensity-indoorlivingwall}