-
-
Notifications
You must be signed in to change notification settings - Fork 16
did_gateway_mfr_test_result_include_miner_key_pass - does not use correct slot #254
Copy link
Copy link
Open
Description
As per this function:
hm-pyhelper/hm_pyhelper/miner_param.py
Lines 254 to 268 in 2a6067a
| def did_gateway_mfr_test_result_include_miner_key_pass( | |
| gateway_mfr_test_result | |
| ): | |
| """ | |
| Returns true if gateway_mfr_test_result["tests"] has an key "miner_key(0)" with value | |
| being a dict that contains result key value set to pass. | |
| { | |
| 'result': 'pass', | |
| 'tests': 'miner_key(0)': {'result': 'pass'} | |
| } | |
| """ | |
| return gateway_mfr_test_result.get( | |
| 'tests', {}).get('miner_key(0)', {}).get('result', 'fail') == 'pass' |
The did_gateway_mfr_test_result_include_miner_key_pass only checks slot 0.
If the slot is 2 for example the key in the output will be miner_key(2) and this will fail
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels