From 35584bb6606d6f2539487a21f29f2b98932f36a2 Mon Sep 17 00:00:00 2001
From: Chris Grindstaff <chris@gstaff.org>
Date: Thu, 11 Dec 2025 15:37:23 -0500
Subject: [PATCH] refactor: fix potential resource leak

---
 cmd/collectors/collectorstest.go | 2 ++
 cmd/tools/generate/generate.go   | 2 ++
 pkg/auth/transport.go            | 4 ++++
 pkg/changelog/main.go            | 1 +
 4 files changed, 9 insertions(+)

diff --git a/cmd/collectors/collectorstest.go b/cmd/collectors/collectorstest.go
index 0bb3b6ce0..c3ea3d4de 100644
--- a/cmd/collectors/collectorstest.go
+++ b/cmd/collectors/collectorstest.go
@@ -40,6 +40,8 @@ func JSONToGson(path string, flatten bool) []gjson.Result {
 		if err != nil {
 			panic(err)
 		}
+		//goland:noinspection GoUnhandledErrorResult
+		defer reader.(*gzip.Reader).Close()
 	} else {
 		data, err := os.ReadFile(path)
 		if err != nil {
diff --git a/cmd/tools/generate/generate.go b/cmd/tools/generate/generate.go
index 842634f6b..a4eecc8ec 100644
--- a/cmd/tools/generate/generate.go
+++ b/cmd/tools/generate/generate.go
@@ -214,6 +214,7 @@ func generateDocker(kind int) {
 	if err != nil {
 		tools.LogErrAndExit(err)
 	}
+	defer out.Close()
 
 	if kind == harvest {
 		// generate admin service if configuration is present in harvest config
@@ -250,6 +251,7 @@ func generateDocker(kind int) {
 		if err != nil {
 			tools.LogErrAndExit(err)
 		}
+		defer promStackOut.Close()
 		err = pt.Execute(promStackOut, promTemplate)
 		if err != nil {
 			tools.LogErrAndExit(err)
diff --git a/pkg/auth/transport.go b/pkg/auth/transport.go
index 10406f194..f4c4ad286 100644
--- a/pkg/auth/transport.go
+++ b/pkg/auth/transport.go
@@ -149,6 +149,10 @@ func DumpRequest(req *http.Request, body bool) ([]byte, error) {
 		if err != nil {
 			return nil, err
 		}
+		//goland:noinspection GoUnhandledErrorResult
+		defer req.Body.Close()
+		//goland:noinspection GoUnhandledErrorResult
+		defer save.Close()
 	}
 
 	var b bytes.Buffer
diff --git a/pkg/changelog/main.go b/pkg/changelog/main.go
index d43ff13bf..25605cf95 100644
--- a/pkg/changelog/main.go
+++ b/pkg/changelog/main.go
@@ -71,6 +71,7 @@ func (c *cli) makeDraft() {
 		)
 		return
 	}
+	defer out.Close()
 	_, _ = out.WriteString(`
 - :gem: Seven new dashboards:
     - StorageGRID and ONTAP fabric pool