Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming of RuntimeHelper methods #743

Open
kwin opened this issue Jul 9, 2024 · 1 comment
Open

Improve naming of RuntimeHelper methods #743

kwin opened this issue Jul 9, 2024 · 1 comment

Comments

@kwin
Copy link
Member

kwin commented Jul 9, 2024

Currently the RuntimeHelper exposes two methods related to cloud

  1. isCompositeNodeStore and
  2. isCloudReadyInstance

Both namings are a bit unfortunate, because

  1. in cloud AEM is always started with a composite node store (even during the image build phase). The difference between image build and regular server start is which mount is the default one (apps/libs or the rest) (https://github.com/apache/jackrabbit-oak/blob/8adf6aa2d931e562ec8e69bf4261a250c53fe6f3/oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/CompositeNodeStoreService.java#L90).
  2. sounds a bit like distinction between AEM Classic and AEMaaCS (SDK or Cloud), but in fact what is meant here is if the composite node store is used (where only one mount is read-write)

I propose to rename

  1. isCompositeNodeStore to isAppsReadOnly
  2. isCloudReadyInstance to isCompositeNodeStore

That way it is much clearer what is meant.

@kwin
Copy link
Member Author

kwin commented Sep 16, 2024

Actually I was wrong, AEM is not using the composite node store during the image build phase. The seed mode is just for pre-populating the default store but does not allow to write to /apps or /libs. I tried to clarify this in https://github.com/apache/jackrabbit-oak/pull/1719/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant