Skip to content

Please add support for local ssl certificate files. #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jearton opened this issue Mar 5, 2022 · 13 comments
Open

Please add support for local ssl certificate files. #1911

jearton opened this issue Mar 5, 2022 · 13 comments

Comments

@jearton
Copy link

jearton commented Mar 5, 2022

Is your feature request related to a problem? Please describe.

No.

Describe the solution you'd like

Add SSL Certificate which point to a local path.

Describe alternatives you've considered

I use acme.sh to generate SSL certificate.

Additional context

@jmarler
Copy link

jmarler commented Mar 8, 2022

I also am using an external script to manage my Let's Encrypt. I'm using Dreamhost as the DNS provider for one of my domains, and it is not currently supported by NPM. If I could just point NPM at a certificate that is mounted in the container, that would make things much easier.

@ssrahul96
Copy link
Contributor

ssrahul96 commented Mar 13, 2022

Could you try this as a workaround?

  1. upload your custom SSL certificate
  2. It should create a directory under /data/custom_ssl/npm-{{id}}, which you would ve already mounted as docker volume
  3. rsync you required / updated certificate to that mounted volume at required intervals?

@jearton
Copy link
Author

jearton commented Mar 17, 2022

@ssrahul96 That sounds practicable.

@Frechetta
Copy link

@ssrahul96 that doesn't work. The certificates are stored in the database (certificate table).

@ssrahul96
Copy link
Contributor

@Frechetta , Then it should be straight forward to update it in database rite?

@spcqike
Copy link

spcqike commented Aug 5, 2022

@Frechetta you are not quite right. the certificate information (eg. expiring date) is stored in a database, however the certificate itself is stored in the local filesystem.
have a look at #1618
it is possible to change the cert files in the filesystem, however the information in the UI are wrong afterwards.

so it is possible to either manually rsync an external SSL cert to the filesystem or mount it from elsewhere to your container.

@JokerQyou
Copy link

so it is possible to either manually rsync an external SSL cert to the filesystem or mount it from elsewhere to your container.

Maybe it's easier to use cURL or other tools to call the "update certificate" API just like the web UI does. The only problem is: there is no API documentation.

@ozumado
Copy link

ozumado commented Feb 18, 2023

I am currently using below Advanced setting to use local SSL certificate that gets pushed via rsync from different machine, would be awesome if we get some kind of GUI for that...

listen 443 ssl http2;

  include conf.d/include/letsencrypt-acme-challenge.conf;
  include conf.d/include/ssl-ciphers.conf;
  include conf.d/include/force-ssl.conf;
  ssl_certificate /data/ssl/fullchain.pem;
  ssl_certificate_key /data/ssl/privkey.pem;

Copy link

Issue is now considered stale. If you want to keep it open, please comment 👍

@github-actions github-actions bot added the stale label Feb 22, 2024
@jmarler
Copy link

jmarler commented Feb 22, 2024

I am still interested in having this as an official feature, not a hack.

@github-actions github-actions bot removed the stale label May 2, 2024
Copy link

Issue is now considered stale. If you want to keep it open, please comment 👍

@github-actions github-actions bot added the stale label Nov 29, 2024
@SimonFischer04
Copy link

👍

1 similar comment
@freakma
Copy link

freakma commented Jan 12, 2025

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants