Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Electron to LTS version #137

Open
Nick-Lucas opened this issue Oct 17, 2021 · 2 comments
Open

Upgrade Electron to LTS version #137

Nick-Lucas opened this issue Oct 17, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Nick-Lucas
Copy link
Owner

Nick-Lucas commented Oct 17, 2021

As of now there are lots of blockers to upgrading to the latest electron, and 11 is currently the highest possible

Electron 14/15: node-pty does not support context aware native modules and there is no workaround currently

microsoft/node-pty#405

Possible workaround is to run node-pty in the main process or similar, and use electron's IPC to channel communication. This may be a good idea anyway to improve on performance.

Electron v12-13: Major performance regression when using "spawn" on MacOS

electron/electron#26143

This is due to an upstream issue in libuv and a breaking change on MacOS causing a large chunk of memory to be copied into the new process. Fixing it has been causing the maintainers of the whole chain problems.

Possible fixes include moving spawn calls to the main process or similar, and using electron's IPC to make the requests and responses. May also help with performance. electron/electron#26143 (comment)

@Nick-Lucas Nick-Lucas added the enhancement New feature or request label Oct 17, 2021
@Nick-Lucas Nick-Lucas self-assigned this Oct 17, 2021
@Nick-Lucas
Copy link
Owner Author

Branch 931764a (chore/electron-upgrade) is tracking attempts to upgrade

@Nick-Lucas
Copy link
Owner Author

Branch 9600b8a (chore/electron-11) also tracks an electron 11 attempt as some reports indicated this could still work. In Dev it appears fine, but an unsigned production build is not fine

@Nick-Lucas Nick-Lucas changed the title Upgrade Electron above v8 Upgrade Electron to LTS version Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant