Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some question / suggestions for main.properties (en-US) #44

Open
TonnesM opened this issue Aug 17, 2016 · 3 comments
Open

Some question / suggestions for main.properties (en-US) #44

TonnesM opened this issue Aug 17, 2016 · 3 comments

Comments

@TonnesM
Copy link
Contributor

TonnesM commented Aug 17, 2016

As requested per IRC, here’s some questions that popped up while localizing this file and may be interesting for other localizers:

Line #
13 osfileerror_unknownreason=Unnamed reason // Shouldn’t this be "Unknown reason"?
18 abort_error=Failed For Error // How common is "for" here?
53 search=Reverse Image Search // This is about a "reverse search" for images, right? I.e. not "a search for reverse images" (possible l10n misconception on compound words)
105 denied_msg=You have disallowed access, to fully enjoy the experience, please authorize again but with approval. // How about changing the first comma by a period and start a new line, or replace it by e.g. ";"?
117 print_preview_desc2=Or send directly to print // Shouldn’t this be "printER"? Or was the verb intended, as in "for printing"?
171 confirm_forget=This will remove this entry from the log of history. Do you want to continue? // How about "history log" for "log of history"?
179 reason1_trash=Something went wrong in platform trash procedure // How about "...in the platform..."?
261 slk=Slovakian // Shouldn't "Slovak" be better, like in Firefox?
265 uninstall_body=NativeShot is being uninstalled. Would you like to delete associated preferences and history\n\n -> Doesn’t this need a question mark, i.e. "history?\n\n"?

@Noitidart
Copy link
Owner

Noitidart commented Aug 17, 2016

Thanks for this feedback! Dealing with strings is tedious work for coders. I am drowning in the code so I don't pay attention to strings so much. This feedback is very valuble for all localizers and myself.

13 osfileerror_unknownreason=Unnamed reason // Shouldn’t this be "Unknown reason"?

This is actually an unnamed readon. It gives us an error code but no string. So i have renamed osfileerror_unknownreason to osfileerror_unnamedreason, as you are correct it is cofusing to use unknown.

18 abort_error=Failed For Error // How common is "for" here?

This one is very rare, it should never happen. Usually things go to "hold_error" which means "hold", meaning they are resumable/fixable with user intervention. Abort happens when its not possible to resume.

53 search=Reverse Image Search // This is about a "reverse search" for images, right? I.e. not "a search for reverse images" (possible l10n misconception on compound words)

This is first, it is "reverse search for images".

105 denied_msg=You have disallowed access, to fully enjoy the experience, please authorize again but with approval. // How about changing the first comma by a period and start a new line, or replace it by e.g. ";"?

Updated

117 print_preview_desc2=Or send directly to print // Shouldn’t this be "printER"? Or was the verb intended, as in "for printing"?

It actually sends it to "print dialog", which is out of firefox control. So I didn't say "printer".

171 confirm_forget=This will remove this entry from the log of history. Do you want to continue? // How about "history log" for "log of history"?

Shorter the better. I changed it to "history log".

179 reason1_trash=Something went wrong in platform trash procedure // How about "...in the platform..."?

I tried to keep this as short as possible because this message is shown in the gallery over images, so space is very limited.

261 slk=Slovakian // Shouldn't "Slovak" be better, like in Firefox?

This is a great idea to be consistent with Fx, change made.

265 uninstall_body=NativeShot is being uninstalled. Would you like to delete associated preferences and history\n\n -> Doesn’t this need a question mark, i.e. "history?\n\n"?

Question mark added.

Noitidart added a commit that referenced this issue Aug 17, 2016
* Implemented localization fixes per @TonnesM discussion in #44
@TonnesM
Copy link
Contributor Author

TonnesM commented Aug 19, 2016

18 abort_error=Failed For Error // How common is "for" here?

This one is very rare, it should never happen. Usually things go to "hold_error" which means
"hold", meaning they are resumable/fixable with user intervention. Abort happens when its
not possible to resume.

Thanks, what I actually meant was whether or not "because of" or "due to" was meant here, since it looks like this is about a "For error" that failed. Could you elaborate?

Additional suggestions:

  • How about using … (ellipsis) characters?
  • You could even consider using curly single/double quotes (‘ ’ “ ”) (like in products)
  • Last but not least: could you please disable auto-capitalization for the options strings? Localizers aren't really fond of that, especially for specific locales.

@Noitidart
Copy link
Owner

Hey @TonnesM I'm submitting a comit right now to remove that auto captizliation.

For that error, it is "Because of".

You can use ellipsis and single double quotes, that is an awesome idea. If you can implement it here in your locale I'll take it to the english locale and push to all for future updates. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants