Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternate method of adding image hosting services by users #74

Open
atomGit opened this issue Apr 25, 2017 · 4 comments
Open

alternate method of adding image hosting services by users #74

atomGit opened this issue Apr 25, 2017 · 4 comments

Comments

@atomGit
Copy link

atomGit commented Apr 25, 2017

currently the services NativeShot uses are hard-coded apparently and this creates two issues: 1), someone will always want a service that isn't included and 2), if the dev wants to add that service, they have to write the code and pump out a new release which then has to be reviewed (by Moz), etc.

what i would propose is that the image hosting part of the code be rewritten to become more like a framework and that the 'code' for each image hosting service be written to simple text files, by users, which can then be added as a sort of plug-in to NativeShot - users could then write the necessary scripts to support whatever service they want and then these could then be shared with others through GitHub

i don't know anything regarding the different API's that the image hosts offer so i don't even know if this is doable, but here is what one of these scripts might look like if it is - perhaps it could be as simple as a standard INI file...

friendly_name=imgoat
url=https://imgoat.com/
connection_protocol=https
account_name=me
account_password=notmypetsname
upload_folder=

that would be uploaded as a text file on GitHub (maybe by pull request?) and usable by anyone that wanted to add the imgoat hosting service - all they would have to do is download the file and stick it in some dedicated directory for the NativeShot extension

after doing so, and restarting the browser i assume, an "imgoat" item (from "friendly_name") would be added to the browser context menu to support this service

NativeShot would take it from there, having the necessary generic code to make an https connection and whatever else is needed

@Noitidart
Copy link
Owner

Thank you @atomGit for this! This is really cool brainstorming! I really want to implement this.

@atomGit
Copy link
Author

atomGit commented Apr 29, 2017

actually the imgoat service i used as an example apparently lacks an API at this time - it's a new service by a guy on voat.co

glad you like the idea though - should make things easier on you if it can be implemented

@Noitidart
Copy link
Owner

Desktop version started and it won't have any "built in" services. They will all be "default custom services" added with this method :)

https://github.com/Noitidart/NativeShotDesktop

That's the plan @wadie and I are designing it right now :)

@atomGit
Copy link
Author

atomGit commented Aug 1, 2017

hey! it's cool that you're working on this - i hope this approach makes things allot easier coding wise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants