Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish all napi-rs builds with @nomicfoundation/edr #434

Closed
fvictorio opened this issue May 6, 2024 · 1 comment
Closed

Publish all napi-rs builds with @nomicfoundation/edr #434

fvictorio opened this issue May 6, 2024 · 1 comment
Assignees
Milestone

Comments

@fvictorio
Copy link
Member

Due to an npm bug that doesn't seem like it's going to be fixed any time soon, users can have issues with the way NAPI-RS uses optional dependencies.

As a workaround, we can make the @nomicfoundation/edr package always have all the builds available.

It's not clear what's the best way to do this: we could either include all the builds directly in that package, or keep the current approach but make the dependencies be actual dependencies and not optional dependencies. We'll need to do some research.

@fvictorio fvictorio self-assigned this May 8, 2024
@fvictorio
Copy link
Member Author

Closed by #449

@Wodann Wodann added this to the EDR v0.3.9 milestone May 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants