Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop recursive validity checks for nodes #1005

Open
OmarTawfik opened this issue Jun 10, 2024 · 0 comments
Open

stop recursive validity checks for nodes #1005

OmarTawfik opened this issue Jun 10, 2024 · 0 comments
Assignees

Comments

@OmarTawfik
Copy link
Collaborator

OmarTawfik commented Jun 10, 2024

We query for node completeness/correctness recursively during parsing, for both valid and invalid inputs. For example Match::is_full_recursive(), which will happen for any ChoiceHelper even at root of the tree (like SourceUnitMember). There could be other places as well that create a Cursor during parsing do check for sub-trees recursively.

We should revisit this once #808 is complete.

One solution is to track this information via a field on the ParserResult instead, and propagate that field upwards when unwrapping/wrapping new ParseResult instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ⏳ Todo
Development

No branches or pull requests

2 participants