hr_timesheet_sheet: Unable to add new line on sheet if project_timesheet_holidays is installed

[maisim]

Module

hr_timesheet_sheet

Describe the bug

When we add a line to a sheet wich contains a time off line, we have an Error:
You cannot modify timesheets that are linked to time off requests. Please use the Time Off application to modify your time off requests instead

Some mechanisms has been introduced to avoid holidays modifications from other places than holidays app:

https://github.com/odoo/odoo/blob/c226098a20e9d70090bc9ae6b4c2b82483ae0f4b/addons/project_timesheet_holidays/models/account_analytic.py#L31-L37

You can see here the changes made to be able to bypass this:
odoo/odoo#120597

By the way, I think the useful solution was the first proposal, but...

A change in hr_timesheet_sheet to get it working is here:

timesheet/hr_timesheet_sheet/models/account_analytic_line.py

Lines 138 to 139 in aaf0b28

	def _check_can_update_timesheet(self):
	return super()._check_can_update_timesheet() or not self.filtered("sheet_id")

The problem is, when we add a new line on a sheet, all related account analytic line records are updated, even the ones already have the good sheet_id defined, because of:

timesheet/hr_timesheet_sheet/models/hr_timesheet_sheet.py

Lines 680 to 682 in aaf0b28

	self.timesheet_ids |= self.env["account.analytic.line"]._sheet_create(
	values
	)

The solution is to just add new records:

new_line = self.env['account.analytic.line']._sheet_create(values)
self.write({'timesheet_ids': [(4, new_line.id)]})

## Versions

• 16.0

A PR is comming

[maisim]

Hi @alexey-pelykh @gurneyalex !
can any of you take a look at it please ? 😄