For Cohort Definitions, Incidence Rates, and Characterization, the functionality of using concept sets in CIRCE Criteria depends on a local copy of a concept set that is embedded in the CD, IR, or Char. When choosing a concept set, you should be given the list of the 'local' concept sets, and then possibly given the option of importing a 'repository concept set' into the design of the CD, IR or Characterization (going to refer to this as the 'definition').
The current behavior is that when you select a concept set in the UI, you are presented with the repository concept sets to import into the definition, and are not given a choice of choosing an existing concept set.
The behavior should be:
Select concept set shows the concept sets that are imported into the design. you can either choose a concept set from this list, or choose to import the external concept set from the repository, or create a new (empty) concept set in the local definition. There is an issue with clicking 'create new concept set' in the concept set selection list, but I think since the behavior of listing concept sets, importing them, or creating a new local one is all a function of this issue, so I think it should be addressed as part of this issue.
The functionality should work as follows:
A criteria with a assigned concept set should lead to the editor for the concept set (This is current working behavior)
When a concept set is not assigned to the criteria, the 'select concept set appears' and clicking on it leads to the list of local concept sets in the definition.
- In this view, the user has the option of selecting the existing one, importing a repository concept set, or creating a new empty one.
If the user selects an existing one, update the criteria state with the inner conceptSetId, and show it as the seleected concept set (user is returned to the criteria editor)
If the user imports a concept set item:
- import the concept set expression, into a new local concept set
- assign the internal conceptSetId to max(concept set IDs of all internal concept sets) + 1.
- Update criteria's 'selected concept set' to the new ID.
- User returns to the criteria editor.
If the user selects 'new concept set':
- create an empty concept set
- assign it max(concept set IDs of all internal concept sets) + 1
- update criteria's 'selected concept set' to the new ID.
- User is directed to the concept set editor of the new empty concept set (because it's the assumption they will need to add concepts to it.
Note: we could potentially have all 3 of the above paths return the user to the concept set editor, and if they want to edit the new empty concept set, they just click on the selected concept set in the editor and it directs them to edit the internal concept set expression.
For Cohort Definitions, Incidence Rates, and Characterization, the functionality of using concept sets in CIRCE Criteria depends on a local copy of a concept set that is embedded in the CD, IR, or Char. When choosing a concept set, you should be given the list of the 'local' concept sets, and then possibly given the option of importing a 'repository concept set' into the design of the CD, IR or Characterization (going to refer to this as the 'definition').
The current behavior is that when you select a concept set in the UI, you are presented with the repository concept sets to import into the definition, and are not given a choice of choosing an existing concept set.
The behavior should be:
Select concept set shows the concept sets that are imported into the design. you can either choose a concept set from this list, or choose to import the external concept set from the repository, or create a new (empty) concept set in the local definition. There is an issue with clicking 'create new concept set' in the concept set selection list, but I think since the behavior of listing concept sets, importing them, or creating a new local one is all a function of this issue, so I think it should be addressed as part of this issue.
The functionality should work as follows:
A criteria with a assigned concept set should lead to the editor for the concept set (This is current working behavior)
When a concept set is not assigned to the criteria, the 'select concept set appears' and clicking on it leads to the list of local concept sets in the definition.
If the user selects an existing one, update the criteria state with the inner conceptSetId, and show it as the seleected concept set (user is returned to the criteria editor)
If the user imports a concept set item:
If the user selects 'new concept set':
Note: we could potentially have all 3 of the above paths return the user to the concept set editor, and if they want to edit the new empty concept set, they just click on the selected concept set in the editor and it directs them to edit the internal concept set expression.