Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs - signing & verification should use raw payload instead of formatting #70

Open
BLR-0118 opened this issue May 8, 2024 · 2 comments

Comments

@BLR-0118
Copy link
Member

BLR-0118 commented May 8, 2024

utilities/ondc-crypto-sdk-nodejs/src/utility/index.ts:

  1. createAuthorizationHeader uses JSON.stringify on the raw payload and then signs this formatted payload; this should be removed;
  2. verifyHeader uses JSON.stringify on the raw payload and verifies with this formatted payload; this should be removed;
@BLR-0118
Copy link
Member Author

BLR-0118 commented May 8, 2024

@jainneerajnj

@robinchauhan2
Copy link

Hi @BLR-0118 sir, i am already working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants