Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nivesh(TRV13)-Compliance Check #1932

Open
sourabhsaini11 opened this issue Feb 6, 2025 · 4 comments
Open

Nivesh(TRV13)-Compliance Check #1932

sourabhsaini11 opened this issue Feb 6, 2025 · 4 comments

Comments

@sourabhsaini11
Copy link

on_search

  • for add_ons defined additionally apart from api-contract (COMPRIHENSIVE_INSURANCE, THIRD_PARTY_INSURANCE, NEW_INSURANCE, TRANSFER_INSURANCE, OWN_DAMAGE), send only descriptor.code

common_issue

  • remove empty add_ons if not selected (/select onwards)
  • for tag OFFER_VALIDITY, correct format is P15D
  • bap_uri ishould remain same throughout transaction journey
  • How can item.price possibly be 0
  • How can params.amount & SETTLEMENT_AMOUNT be 12505 if item.price is 0

init_1

  • xinput.status should be SUCCESS

on_init_1

  • missing VAHAN_DETAILS
  • xinput.descriptor.name should be "Vehicle & Nominee Details"

on_init_2

  • missing VAHAN_DETAILS
  • xinput.descriptor.name should be "Personal Info"

Claim-Flow

  • missing on_status with fulfillment.type CLAIM
  • on_update calls representing CLAIM flow are incorrect, payload is incomplete & missing calls as well

on_update_1

  • incorrect payload, missing CLAIM payload
@AkhileshNivesh
Copy link

@sourabhsaini11
As we are buyer's side, how did we fix the callback logs on_search / on_init / on_update?

Whatever status we are getting in on_status we are passing on init call for xinput.status should be SUCCESS

@sourabhsaini11
Copy link
Author

Hi @AkhileshNivesh Please focus on validating logs for action calls only

@AkhileshNivesh
Copy link

Hi @sourabhsaini11 all the above issues are highlighted they are from the on_action call response or the data we are getting as the buyer side the same data are passing.

if some thing we are missing please share that action name & issue.

@sourabhsaini11
Copy link
Author

@AkhileshNivesh, action calls issues are also mentioned. Please improvise those & update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants