CI

Author: jm-rivera

.github/workflows/documentation.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install uv
-        uses: astral-sh/setup-uv@v4
+        uses: astral-sh/setup-uv@v5
 
       - name: Set up Python 3.10
         run: uv python install 3.10

.github/workflows/release.yml

@@ -16,7 +16,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Install uv
-        uses: astral-sh/setup-uv@v4
+        uses: astral-sh/setup-uv@v5
 
       - name: Set up Python
         run: uv python install 3.11

.github/workflows/tests.yml

@@ -28,7 +28,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Install uv
-        uses: astral-sh/setup-uv@v4
+        uses: astral-sh/setup-uv@v5
 
       - name: Set up Python ${{ matrix.config.py }}
         run: uv python install ${{ matrix.config.py }}
@@ -40,12 +40,14 @@ jobs:
         run: uv run pytest tests/ --cov=imf_reader --cov-report=xml
 
       - name: Use Codecov to track coverage
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v5
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: ./coverage.xml
           fail_ci_if_error: true
           verbose: true
 
       - name: Check code style
-        run: uv run black src tests --check
+        run: |
+          uv run ruff format src tests --check
+          uv run ruff check src tests

pyproject.toml

@@ -20,7 +20,7 @@ dependencies = [
 [project.optional-dependencies]
 dev = [
     "pytest>=8.2.0",
-    "black>=24.4.2",
+    "ruff>=0.6",
     "sphinx>=7.3.7",
     "myst-nb>=1.1.0",
     "autoapi>=2.0.1",

src/imf_reader/cache/dataframe.py

@@ -41,6 +41,12 @@ def decorator(fn: Any) -> Any:
         # Capture signature once at decoration time (P2 — avoids per-call overhead).
         sig = inspect.signature(fn)
 
+        # Sanitize fn.__qualname__ for use in filenames: nested-defined functions
+        # produce names like "outer.<locals>.fetch" which contain "<" and ">",
+        # both illegal on Windows (NTFS reserved characters → ENOTSUP/EINVAL on
+        # write). Stripping them keeps cache keys portable across platforms.
+        safe_qualname = fn.__qualname__.replace("<", "_").replace(">", "_")
+
         def _get_sublayer_dir() -> Path:
             # Always re-resolve so set_cache_dir() takes effect even if the
             # listener registry has been cleared by a test fixture or other
@@ -53,7 +59,7 @@ def _make_cache_key(*args: Any, **kwargs: Any) -> str:
             key_repr = repr(sorted(bound.arguments.items()))
             digest = hashlib.sha256(key_repr.encode()).hexdigest()[:16]
             module = fn.__module__ or ""
-            return f"{module}.{fn.__qualname__}__{digest}"
+            return f"{module}.{safe_qualname}__{digest}"
 
         def _cache_path(key: str, result: Any) -> Path:
             ext = ".parquet" if isinstance(result, pd.DataFrame) else ".pkl"
@@ -91,7 +97,7 @@ def _do_cache_clear() -> None:
             if not d.exists():
                 return
             module = fn.__module__ or ""
-            prefix = f"{module}.{fn.__qualname__}__"
+            prefix = f"{module}.{safe_qualname}__"
             for p in d.iterdir():
                 if p.name.startswith(prefix):
                     p.unlink(missing_ok=True)

src/imf_reader/weo/api.py

@@ -9,7 +9,9 @@
 from imf_reader.config import logger
 from imf_reader.weo import ValidMonths, Version
 from imf_reader.cache.dataframe import dataframe_cache
-from imf_reader.cache.legacy import _legacy_weo_api_clear_cache as clear_cache  # noqa: F401
+from imf_reader.cache.legacy import (
+    _legacy_weo_api_clear_cache as clear_cache,  # noqa: F401
+)
 from imf_reader.utils import make_get_request
 
 # Standard scale labels

tests/test_cache/test_config.py

@@ -23,26 +23,31 @@ def _reset_config():
     cfg._cache_enabled = True
 
 
-def test_default_root_uses_platformdirs(monkeypatch: pytest.MonkeyPatch) -> None:
+def test_default_root_uses_platformdirs(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
     """get_active_root() uses platformdirs when no override or env var is set."""
     monkeypatch.delenv(cfg.ENV_VAR, raising=False)
-    fake_base = "/fake/cache/dir"
+    fake_base = str(tmp_path / "fake_cache")
 
     with patch("platformdirs.user_cache_dir", return_value=fake_base) as mock_pdir:
         root = cfg.get_active_root()
 
     mock_pdir.assert_called_once_with("imf_reader", appauthor=False)
-    assert str(root).startswith(fake_base)
+    # Compare via Path semantics so the test is portable across separator conventions.
+    assert root.is_relative_to(Path(fake_base))
 
 
-def test_env_var_overrides_default(monkeypatch: pytest.MonkeyPatch) -> None:
+def test_env_var_overrides_default(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
     """IMF_READER_CACHE_DIR env var overrides the platformdirs default."""
-    env_path = "/tmp/imf_cache_env"
+    env_path = str(tmp_path / "env_cache")
     monkeypatch.setenv(cfg.ENV_VAR, env_path)
 
     root = cfg.get_active_root()
 
-    assert str(root).startswith(env_path)
+    assert root.is_relative_to(Path(env_path))
 
 
 def test_version_segment_in_path(monkeypatch: pytest.MonkeyPatch) -> None:

tests/test_cache/test_legacy_shims.py

@@ -61,7 +61,9 @@ def test_weo_clear_cache_no_warning_at_import() -> None:
 
     with warnings.catch_warnings():
         warnings.simplefilter("error", DeprecationWarning)
-        from imf_reader.weo import clear_cache  # noqa: F401 — import itself is under test
+        from imf_reader.weo import (
+            clear_cache,  # noqa: F401 — import itself is under test
+        )
 
 
 def test_weo_clear_cache_signature() -> None: