Skip to content

Reworked logic of registering async requests in Session.m_outstandingRequests #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimolegan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reworked logic of registering async requests in Session.m_outstandingRequests #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 20 additions & 36 deletions SampleApplications/SampleLibraries/Client/Session.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3369,21 +3369,18 @@ private void AsyncRequestStarted(IAsyncResult result, uint requestId, uint typeI
lock (m_outstandingRequests)
{
// check if the request completed asynchronously.
AsyncRequestState state = RemoveRequest(result, requestId, typeId);

// add a new request.
if (state == null)
{
state = new AsyncRequestState();
if (result.IsCompleted)
return;

state.Defunct = false;
state.RequestId = requestId;
state.RequestTypeId = typeId;
state.Result = result;
state.Timestamp = DateTime.UtcNow;
// add request
AsyncRequestState state = new AsyncRequestState();
state.Defunct = false;
state.RequestId = requestId;
state.RequestTypeId = typeId;
state.Result = result;
state.Timestamp = DateTime.UtcNow;

m_outstandingRequests.AddLast(state);
}
m_outstandingRequests.AddLast(state);
}
}

Expand All @@ -3396,33 +3393,20 @@ private void AsyncRequestCompleted(IAsyncResult result, uint requestId, uint typ
{
// remove the request.
AsyncRequestState state = RemoveRequest(result, requestId, typeId);

if (state != null)
{
// mark any old requests as default (i.e. the should have returned before this request).
DateTime maxAge = state.Timestamp.AddSeconds(-1);

for (LinkedListNode<AsyncRequestState> ii = m_outstandingRequests.First; ii != null; ii = ii.Next)
{
if (ii.Value.RequestTypeId == typeId && ii.Value.Timestamp < maxAge)
{
ii.Value.Defunct = true;
}
}
}

// add a dummy placeholder since the begin request has not completed yet.
// if request was completed before registering in AsyncRequestStarted
if (state == null)
{
state = new AsyncRequestState();
return;

state.Defunct = true;
state.RequestId = requestId;
state.RequestTypeId = typeId;
state.Result = result;
state.Timestamp = DateTime.UtcNow;
// mark any old requests as default (i.e. the should have returned before this request).
DateTime maxAge = state.Timestamp.AddSeconds(-1);

m_outstandingRequests.AddLast(state);
for (LinkedListNode<AsyncRequestState> ii = m_outstandingRequests.First; ii != null; ii = ii.Next)
{
if (ii.Value.RequestTypeId == typeId && ii.Value.Timestamp < maxAge)
{
ii.Value.Defunct = true;
}
}
}
}
Expand Down