added dependencies test for #17

Author: lopezjuanma96

functions/dependencies.js

@@ -4,7 +4,7 @@ function isDependant(nodeChild, nodeParent, isHeadOf) {
                 const [amt, dir] = isHeadOf[nodeParent.type][nodeChild.type].split(':');
                 switch(amt){
                     case 'SING':
-                        return nodeParent.children.map(e => e.type).includes(nodeChild.type)
+                        return !nodeParent.children.map(e => e.type).includes(nodeChild.type)
                     case 'MULT':
                         switch(dir){
                             case 'LEFT':

functions/tests/dependencies.test.js

@@ -0,0 +1,91 @@
+const expect = require('chai').expect
+
+describe('Test Dependencies', () => {
+    before(() => {
+        this.isDependant = require('../dependencies.js').isDependant;
+        this.isHeadOf = {
+            "PARENT": {
+                "CHILD_SING": "SING:",
+                "CHILD_MULT": "MULT:",
+                "CHILD_MULT_UNID": "MULT:UNID",
+                "CHILD_MULT_LEFT": "MULT:LEFT",
+                "CHILD_MULT_RIGHT": "MULT:RIGHT"
+            }
+        }
+    })
+
+    it('Should only get one dependant if SING', () => {
+        const child = {type: 'CHILD_SING', position: 0, children: []}
+        const parent = {type: 'PARENT', position: 1, children: []}
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).true
+        
+        //add a children with the same name
+        parent.children.push({type: 'CHILD_SING', position: 2})
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).false
+    })
+    
+    it('Should get many dependants if MULT', () => {
+        const child = {type: 'CHILD_MULT', position: 0, children: []}
+        const parent = {type: 'PARENT', position: 1, children: []}
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).true
+        
+        //add a children with the same name
+        parent.children.push({type: 'CHILD_MULT', position: 2})
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).true
+    })
+
+    it('Should only get dependants on one side if MULT:UNID', () => {
+        const child = {type: 'CHILD_MULT_UNID', position: 0, children: []}
+        const parent = {type: 'PARENT', position: 2, children: []}
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).true
+        
+        //add a children with the same name on the same direction
+        parent.children.push({type: 'CHILD_MULT_UNID', position: 1})
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).true
+        
+        //clear children
+        parent.children.length = 0
+        //add a children with the same name on a different direction
+        parent.children.push({type: 'CHILD_MULT_UNID', position: 3})
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).false
+    })
+
+    it('Should only get dependants on the left if MULT:RIGHT (because RIGHT refers to the position of the HEAD)', () => {
+        const child = {type: 'CHILD_MULT_RIGHT', position: 0, children: []}
+        const parent = {type: 'PARENT', position: 2, children: []}
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).true
+        
+        //add a children with the same name to the left
+        parent.children.push({type: 'CHILD_MULT_RIGHT', position: 1})
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).true
+
+        //change child position to the right
+        child.position = 3
+        expect(this.isDependant(child, parent, this.isHeadOf)).false
+    })
+
+    it('Should only get dependants on the left if MULT:LEFT (because RIGHT refers to the position of the HEAD)', () => {
+        const child = {type: 'CHILD_MULT_LEFT', position: 2, children: []}
+        const parent = {type: 'PARENT', position: 1, children: []}
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).true
+        
+        //add a children with the same name to the right
+        parent.children.push({type: 'CHILD_LEFT', position: 3})
+
+        expect(this.isDependant(child, parent, this.isHeadOf)).true
+
+        //change child position to the left
+        child.position = 0
+        expect(this.isDependant(child, parent, this.isHeadOf)).false
+    })
+})

functions/tests/methods.test.js

@@ -1,6 +1,6 @@
 const expect = require('chai').expect
 
-describe('Testing Prepare Sentence', async () => {
+describe('Testing Prepare Sentence', () => {
     before(() => {
         this.prepareSentence = require('../methods.js').prepareSentence;
 

functions/tests/prepares.test.js

@@ -58,7 +58,7 @@ describe('Testing prepare NOUN methods', () => {
     })
 })
 
-describe('Testing prepare SUBJ methods', async () => {
+describe('Testing prepare SUBJ methods', () => {
     before(() => {
         const { getDbRef } = require('../getter.js')
         this.langRef = getDbRef().database().ref('es')