Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequences after verb Token #11

Closed
2 tasks done
lopezjuanma96 opened this issue Oct 24, 2022 · 0 comments
Closed
2 tasks done

Sequences after verb Token #11

lopezjuanma96 opened this issue Oct 24, 2022 · 0 comments

Comments

@lopezjuanma96
Copy link
Contributor

lopezjuanma96 commented Oct 24, 2022

Context
We already change verbs based on their sequence, some verbs force others to be conjugated specifically. But this can also be applied from the last verb on a verb token to the next token, for example the pictos "I", "sing", "mom" could be realised as "I sing with mom" or "I sing to mom" (obviously we have to make a choice on this) but "I", "sing", "song" could be realised as "I sing a song". We need to implement a method to care for this.

Causes/Justification
Although there's enough pictos to create sentences with the necessary articles and prepositions, most of out users won't use them bc they don't have the necessarry cognitive level for them.

Solution Alternatives

  • when analyzing verb sequences, use the last verb to test on the first wordtype of the next token.
  • also add exceptions for specific words, "I", "want", "go to", "airport" should be realised as "I want to go to the airport", whereas "I", "want", "go to", "home" should be realised as "I want to go to home" (no article) or "I want to go home" (that's more difficult)

Repercussions
The verb sequences path on the database will now have sequences for different categories/ wordtypes

lopezjuanma96 added a commit that referenced this issue Oct 24, 2022
changed findART to splitART
added splitDefinitive
added handler from verb token to next token sequence
lopezjuanma96 added a commit that referenced this issue Nov 16, 2022
changed findART to splitART
added splitDefinitive
added handler from verb token to next token sequence
lopezjuanma96 added a commit that referenced this issue Nov 16, 2022
changed findART to splitART
added splitDefinitive
added handler from verb token to next token sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant