`deleteNode` leaks memory

[psaripp]

I have found a memory leak issue in deleteNode method. I wrote an algorithm to clean up maps, and it uses this method extensively. However, we have found out that this particular method causes a memory leak.

I was able to isolate one of our test cases which proves this behaviour and I had created a repo to prove it:
https://github.com/psaripp/octomap-memoryleak-proof

This affects the latest version of octomap, not just the one which was included in ROS melodic.

[Teebor-Choka]

Can you open a PR with a failing test?

[ahornung]

Also, be sure that it's not the expected leak in classIdMapping: https://github.com/OctoMap/octomap/blob/master/octomap/src/AbstractOcTree.cpp#L198

[psaripp]

Also, be sure that it's not the expected leak in classIdMapping: https://github.com/OctoMap/octomap/blob/master/octomap/src/AbstractOcTree.cpp#L198

Why does it have to be a pointer on the first place? The same effect can be achieved if you declare it as not pointer, and return with just the reference. This also ensures that the dtor will be called when the application exits, and make sure all resources freed allocated by the map itself. Otherwise, you have to do for yourself.

[ahornung]

I think that's handled and discussed in the FAQ here for the "static initialization order fiasco":
https://isocpp.org/wiki/faq/ctors#construct-on-first-use-v2

[ahornung]

@psaripp: Is there a different leak than the mentioned one? Please also note the supplied memcheck suppresion file:
https://github.com/OctoMap/octomap/blob/master/octomap/valgrind_memcheck.supp

[ahornung]

Closing due to inactivity, probably fixed by #288 . Please reopen if the issue persists.