From 898be041901270c11edd80e78ea82fd7f46213ae Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 2 Oct 2023 00:30:52 -0400 Subject: [PATCH 01/10] spelling: address Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- source/Octo.Tests/Util/UriExtensionsFixture.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/Octo.Tests/Util/UriExtensionsFixture.cs b/source/Octo.Tests/Util/UriExtensionsFixture.cs index 1e319c31e1..617390c17e 100644 --- a/source/Octo.Tests/Util/UriExtensionsFixture.cs +++ b/source/Octo.Tests/Util/UriExtensionsFixture.cs @@ -16,7 +16,7 @@ public void ShouldAppendSuffixIfThereIsNoOverlap() } [Test] - public void ShouldRemoveAnyOverlapBetweenBaseAddresAndSuffix() + public void ShouldRemoveAnyOverlapBetweenBaseAddressAndSuffix() { var result = new Uri("http://www.mysite.com/virtual").EnsureEndsWith("/virtual/suffix"); From 0c19cf6301cfc846c3a29d1d883c6a7a6c192eb4 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Oct 2023 06:32:24 -0400 Subject: [PATCH 02/10] spelling: available Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- source/Octo.Tests/Commands/ReleasePlanBuilderTests.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source/Octo.Tests/Commands/ReleasePlanBuilderTests.cs b/source/Octo.Tests/Commands/ReleasePlanBuilderTests.cs index 68854cc885..015e8e2750 100644 --- a/source/Octo.Tests/Commands/ReleasePlanBuilderTests.cs +++ b/source/Octo.Tests/Commands/ReleasePlanBuilderTests.cs @@ -131,7 +131,7 @@ public void NoPackageOrScriptSteps_ShouldNotBeViable() } [Test] - public void DisabledScriptSteps_ShouldNotBeAViablePlan() + public void DisabledScriptSteps_ShouldNotBeAvailablePlan() { // arrange var deploymentStepResource = ResourceBuilderHelpers.GetStep(); @@ -146,7 +146,7 @@ public void DisabledScriptSteps_ShouldNotBeAViablePlan() } [Test] - public void SingleEnabledScriptStep_ShouldBeAViablePlan() + public void SingleEnabledScriptStep_ShouldBeAvailablePlan() { // arrange var deploymentStepResource = ResourceBuilderHelpers.GetStep(); @@ -161,7 +161,7 @@ public void SingleEnabledScriptStep_ShouldBeAViablePlan() } [Test] - public void SingleEnabledScriptStepScopedToDifferentChannel_ShouldNotBeAViablePlan() + public void SingleEnabledScriptStepScopedToDifferentChannel_ShouldNotBeAvailablePlan() { // arrange var deploymentStepResource = ResourceBuilderHelpers.GetStep(); From d8ac5ab960d4a6047b1aac2de27aebc5e1ad3a10 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 2 Oct 2023 00:31:09 -0400 Subject: [PATCH 03/10] spelling: compatibility Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- source/Octopus.Cli/Commands/HealthStatusProvider.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/Octopus.Cli/Commands/HealthStatusProvider.cs b/source/Octopus.Cli/Commands/HealthStatusProvider.cs index 5663af9fdc..82a59af603 100644 --- a/source/Octopus.Cli/Commands/HealthStatusProvider.cs +++ b/source/Octopus.Cli/Commands/HealthStatusProvider.cs @@ -10,7 +10,7 @@ namespace Octopus.Cli.Commands { /// - /// This class exists to provide backwards compataility to the pre 3.4.0 changes to machine state. + /// This class exists to provide backwards compatibility to the pre 3.4.0 changes to machine state. /// As of 3.4.0 the enum has been marked as obselete to be replaced with /// public class HealthStatusProvider From f1fde1c26e2b9917d02f18c631bd5a128eec18e2 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Thu, 5 Oct 2023 00:00:07 -0400 Subject: [PATCH 04/10] spelling: lifecycle Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- source/Octopus.Cli/Commands/Channel/CreateChannelCommand.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/Octopus.Cli/Commands/Channel/CreateChannelCommand.cs b/source/Octopus.Cli/Commands/Channel/CreateChannelCommand.cs index 78240dc7b9..b5d03493d2 100644 --- a/source/Octopus.Cli/Commands/Channel/CreateChannelCommand.cs +++ b/source/Octopus.Cli/Commands/Channel/CreateChannelCommand.cs @@ -76,7 +76,7 @@ public async Task Request() Name = channelName, IsDefault = makeDefaultChannel ?? false, Description = channelDescription ?? string.Empty, - LifecycleId = lifecycle?.Id, // Allow for the default lifeycle by propagating null + LifecycleId = lifecycle?.Id, // Allow for the default lifecycle by propagating null Rules = new List() }; From 8f0325f2a479a4133154c284ad2c050d3c61b694 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 2 Oct 2023 00:31:48 -0400 Subject: [PATCH 05/10] spelling: matching Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- source/Octopus.Cli/Commands/Releases/ReleasePlan.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/Octopus.Cli/Commands/Releases/ReleasePlan.cs b/source/Octopus.Cli/Commands/Releases/ReleasePlan.cs index 83fe59d47e..94b85403b6 100644 --- a/source/Octopus.Cli/Commands/Releases/ReleasePlan.cs +++ b/source/Octopus.Cli/Commands/Releases/ReleasePlan.cs @@ -38,7 +38,7 @@ public ReleasePlan(ProjectResource project, a.Channels }) .Where(x => string.IsNullOrEmpty(x.PackageId) && x.IsDisabled == false) // only consider enabled script steps - .Where(a => !a.Channels.Any() || a.Channels.Contains(channel.Id)) // only include actions without channel scope or with a matchign channel scope + .Where(a => !a.Channels.Any() || a.Channels.Contains(channel.Id)) // only include actions without channel scope or with a matching channel scope .Select(x => new ReleasePlanItem(x.StepName, null, From d633590d25b02a4d61b11dac9b6ca250658363fe Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 2 Oct 2023 00:32:02 -0400 Subject: [PATCH 06/10] spelling: obsolete Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- source/Octopus.Cli/Commands/HealthStatusProvider.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/Octopus.Cli/Commands/HealthStatusProvider.cs b/source/Octopus.Cli/Commands/HealthStatusProvider.cs index 82a59af603..a5b7ebc451 100644 --- a/source/Octopus.Cli/Commands/HealthStatusProvider.cs +++ b/source/Octopus.Cli/Commands/HealthStatusProvider.cs @@ -11,7 +11,7 @@ namespace Octopus.Cli.Commands { /// /// This class exists to provide backwards compatibility to the pre 3.4.0 changes to machine state. - /// As of 3.4.0 the enum has been marked as obselete to be replaced with + /// As of 3.4.0 the enum has been marked as obsolete to be replaced with /// public class HealthStatusProvider { From 78389a26c5a62c7f0f05b2add7832c8981f7df71 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 2 Oct 2023 00:29:33 -0400 Subject: [PATCH 07/10] spelling: stop Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- source/Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs b/source/Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs index 61328ef629..77da685214 100644 --- a/source/Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs +++ b/source/Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs @@ -105,7 +105,7 @@ protected override async Task ValidateParameters() * A create release operation can also optionally deploy the release, however any invalid options that * are specific only to the deployment will fail after the release has been created. This can leave * a deployment in a half finished state, so this validation ensures that the input relating to the - * deployment is valid so missing or incorrect input doesn't stop stop the deployment after a release is + * deployment is valid so missing or incorrect input doesn't stop the deployment after a release is * created. * * Note that certain validations still need to be done on the server. Permissions and lifecycle progression From 70810b9bcb44c555cded8c7cd6f9b7448782cf4a Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 2 Oct 2023 00:33:03 -0400 Subject: [PATCH 08/10] spelling: tenants Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .../Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs b/source/Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs index 77da685214..f3e70fb927 100644 --- a/source/Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs +++ b/source/Octopus.Cli/Commands/Deployment/DeploymentCommandBase.cs @@ -315,8 +315,8 @@ async Task> GetTenants(ProjectResource project, .Select(tp => tp.Id) .ToArray(); - var tentats = await Repository.Tenants.Get(tenantPromotions).ConfigureAwait(false); - deployableTenants.AddRange(tentats); + var tenants = await Repository.Tenants.Get(tenantPromotions).ConfigureAwait(false); + deployableTenants.AddRange(tenants); commandOutputProvider.Information("Found {NumberOfTenants} Tenants who can deploy {Project:l} {Version:l} to {Environment:l}", deployableTenants.Count, From ed5fbbcd120ad623c2d511b7a332c3bd25d9fc57 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 2 Oct 2023 00:33:41 -0400 Subject: [PATCH 09/10] spelling: work around Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- BuildAssets/test-linux-package.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BuildAssets/test-linux-package.sh b/BuildAssets/test-linux-package.sh index 735832fb07..717650e850 100755 --- a/BuildAssets/test-linux-package.sh +++ b/BuildAssets/test-linux-package.sh @@ -28,7 +28,7 @@ fi if [[ "$OSRELID" == "fedora" ]]; then echo "Fedora detected. Setting DOTNET_BUNDLE_EXTRACT_BASE_DIR to $(pwd)/dotnet-extraction-dir" - # to workaround error + # to work around error # realpath(): Operation not permitted # Failure processing application bundle. # Failed to determine location for extracting embedded files From da7b0b187d694ae1cfc1b120973ae361aae2ec63 Mon Sep 17 00:00:00 2001 From: Josh Soref <2119212+jsoref@users.noreply.github.com> Date: Mon, 2 Oct 2023 00:29:13 -0400 Subject: [PATCH 10/10] spelling: workaround Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --- .github/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index e342866f94..a1027185e0 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -8,7 +8,7 @@ If your change is small or you have already made the change, please go ahead and For other changes, please raise an issue first to check that the change aligns with our plan for the product. We ask this to avoid disappointment and wasted effort if it does not. -If your pull request or proposed change is for a bug that is causing problems for you, please also [contact support](http://octopusdeploy.com/support) referencing your pull request to make sure it gets prioritized properly. They may also be able to find a work around in the meantime. +If your pull request or proposed change is for a bug that is causing problems for you, please also [contact support](http://octopusdeploy.com/support) referencing your pull request to make sure it gets prioritized properly. They may also be able to find a workaround in the meantime. If you have an idea or a feature request, please post it to [our UserVoice site](http://octopusdeploy.uservoice.com) so others can vote for it.