From 807d86256618bcde03ca93a6d2065aed1b497e21 Mon Sep 17 00:00:00 2001 From: Trent Mohay Date: Tue, 2 Jan 2024 12:02:50 +1100 Subject: [PATCH 1/5] Included libicu72 as valid version --- BuildAssets/create-octopuscli-linux-packages.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BuildAssets/create-octopuscli-linux-packages.sh b/BuildAssets/create-octopuscli-linux-packages.sh index 066ab4246b..f2fcdb8613 100755 --- a/BuildAssets/create-octopuscli-linux-packages.sh +++ b/BuildAssets/create-octopuscli-linux-packages.sh @@ -40,7 +40,7 @@ FPM_DEB_OPTS=( --depends 'libssl1.0.0 | libssl1.0.2 | libssl1.1 | libssl3' --depends 'libkrb5-3' --depends 'zlib1g' - --depends 'libicu52 | libicu55 | libicu57 | libicu60 | libicu63 | libicu66 | libicu67 | libicu70' + --depends 'libicu52 | libicu55 | libicu57 | libicu60 | libicu63 | libicu66 | libicu67 | libicu70 | libicu72' ) # Note: Microsoft recommends dep 'lttng-ust' but it seems to be unavailable in CentOS 7, so we're omitting it for now. # As it's related to tracing, hopefully it will not be required for normal usage. From 7eb62d5b18f5783f412c8e8586308e4b2590f45e Mon Sep 17 00:00:00 2001 From: Trent Mohay Date: Tue, 2 Jan 2024 13:13:51 +1100 Subject: [PATCH 2/5] add debug line to show installation complete --- BuildAssets/test-linux-package.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BuildAssets/test-linux-package.sh b/BuildAssets/test-linux-package.sh index 735832fb07..ed6eec0b81 100755 --- a/BuildAssets/test-linux-package.sh +++ b/BuildAssets/test-linux-package.sh @@ -20,6 +20,8 @@ fi bash ./install-linux-package.sh || exit +echo Installation complete succesfully. + if command -v dpkg > /dev/null; then echo Detected dpkg. Installing ca-certificates to support octo HTTPS communication. export DEBIAN_FRONTEND=noninteractive From 16052754b48840d06d4d0d0674fb28bbdaa8ac66 Mon Sep 17 00:00:00 2001 From: Trent Mohay Date: Tue, 2 Jan 2024 18:40:01 +1100 Subject: [PATCH 3/5] disable fail-fast in gha --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 64e4acf638..a4143c103f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -166,6 +166,7 @@ jobs: env: VERSION: ${{ needs.build.outputs.version }} strategy: + fail-fast: false matrix: distro: [ 'debian:stable-slim', From de8d74a3a7c6c2b42f10037c736e9d060f98bfa9 Mon Sep 17 00:00:00 2001 From: Trent Mohay Date: Tue, 9 Jan 2024 13:50:10 +1100 Subject: [PATCH 4/5] Revert un-required change --- BuildAssets/test-linux-package.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/BuildAssets/test-linux-package.sh b/BuildAssets/test-linux-package.sh index ed6eec0b81..735832fb07 100755 --- a/BuildAssets/test-linux-package.sh +++ b/BuildAssets/test-linux-package.sh @@ -20,8 +20,6 @@ fi bash ./install-linux-package.sh || exit -echo Installation complete succesfully. - if command -v dpkg > /dev/null; then echo Detected dpkg. Installing ca-certificates to support octo HTTPS communication. export DEBIAN_FRONTEND=noninteractive From 0a02c2ad014cf4148f480c699674cacad11ebe35 Mon Sep 17 00:00:00 2001 From: Trent Mohay Date: Tue, 9 Jan 2024 14:44:16 +1100 Subject: [PATCH 5/5] remove fail_fast --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a4143c103f..64e4acf638 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -166,7 +166,6 @@ jobs: env: VERSION: ${{ needs.build.outputs.version }} strategy: - fail-fast: false matrix: distro: [ 'debian:stable-slim',