diff --git a/source/Octopus.Cli/Exporters/ProjectExporter.cs b/source/Octopus.Cli/Exporters/ProjectExporter.cs index 0c13e6c4a..fecc8376f 100644 --- a/source/Octopus.Cli/Exporters/ProjectExporter.cs +++ b/source/Octopus.Cli/Exporters/ProjectExporter.cs @@ -84,10 +84,10 @@ protected override void Export(Dictionary parameters) { Log.Debug("Finding NuGet feed for step " + step.Name); FeedResource feed = null; - if (FeedResourceCustomExpressionHelper.IsValidRepositoryId(nugetFeedId.Value)) + if (FeedCustomExpressionHelper.IsRealFeedId(nugetFeedId.Value)) feed = Repository.Feeds.Get(nugetFeedId.Value); else - feed = FeedResourceCustomExpressionHelper.FeedResourceWithId(nugetFeedId.Value); + feed = FeedCustomExpressionHelper.CustomExpressionFeedWithId(nugetFeedId.Value); if (feed == null) throw new CouldNotFindException("NuGet feed for step", step.Name); diff --git a/source/Octopus.Cli/Importers/ProjectImporter.cs b/source/Octopus.Cli/Importers/ProjectImporter.cs index 38ff2fcdb..80bd1409d 100644 --- a/source/Octopus.Cli/Importers/ProjectImporter.cs +++ b/source/Octopus.Cli/Importers/ProjectImporter.cs @@ -544,10 +544,10 @@ protected CheckedReferences CheckNuGetFeedsExist(List - + diff --git a/source/Octopus.Cli/Util/FeedResourceCustomExpressionHelper.cs b/source/Octopus.Cli/Util/FeedCustomExpressionHelper.cs similarity index 72% rename from source/Octopus.Cli/Util/FeedResourceCustomExpressionHelper.cs rename to source/Octopus.Cli/Util/FeedCustomExpressionHelper.cs index 57b94290a..f1bc7f513 100644 --- a/source/Octopus.Cli/Util/FeedResourceCustomExpressionHelper.cs +++ b/source/Octopus.Cli/Util/FeedCustomExpressionHelper.cs @@ -1,20 +1,21 @@ using Octopus.Client.Model; +using System; namespace Octopus.Cli.Util { /// /// Helps with situations where feeds use custom expressions Eg. #{MyCustomFeedURL} /// - public static class FeedResourceCustomExpressionHelper + public static class FeedCustomExpressionHelper { - public static string FeedName = "Custom expression"; + public static string CustomExpressionFeedName = "Custom expression"; - public static FeedResource FeedResourceWithId(string id) + public static FeedResource CustomExpressionFeedWithId(string id) { var feed = new FeedResource() { Id = id, - Name = FeedResourceCustomExpressionHelper.FeedName + Name = FeedCustomExpressionHelper.CustomExpressionFeedName }; return feed; } @@ -29,9 +30,9 @@ public static FeedResource FeedResourceWithId(string id) /// /// /// - public static bool IsValidRepositoryId(string id) + public static bool IsRealFeedId(string id) { - if (id.ToLowerInvariant().StartsWith("feeds-")) + if (id.StartsWith("feeds-", StringComparison.OrdinalIgnoreCase)) return true; return false; }