From 134024d952d4e5162298a925b6cb288865e32ba1 Mon Sep 17 00:00:00 2001 From: Shane Gill Date: Thu, 13 Feb 2025 08:55:03 +1000 Subject: [PATCH 1/5] Rename tenant variable property --- ...ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt | 4 ++-- .../TenantVariables/GetCommonVariablesByTenantIdRequest.cs | 4 ++-- .../TenantVariables/GetProjectVariablesByTenantIdRequest.cs | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt index f6f3444c..68bbf23c 100644 --- a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt +++ b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt @@ -7459,8 +7459,8 @@ Octopus.Client.Model.TenantVariables class GetCommonVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantCommonVariable[]) - Octopus.Client.Model.TenantVariables.TenantCommonVariable[] CommonVariables { get; set; } String TenantId { get; set; } + Octopus.Client.Model.TenantVariables.TenantCommonVariable[] Variables { get; set; } } class GetProjectVariablesByTenantIdRequest { @@ -7471,8 +7471,8 @@ Octopus.Client.Model.TenantVariables class GetProjectVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantProjectVariable[]) - Octopus.Client.Model.TenantVariables.TenantProjectVariable[] ProjectVariables { get; set; } String TenantId { get; set; } + Octopus.Client.Model.TenantVariables.TenantProjectVariable[] Variables { get; set; } } class ModifyCommonVariablesByTenantIdCommand { diff --git a/source/Octopus.Server.Client/Model/TenantVariables/GetCommonVariablesByTenantIdRequest.cs b/source/Octopus.Server.Client/Model/TenantVariables/GetCommonVariablesByTenantIdRequest.cs index 3c162b62..d5f85de1 100644 --- a/source/Octopus.Server.Client/Model/TenantVariables/GetCommonVariablesByTenantIdRequest.cs +++ b/source/Octopus.Server.Client/Model/TenantVariables/GetCommonVariablesByTenantIdRequest.cs @@ -7,9 +7,9 @@ public class GetCommonVariablesByTenantIdRequest(string tenantId, string spaceId public string SpaceId { get; set; } = spaceId; } -public class GetCommonVariablesByTenantIdResponse(string tenantId, TenantCommonVariable[] commonVariables) +public class GetCommonVariablesByTenantIdResponse(string tenantId, TenantCommonVariable[] variables) { public string TenantId { get; set; } = tenantId; - public TenantCommonVariable[] CommonVariables { get; set; } = commonVariables; + public TenantCommonVariable[] Variables { get; set; } = variables; } \ No newline at end of file diff --git a/source/Octopus.Server.Client/Model/TenantVariables/GetProjectVariablesByTenantIdRequest.cs b/source/Octopus.Server.Client/Model/TenantVariables/GetProjectVariablesByTenantIdRequest.cs index ec2a3400..a3b0e603 100644 --- a/source/Octopus.Server.Client/Model/TenantVariables/GetProjectVariablesByTenantIdRequest.cs +++ b/source/Octopus.Server.Client/Model/TenantVariables/GetProjectVariablesByTenantIdRequest.cs @@ -7,9 +7,9 @@ public class GetProjectVariablesByTenantIdRequest(string tenantId, string spaceI public string SpaceId { get; set; } = spaceId; } -public class GetProjectVariablesByTenantIdResponse(string tenantId, TenantProjectVariable[] projectVariables) +public class GetProjectVariablesByTenantIdResponse(string tenantId, TenantProjectVariable[] variables) { public string TenantId { get; set; } = tenantId; - public TenantProjectVariable[] ProjectVariables { get; set; } = projectVariables; + public TenantProjectVariable[] Variables { get; set; } = variables; } \ No newline at end of file From eac56c894e82b5b95822088448316a0578b13848 Mon Sep 17 00:00:00 2001 From: Shane Gill Date: Thu, 13 Feb 2025 09:26:43 +1000 Subject: [PATCH 2/5] I APPROVE --- ...blicSurfaceAreaShouldNotRegress..NETFramework.approved.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt index 3a1fb457..261a6153 100644 --- a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt +++ b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt @@ -7483,7 +7483,7 @@ Octopus.Client.Model.TenantVariables class GetCommonVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantCommonVariable[]) - Octopus.Client.Model.TenantVariables.TenantCommonVariable[] CommonVariables { get; set; } + Octopus.Client.Model.TenantVariables.TenantCommonVariable[] Variables { get; set; } String TenantId { get; set; } } class GetProjectVariablesByTenantIdRequest @@ -7521,7 +7521,7 @@ Octopus.Client.Model.TenantVariables class ModifyProjectVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantProjectVariable[]) - Octopus.Client.Model.TenantVariables.TenantProjectVariable[] ProjectVariables { get; set; } + Octopus.Client.Model.TenantVariables.TenantProjectVariable[] Variables { get; set; } String TenantId { get; set; } } class ProjectVariableScope From e14985a28ffff149f266ffa8daf074bff8e10899 Mon Sep 17 00:00:00 2001 From: Shane Gill Date: Thu, 13 Feb 2025 10:04:26 +1000 Subject: [PATCH 3/5] I APPROVE MORE --- ...blicSurfaceAreaShouldNotRegress..NETFramework.approved.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt index 261a6153..596bb0d9 100644 --- a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt +++ b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt @@ -7495,7 +7495,7 @@ Octopus.Client.Model.TenantVariables class GetProjectVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantProjectVariable[]) - Octopus.Client.Model.TenantVariables.TenantProjectVariable[] ProjectVariables { get; set; } + Octopus.Client.Model.TenantVariables.TenantProjectVariable[] Variables { get; set; } String TenantId { get; set; } } class ModifyCommonVariablesByTenantIdCommand @@ -7508,7 +7508,7 @@ Octopus.Client.Model.TenantVariables class ModifyCommonVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantCommonVariable[]) - Octopus.Client.Model.TenantVariables.TenantCommonVariable[] CommonVariables { get; set; } + Octopus.Client.Model.TenantVariables.TenantCommonVariable[] Variables { get; set; } String TenantId { get; set; } } class ModifyProjectVariablesByTenantIdCommand From 4e367e6926281471b489f2790b5cd8dfaf80e384 Mon Sep 17 00:00:00 2001 From: Shane Gill Date: Thu, 13 Feb 2025 10:13:02 +1000 Subject: [PATCH 4/5] Who even uses full framework --- ...SurfaceAreaShouldNotRegress..NETFramework.approved.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt index 596bb0d9..94f96b30 100644 --- a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt +++ b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt @@ -7483,8 +7483,8 @@ Octopus.Client.Model.TenantVariables class GetCommonVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantCommonVariable[]) - Octopus.Client.Model.TenantVariables.TenantCommonVariable[] Variables { get; set; } String TenantId { get; set; } + Octopus.Client.Model.TenantVariables.TenantCommonVariable[] Variables { get; set; } } class GetProjectVariablesByTenantIdRequest { @@ -7495,8 +7495,8 @@ Octopus.Client.Model.TenantVariables class GetProjectVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantProjectVariable[]) - Octopus.Client.Model.TenantVariables.TenantProjectVariable[] Variables { get; set; } String TenantId { get; set; } + Octopus.Client.Model.TenantVariables.TenantProjectVariable[] Variables { get; set; } } class ModifyCommonVariablesByTenantIdCommand { @@ -7508,8 +7508,8 @@ Octopus.Client.Model.TenantVariables class ModifyCommonVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantCommonVariable[]) - Octopus.Client.Model.TenantVariables.TenantCommonVariable[] Variables { get; set; } String TenantId { get; set; } + Octopus.Client.Model.TenantVariables.TenantCommonVariable[] Variables { get; set; } } class ModifyProjectVariablesByTenantIdCommand { @@ -7521,8 +7521,8 @@ Octopus.Client.Model.TenantVariables class ModifyProjectVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantProjectVariable[]) - Octopus.Client.Model.TenantVariables.TenantProjectVariable[] Variables { get; set; } String TenantId { get; set; } + Octopus.Client.Model.TenantVariables.TenantProjectVariable[] Variables { get; set; } } class ProjectVariableScope { From 7f8e22dfff00ed3945f409b1be0522410864e135 Mon Sep 17 00:00:00 2001 From: Shane Gill Date: Thu, 13 Feb 2025 10:30:04 +1000 Subject: [PATCH 5/5] ... --- ...ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt | 4 ++-- .../TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs | 4 ++-- .../ModifyProjectVariablesByTenantIdCommand.cs | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt index 68bbf23c..c4b63598 100644 --- a/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt +++ b/source/Octopus.Client.Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt @@ -7484,8 +7484,8 @@ Octopus.Client.Model.TenantVariables class ModifyCommonVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantCommonVariable[]) - Octopus.Client.Model.TenantVariables.TenantCommonVariable[] CommonVariables { get; set; } String TenantId { get; set; } + Octopus.Client.Model.TenantVariables.TenantCommonVariable[] Variables { get; set; } } class ModifyProjectVariablesByTenantIdCommand { @@ -7497,8 +7497,8 @@ Octopus.Client.Model.TenantVariables class ModifyProjectVariablesByTenantIdResponse { .ctor(String, Octopus.Client.Model.TenantVariables.TenantProjectVariable[]) - Octopus.Client.Model.TenantVariables.TenantProjectVariable[] ProjectVariables { get; set; } String TenantId { get; set; } + Octopus.Client.Model.TenantVariables.TenantProjectVariable[] Variables { get; set; } } class ProjectVariableScope { diff --git a/source/Octopus.Server.Client/Model/TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs b/source/Octopus.Server.Client/Model/TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs index 981fb960..98a62a47 100644 --- a/source/Octopus.Server.Client/Model/TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs +++ b/source/Octopus.Server.Client/Model/TenantVariables/ModifyCommonVariablesByTenantIdCommand.cs @@ -28,9 +28,9 @@ public class CommonVariableScope(ReferenceCollection environmentIds) public ReferenceCollection EnvironmentIds { get; set; } = environmentIds; } -public class ModifyCommonVariablesByTenantIdResponse(string tenantId, TenantCommonVariable[] commonVariables) +public class ModifyCommonVariablesByTenantIdResponse(string tenantId, TenantCommonVariable[] variables) { public string TenantId { get; set; } = tenantId; - public TenantCommonVariable[] CommonVariables { get; set; } = commonVariables; + public TenantCommonVariable[] Variables { get; set; } = variables; } diff --git a/source/Octopus.Server.Client/Model/TenantVariables/ModifyProjectVariablesByTenantIdCommand.cs b/source/Octopus.Server.Client/Model/TenantVariables/ModifyProjectVariablesByTenantIdCommand.cs index 9b8031e8..b4dfea1e 100644 --- a/source/Octopus.Server.Client/Model/TenantVariables/ModifyProjectVariablesByTenantIdCommand.cs +++ b/source/Octopus.Server.Client/Model/TenantVariables/ModifyProjectVariablesByTenantIdCommand.cs @@ -31,10 +31,10 @@ public class ProjectVariableScope(ReferenceCollection environmentIds) public ReferenceCollection EnvironmentIds { get; set; } = environmentIds; } -public class ModifyProjectVariablesByTenantIdResponse(string tenantId, TenantProjectVariable[] projectVariables) +public class ModifyProjectVariablesByTenantIdResponse(string tenantId, TenantProjectVariable[] variables) { public string TenantId { get; set; } = tenantId; - public TenantProjectVariable[] ProjectVariables { get; set; } = projectVariables; + public TenantProjectVariable[] Variables { get; set; } = variables; }