fix: Fix return type of getAll for Ephemeral Environments (#374)

lourens-octopus · web-flow · commit 01f4f4d03e21 · 2025-11-03T10:46:55.000+13:00
The return type is set to the general base environment type, however we know our query will return only ephemeral environments
diff --git a/pkg/environments/v2/ephemeralenvironments/ephemeral_environment_service.go b/pkg/environments/v2/ephemeralenvironments/ephemeral_environment_service.go
@@ -9,14 +9,14 @@ import (
 	"github.com/OctopusDeploy/go-octopusdeploy/v2/pkg/resources"
 )
 
-func GetAll(client newclient.Client, spaceID string) (*resources.Resources[*environments.Environment], error) {
+func GetAll(client newclient.Client, spaceID string) (*resources.Resources[*EphemeralEnvironment], error) {
 	query := &environments.EnvironmentQuery{
 		Skip: 0,
 		Take: math.MaxInt32,
 		Type: []string{"Ephemeral"},
 	}
 
-	return newclient.GetByQuery[environments.Environment](client, v2.Template, spaceID, query)
+	return newclient.GetByQuery[EphemeralEnvironment](client, v2.Template, spaceID, query)
 }
 
 type CreateEnvironmentResponse struct {

Original file line number	Diff line number	Diff line change
`@@ -9,14 +9,14 @@ import (`
`9`	`9`	`"github.com/OctopusDeploy/go-octopusdeploy/v2/pkg/resources"`
`10`	`10`	`)`
`11`	`11`
`12`		`-func GetAll(client newclient.Client, spaceID string) (resources.Resources[environments.Environment], error) {`
	`12`	`+func GetAll(client newclient.Client, spaceID string) (resources.Resources[EphemeralEnvironment], error) {`
`13`	`13`	`query := &environments.EnvironmentQuery{`
`14`	`14`	`Skip: 0,`
`15`	`15`	`Take: math.MaxInt32,`
`16`	`16`	`Type: []string{"Ephemeral"},`
`17`	`17`	`}`
`18`	`18`
`19`		`- return newclient.GetByQuery[environments.Environment](client, v2.Template, spaceID, query)`
	`19`	`+ return newclient.GetByQuery[EphemeralEnvironment](client, v2.Template, spaceID, query)`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`type CreateEnvironmentResponse struct {`