Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:wqa results in "E948: Job still running" because invisible terminal window #644

Open
positron opened this issue Feb 4, 2025 · 3 comments
Labels
bug Something isn't working neovim-upstream-issue

Comments

@positron
Copy link

positron commented Feb 4, 2025

Running :wqa tries to save all buffers then close them all. This fails, surprisingly if you never opened the conjure log buffer, because it is open but invisible.

Reproduction steps:

  • nvim test.clj
  • :wqa
    E948: Job still running
    E676: No matching autocommands for buftype= buffer
    
  • :ls!                                                                                                                                                                                                                                                                                                                                                                                                                                                                     
      1 %a   "test.clj"           line 76                                                                                                                                                                                                                                                                                                                                                                                                                          
      2u h   "conjure-log-74563.cljc"       line 0                                                                                                                                                                                                                                                                                                                                                                                                                           
      3 #hR  "term://~/projects/foo//74574:bb nrepl-server localhost:52386" line 1  
    
  • :bwipeout! 3 - force kill the nrepl terminal
  • :wqa - now works
@Olical Olical added the bug Something isn't working label Feb 4, 2025
@Olical
Copy link
Owner

Olical commented Feb 4, 2025

Thanks for reporting this! I can reproduce it and I think basically have a fix in place, just in the middle of prep before a long bit of travelling 😅 it might end up getting finished tonight, tomorrow, or on an 8 hour flight to India...

Should be a fairly quick fix though, just need to mark the terminal buffer appropriately so it's not attached to a file as we do with the log buffer.

Disabling the auto REPL for Clojure will also temporarily fix this, although you'll lose the auto bb REPL which might suck for your workflow.

@Olical
Copy link
Owner

Olical commented Feb 4, 2025

Oh! It looks like this might just be a Neovim thing that I can't work around! https://vi.stackexchange.com/questions/42547/cant-use-wqa-with-open-terminal-buffers

I tried to set the buftype to nofile but you can't set a terminal buffer type to anything other than terminal.

Here's an upstream neovim issue for this too neovim/neovim#14061

And there's always this workaround: kevinhwang91/rnvimr#76 (comment)

You could maybe create your own override for wqa essentially that avoids the issue? I didn't even know the command existed until today 😅

@positron
Copy link
Author

positron commented Feb 4, 2025

Oh wow, bummer you can't work around that right now.

Thanks for looking in to it super quick! Love the plugin, I just switched from vim-fireplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working neovim-upstream-issue
Projects
None yet
Development

No branches or pull requests

2 participants